[jira] [Commented] (KYLIN-5681) SCD2 can not work
[ https://issues.apache.org/jira/browse/KYLIN-5681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752286#comment-17752286 ] ASF subversion and git services commented on KYLIN-5681: Commit 4093d3f0acb4b29788e20248f4d78eff321a7f17 in kylin's branch refs/heads/kylin5 from Pengfei Zhan [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=4093d3f0ac ] KYLIN-5681 fix scd2 modeling > SCD2 can not work > -- > > Key: KYLIN-5681 > URL: https://issues.apache.org/jira/browse/KYLIN-5681 > Project: Kylin > Issue Type: Bug > Components: Modeling >Affects Versions: 5.0-alpha >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0-beta > > Attachments: image-2023-08-09-13-12-20-353.png > > > [https://kylin.apache.org/5.0/docs/modeling/model_design/slowly_changing_dimension#scd2-model-based-on-history-table] > I create a scd2 model, but get an error message. > !image-2023-08-09-13-12-20-353.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5681) SCD2 can not work
[ https://issues.apache.org/jira/browse/KYLIN-5681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752285#comment-17752285 ] ASF GitHub Bot commented on KYLIN-5681: --- hit-lacus merged PR #2145: URL: https://github.com/apache/kylin/pull/2145 > SCD2 can not work > -- > > Key: KYLIN-5681 > URL: https://issues.apache.org/jira/browse/KYLIN-5681 > Project: Kylin > Issue Type: Bug > Components: Modeling >Affects Versions: 5.0-alpha >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0-beta > > Attachments: image-2023-08-09-13-12-20-353.png > > > [https://kylin.apache.org/5.0/docs/modeling/model_design/slowly_changing_dimension#scd2-model-based-on-history-table] > I create a scd2 model, but get an error message. > !image-2023-08-09-13-12-20-353.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5681) SCD2 can not work
[ https://issues.apache.org/jira/browse/KYLIN-5681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752267#comment-17752267 ] ASF GitHub Bot commented on KYLIN-5681: --- pfzhan commented on PR #2145: URL: https://github.com/apache/kylin/pull/2145#issuecomment-1670701765 retest this please > SCD2 can not work > -- > > Key: KYLIN-5681 > URL: https://issues.apache.org/jira/browse/KYLIN-5681 > Project: Kylin > Issue Type: Bug > Components: Modeling >Affects Versions: 5.0-alpha >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0-beta > > Attachments: image-2023-08-09-13-12-20-353.png > > > [https://kylin.apache.org/5.0/docs/modeling/model_design/slowly_changing_dimension#scd2-model-based-on-history-table] > I create a scd2 model, but get an error message. > !image-2023-08-09-13-12-20-353.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5681) SCD2 can not work
[ https://issues.apache.org/jira/browse/KYLIN-5681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752266#comment-17752266 ] pengfei.zhan commented on KYLIN-5681: - The modeling depends on ModelSmartSupporter, but this is unnecessary. We just need to analyze sql to get a complete the non-equal-join info. The pr [https://github.com/apache/kylin/pull/2145] gives a simple way to deal with this problem. > SCD2 can not work > -- > > Key: KYLIN-5681 > URL: https://issues.apache.org/jira/browse/KYLIN-5681 > Project: Kylin > Issue Type: Bug > Components: Modeling >Affects Versions: 5.0-alpha >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0-beta > > Attachments: image-2023-08-09-13-12-20-353.png > > > [https://kylin.apache.org/5.0/docs/modeling/model_design/slowly_changing_dimension#scd2-model-based-on-history-table] > I create a scd2 model, but get an error message. > !image-2023-08-09-13-12-20-353.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5681) SCD2 can not work
[ https://issues.apache.org/jira/browse/KYLIN-5681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752263#comment-17752263 ] ASF GitHub Bot commented on KYLIN-5681: --- pfzhan opened a new pull request, #2145: URL: https://github.com/apache/kylin/pull/2145 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... > SCD2 can not work > -- > > Key: KYLIN-5681 > URL: https://issues.apache.org/jira/browse/KYLIN-5681 > Project: Kylin > Issue Type: Bug > Components: Modeling >Affects Versions: 5.0-alpha >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0-beta > > Attachments: image-2023-08-09-13-12-20-353.png > > > [https://kylin.apache.org/5.0/docs/modeling/model_design/slowly_changing_dimension#scd2-model-based-on-history-table] > I create a scd2 model, but get an error message. > !image-2023-08-09-13-12-20-353.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)