[jira] [Commented] (SOLR-12690) Regularize LoggerFactory declarations

2020-04-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090250#comment-17090250 ] David Smiley commented on SOLR-12690: - [~erickerickson] looks like you goofed in SolrShardReporter

[jira] [Commented] (LUCENE-9328) SortingGroupHead to reuse DocValues

2020-04-22 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090216#comment-17090216 ] Lucene/Solr QA commented on LUCENE-9328: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Created] (SOLR-14427) Potential bug in optimistic concurrency with versions=true and failOnVersionConflicts=false

2020-04-22 Thread Sachin Divekar (Jira)
Sachin Divekar created SOLR-14427: - Summary: Potential bug in optimistic concurrency with versions=true and failOnVersionConflicts=false Key: SOLR-14427 URL: https://issues.apache.org/jira/browse/SOLR-14427

[jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

2020-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090178#comment-17090178 ] ASF subversion and git services commented on LUCENE-7788: - Commit

[jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

2020-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090177#comment-17090177 ] ASF subversion and git services commented on LUCENE-7788: - Commit

[jira] [Updated] (SOLR-14413) allow timeAllowed and cursorMark parameters

2020-04-22 Thread John Gallagher (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Gallagher updated SOLR-14413: -- Attachment: timeallowed_cursormarks_results.txt > allow timeAllowed and cursorMark parameters

[GitHub] [lucene-solr] andyvuong commented on issue #1424: Enable shared store via system property only

2020-04-22 Thread GitBox
andyvuong commented on issue #1424: URL: https://github.com/apache/lucene-solr/pull/1424#issuecomment-618082614 @yonik can you merge? This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (LUCENE-9328) SortingGroupHead to reuse DocValues

2020-04-22 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated LUCENE-9328: - Attachment: LUCENE-9328.patch Lucene Fields: New,Patch Available (was: New)

[GitHub] [lucene-solr] mkhludnev commented on issue #1439: tiny refguide tweaks

2020-04-22 Thread GitBox
mkhludnev commented on issue #1439: URL: https://github.com/apache/lucene-solr/pull/1439#issuecomment-618079995 pushed https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=3a743ea This is an automated message from the

[jira] [Created] (LUCENE-9342) Collector's totalHitsThreshold should not be lower than numHits

2020-04-22 Thread Tomas Eduardo Fernandez Lobbe (Jira)
Tomas Eduardo Fernandez Lobbe created LUCENE-9342: - Summary: Collector's totalHitsThreshold should not be lower than numHits Key: LUCENE-9342 URL: https://issues.apache.org/jira/browse/LUCENE-9342

[jira] [Commented] (SOLR-8394) Luke handler doesn't support FilterLeafReader

2020-04-22 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090040#comment-17090040 ] Isabelle Giguere commented on SOLR-8394: Hi [~dsmiley]; The real-world circumstance is easy : just

[jira] [Commented] (SOLR-12490) Introducing json.queries was:Query DSL supports for further referring and exclusion in JSON facets

2020-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090015#comment-17090015 ] ASF subversion and git services commented on SOLR-12490: Commit

[jira] [Commented] (SOLR-8998) JSON Facet API child roll-ups

2020-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090014#comment-17090014 ] ASF subversion and git services commented on SOLR-8998: --- Commit

[jira] [Commented] (SOLR-12490) Introducing json.queries was:Query DSL supports for further referring and exclusion in JSON facets

2020-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090012#comment-17090012 ] ASF subversion and git services commented on SOLR-12490: Commit

[jira] [Commented] (SOLR-8998) JSON Facet API child roll-ups

2020-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090011#comment-17090011 ] ASF subversion and git services commented on SOLR-8998: --- Commit

[GitHub] [lucene-solr] tflobbe commented on issue #1448: NumHits vs totalHitsThreshold test

2020-04-22 Thread GitBox
tflobbe commented on issue #1448: URL: https://github.com/apache/lucene-solr/pull/1448#issuecomment-618000786 Sounds good, I'll take a look. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] jimczi commented on issue #1448: NumHits vs totalHitsThreshold test

2020-04-22 Thread GitBox
jimczi commented on issue #1448: URL: https://github.com/apache/lucene-solr/pull/1448#issuecomment-617997646 > I don't mind the change, if you'd like to make sure we always count at least numHits hits, I'd be happy to approve the PR. +1 too.

[jira] [Commented] (LUCENE-9341) maven validation job fails needing https

2020-04-22 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089982#comment-17089982 ] Mike Drob commented on LUCENE-9341: --- Note that according to the maven page, the maven ant tasks

[jira] [Commented] (LUCENE-9324) Give IDs to SegmentCommitInfo

2020-04-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089975#comment-17089975 ] David Smiley commented on LUCENE-9324: -- I really appreciate that explanation Simon; thanks! > Give

[jira] [Commented] (LUCENE-9339) Only call MergeScheduler when we actually found new merges

2020-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089974#comment-17089974 ] ASF subversion and git services commented on LUCENE-9339: - Commit

[jira] [Resolved] (LUCENE-9339) Only call MergeScheduler when we actually found new merges

2020-04-22 Thread Simon Willnauer (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer resolved LUCENE-9339. - Fix Version/s: 8.6 master (9.0) Lucene Fields: New,Patch

[GitHub] [lucene-solr] jpountz commented on issue #1448: NumHits vs totalHitsThreshold test

2020-04-22 Thread GitBox
jpountz commented on issue #1448: URL: https://github.com/apache/lucene-solr/pull/1448#issuecomment-617983665 Indeed I think it can happen if you use a fixed threshold, say 100, and then perform pagination. If you have pages of 10 hits and go to the 11th page, shards would get passed

[jira] [Commented] (LUCENE-9339) Only call MergeScheduler when we actually found new merges

2020-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089969#comment-17089969 ] ASF subversion and git services commented on LUCENE-9339: - Commit

[jira] [Commented] (SOLR-8394) Luke handler doesn't support FilterLeafReader

2020-04-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089964#comment-17089964 ] David Smiley commented on SOLR-8394: Looks pretty good, but I'd like to see you improve the code

[GitHub] [lucene-solr] jpountz commented on issue #1448: NumHits vs totalHitsThreshold test

2020-04-22 Thread GitBox
jpountz commented on issue #1448: URL: https://github.com/apache/lucene-solr/pull/1448#issuecomment-617975660 Since the contract is that Lucene might return GREATER_THAN_OR_EQUAL_TO if the hit count is greater than the threshold, both the current behavior and the behavior you suggest look

[jira] [Commented] (LUCENE-9334) Require consistency between data-structures on a per-field basis

2020-04-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089935#comment-17089935 ] David Smiley commented on LUCENE-9334: -- The scope of this seems to subsume LUCENE-9078, so I'm

[GitHub] [lucene-solr] tflobbe opened a new pull request #1448: NumHits vs totalHitsThreshold test

2020-04-22 Thread GitBox
tflobbe opened a new pull request #1448: URL: https://github.com/apache/lucene-solr/pull/1448 While looking at SOLR-13289 I noticed this situation. If I create a collector with `numHits` greater than `totalHitsThreshold`, and the number of hits in the query is somewhere between those two

[jira] [Created] (LUCENE-9341) maven validation job fails needing https

2020-04-22 Thread Mike Drob (Jira)
Mike Drob created LUCENE-9341: - Summary: maven validation job fails needing https Key: LUCENE-9341 URL: https://issues.apache.org/jira/browse/LUCENE-9341 Project: Lucene - Core Issue Type: Bug

[GitHub] [lucene-solr] Humbedooh commented on issue #1447: LUCENE-9340: Deprecate SimpleBindings#add(SortField)

2020-04-22 Thread GitBox
Humbedooh commented on issue #1447: URL: https://github.com/apache/lucene-solr/pull/1447#issuecomment-617921511 link test... This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [lucene-solr] Humbedooh removed a comment on issue #1447: LUCENE-9340: Deprecate SimpleBindings#add(SortField)

2020-04-22 Thread GitBox
Humbedooh removed a comment on issue #1447: URL: https://github.com/apache/lucene-solr/pull/1447#issuecomment-617920031 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene-solr] Humbedooh commented on issue #1447: LUCENE-9340: Deprecate SimpleBindings#add(SortField)

2020-04-22 Thread GitBox
Humbedooh commented on issue #1447: URL: https://github.com/apache/lucene-solr/pull/1447#issuecomment-617920031 one more test :| This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (SOLR-14413) allow timeAllowed and cursorMark parameters

2020-04-22 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089877#comment-17089877 ] Mike Drob commented on SOLR-14413: -- What is the behavior when timeAllowed is exceeded? Do we get a

[GitHub] [lucene-solr] Humbedooh commented on issue #1447: LUCENE-9340: Deprecate SimpleBindings#add(SortField)

2020-04-22 Thread GitBox
Humbedooh commented on issue #1447: URL: https://github.com/apache/lucene-solr/pull/1447#issuecomment-617918148 test comment, please ignore This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (SOLR-14412) NPE in MetricsHistoryHandler when running single node in cloud mode with SSL

2020-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089868#comment-17089868 ] ASF subversion and git services commented on SOLR-14412: Commit

[jira] [Resolved] (SOLR-14420) Address AuthenticationPlugin TODO redeclare params as HttpServletRequest & HttpServletResponse

2020-04-22 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-14420. -- Fix Version/s: master (9.0) Assignee: Mike Drob Resolution: Fixed > Address

[jira] [Commented] (SOLR-12386) Test fails for "Can't find resource" for files in the _default configset

2020-04-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089813#comment-17089813 ] David Smiley commented on SOLR-12386: - I think I know what the problem is: We're not taking care to

[GitHub] [lucene-solr] romseygeek opened a new pull request #1447: LUCENE-9340: Deprecate SimpleBindings#add(SortField)

2020-04-22 Thread GitBox
romseygeek opened a new pull request #1447: URL: https://github.com/apache/lucene-solr/pull/1447 This method is trappy; it doesn't work for all SortField types, but doesn't tell you that until runtime. This commit deprecates it, and removes all other callsites in the codebase.

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1446: SOLR-14425: Aliases: ZK sync() needs to be synchronous

2020-04-22 Thread GitBox
dsmiley commented on a change in pull request #1446: URL: https://github.com/apache/lucene-solr/pull/1446#discussion_r413106360 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java ## @@ -843,6 +847,31 @@ public void downloadFromZK(String zkPath,

[jira] [Updated] (SOLR-14426) forbidden api error during precommit DateMathFunction

2020-04-22 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-14426: - Description: When running `./gradlew precommit` I'll occasionally see {code} * What went wrong:

[jira] [Created] (SOLR-14426) forbidden api error during precommit DateMathFunction

2020-04-22 Thread Mike Drob (Jira)
Mike Drob created SOLR-14426: Summary: forbidden api error during precommit DateMathFunction Key: SOLR-14426 URL: https://issues.apache.org/jira/browse/SOLR-14426 Project: Solr Issue Type: Bug

[jira] [Commented] (SOLR-12845) Add a default cluster policy

2020-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089800#comment-17089800 ] ASF subversion and git services commented on SOLR-12845: Commit

[jira] [Commented] (SOLR-12845) Add a default cluster policy

2020-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089801#comment-17089801 ] ASF subversion and git services commented on SOLR-12845: Commit

[jira] [Commented] (SOLR-14423) static caches in StreamHandler ought to move to CoreContainer lifecycle

2020-04-22 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089798#comment-17089798 ] Andrzej Bialecki commented on SOLR-14423: - Fair enough :) {{SolrCloudManager}} was an effort to

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1446: SOLR-14425: Aliases: ZK sync() needs to be synchronous

2020-04-22 Thread GitBox
HoustonPutman commented on a change in pull request #1446: URL: https://github.com/apache/lucene-solr/pull/1446#discussion_r413089452 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java ## @@ -843,6 +847,31 @@ public void downloadFromZK(String

[jira] [Commented] (SOLR-14425) Fix ZK sync usage to be synchronous (blocking)

2020-04-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089777#comment-17089777 ] David Smiley commented on SOLR-14425: - Odd; no link from GH so here it is:

[GitHub] [lucene-solr] dsmiley opened a new pull request #1446: SOLR-14425: Aliases: ZK sync() needs to be synchronous

2020-04-22 Thread GitBox
dsmiley opened a new pull request #1446: URL: https://github.com/apache/lucene-solr/pull/1446 https://issues.apache.org/jira/browse/SOLR-14425 CC @dragonsinth @tflobbe Does this make sense? Separately, I'll file an issue to add CuratorFramework to SolrZkClient

[jira] [Created] (SOLR-14425) Fix ZK sync usage to be synchronous (blocking)

2020-04-22 Thread David Smiley (Jira)
David Smiley created SOLR-14425: --- Summary: Fix ZK sync usage to be synchronous (blocking) Key: SOLR-14425 URL: https://issues.apache.org/jira/browse/SOLR-14425 Project: Solr Issue Type: Bug

[jira] [Created] (LUCENE-9340) Deprecate and remove the SimpleBindings.add(SortField) method

2020-04-22 Thread Alan Woodward (Jira)
Alan Woodward created LUCENE-9340: - Summary: Deprecate and remove the SimpleBindings.add(SortField) method Key: LUCENE-9340 URL: https://issues.apache.org/jira/browse/LUCENE-9340 Project: Lucene -

[jira] [Commented] (SOLR-14423) static caches in StreamHandler ought to move to CoreContainer lifecycle

2020-04-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089726#comment-17089726 ] David Smiley commented on SOLR-14423: - Interesting; I've never seen/heard of {{SolrCloudManager}}

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-04-22 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089705#comment-17089705 ] Uwe Schindler commented on LUCENE-9321: --- bq. If there are no big obstacles to make the change, I

[GitHub] [lucene-solr] dweiss commented on issue #1445: LUCENE-9339: Only call MergeScheduler when we actually found new merges

2020-04-22 Thread GitBox
dweiss commented on issue #1445: URL: https://github.com/apache/lucene-solr/pull/1445#issuecomment-617790438 I never fully understood what this parameter would be useful for, actually. LGTM. This is an automated message

[jira] [Updated] (SOLR-12845) Add a default cluster policy

2020-04-22 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-12845: Fix Version/s: 8.6 > Add a default cluster policy > > >

[GitHub] [lucene-solr] s1monw commented on issue #1445: LUCENE-9339: Only call MergeScheduler when we actually found new merges

2020-04-22 Thread GitBox
s1monw commented on issue #1445: URL: https://github.com/apache/lucene-solr/pull/1445#issuecomment-617761242 @mikemccand maybe you can take a look? I think this API is expert enough to also break this in 8.6? This is an

[GitHub] [lucene-solr] s1monw opened a new pull request #1445: LUCENE-9339: Only call MergeScheduler when we actually found new merges

2020-04-22 Thread GitBox
s1monw opened a new pull request #1445: URL: https://github.com/apache/lucene-solr/pull/1445 IW#maybeMerge calls the MergeScheduler even if it didn't find any merges we should instead only do this if there is in-fact anything there to merge and safe the call into a sync'd method.

[jira] [Created] (LUCENE-9339) Only call MergeScheduler when we actually found new merges

2020-04-22 Thread Simon Willnauer (Jira)
Simon Willnauer created LUCENE-9339: --- Summary: Only call MergeScheduler when we actually found new merges Key: LUCENE-9339 URL: https://issues.apache.org/jira/browse/LUCENE-9339 Project: Lucene -

[jira] [Commented] (LUCENE-9335) Add a bulk scorer for disjunctions that does dynamic pruning

2020-04-22 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089640#comment-17089640 ] Adrien Grand commented on LUCENE-9335: -- No I'm not, feel free to take it! For what it's worth,

[jira] [Commented] (LUCENE-9335) Add a bulk scorer for disjunctions that does dynamic pruning

2020-04-22 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089637#comment-17089637 ] Atri Sharma commented on LUCENE-9335: - +1. I was looking at comparisons with Vespa recently and

[jira] [Commented] (LUCENE-9337) CMS might miss to pickup pending merges when maxMergeCount changes while merges are running

2020-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089632#comment-17089632 ] ASF subversion and git services commented on LUCENE-9337: - Commit

[jira] [Resolved] (LUCENE-9337) CMS might miss to pickup pending merges when maxMergeCount changes while merges are running

2020-04-22 Thread Simon Willnauer (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer resolved LUCENE-9337. - Fix Version/s: 8.6 master (9.0) Assignee: Simon Willnauer

[jira] [Commented] (LUCENE-9337) CMS might miss to pickup pending merges when maxMergeCount changes while merges are running

2020-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089627#comment-17089627 ] ASF subversion and git services commented on LUCENE-9337: - Commit

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-04-22 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089622#comment-17089622 ] Tomoko Uchida commented on LUCENE-9321: --- Could we convert all (potentially broken) ".txt"s to

[jira] [Commented] (LUCENE-9336) RegExp.java - add support for character classes like \w

2020-04-22 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089621#comment-17089621 ] Adrien Grand commented on LUCENE-9336: -- +1 I think that many users are used to these character

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1443: LUCENE-9337: Ensure CMS updates it's thread accounting datastructures consistently

2020-04-22 Thread GitBox
s1monw commented on a change in pull request #1443: URL: https://github.com/apache/lucene-solr/pull/1443#discussion_r412930075 ## File path: lucene/core/src/test/org/apache/lucene/index/TestConcurrentMergeScheduler.java ## @@ -657,4 +659,88 @@ protected void doStall() {

[GitHub] [lucene-solr] romseygeek opened a new pull request #1444: LUCENE-9338: Clean up type safety in SimpleBindings

2020-04-22 Thread GitBox
romseygeek opened a new pull request #1444: URL: https://github.com/apache/lucene-solr/pull/1444 Replaces SimpleBindings Map with a map of Supplier to improve type safety. Also moves cycle detection directly into ExpressionValuesSource.

[jira] [Created] (LUCENE-9338) Clean up type safety in SimpleBindings

2020-04-22 Thread Alan Woodward (Jira)
Alan Woodward created LUCENE-9338: - Summary: Clean up type safety in SimpleBindings Key: LUCENE-9338 URL: https://issues.apache.org/jira/browse/LUCENE-9338 Project: Lucene - Core Issue Type:

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1443: LUCENE-9337: Ensure CMS updates it's thread accounting datastructures consistently

2020-04-22 Thread GitBox
mikemccand commented on a change in pull request #1443: URL: https://github.com/apache/lucene-solr/pull/1443#discussion_r412877253 ## File path: lucene/core/src/test/org/apache/lucene/index/TestConcurrentMergeScheduler.java ## @@ -657,4 +659,88 @@ protected void doStall() {

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1443: LUCENE-9337: Ensure CMS updates it's thread accounting datastructures consistently

2020-04-22 Thread GitBox
mikemccand commented on a change in pull request #1443: URL: https://github.com/apache/lucene-solr/pull/1443#discussion_r412876595 ## File path: lucene/core/src/test/org/apache/lucene/index/TestConcurrentMergeScheduler.java ## @@ -657,4 +659,88 @@ protected void doStall() {

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1443: LUCENE-9337: Ensure CMS updates it's thread accounting datastructures consistently

2020-04-22 Thread GitBox
mikemccand commented on a change in pull request #1443: URL: https://github.com/apache/lucene-solr/pull/1443#discussion_r412876595 ## File path: lucene/core/src/test/org/apache/lucene/index/TestConcurrentMergeScheduler.java ## @@ -657,4 +659,88 @@ protected void doStall() {

[jira] [Comment Edited] (SOLR-14418) MetricsHistoryHandler: don't query .system collection

2020-04-22 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089539#comment-17089539 ] Andrzej Bialecki edited comment on SOLR-14418 at 4/22/20, 10:40 AM:

[jira] [Commented] (SOLR-14418) MetricsHistoryHandler: don't query .system collection

2020-04-22 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089539#comment-17089539 ] Andrzej Bialecki commented on SOLR-14418: - That query is executed only when {{cloudManager ==

[jira] [Comment Edited] (SOLR-14423) static caches in StreamHandler ought to move to CoreContainer lifecycle

2020-04-22 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089534#comment-17089534 ] Andrzej Bialecki edited comment on SOLR-14423 at 4/22/20, 10:31 AM:

[jira] [Commented] (SOLR-14423) static caches in StreamHandler ought to move to CoreContainer lifecycle

2020-04-22 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089534#comment-17089534 ] Andrzej Bialecki commented on SOLR-14423: - {{SolrCloudManager.getObjectCache()}} was implemented

[jira] [Commented] (SOLR-14414) New Admin UI

2020-04-22 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089526#comment-17089526 ] Marcus Eagan commented on SOLR-14414: - [~janhoy][~dsmiley] and others, I've attached a new video

[jira] [Updated] (SOLR-14414) New Admin UI

2020-04-22 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eagan updated SOLR-14414: Attachment: QueryUX-SolrAdminUIReboot.mov > New Admin UI > > > Key:

[GitHub] [lucene-solr] romseygeek commented on issue #1440: LUCENE-9330: Make SortFields responsible for index sorting and serialization

2020-04-22 Thread GitBox
romseygeek commented on issue #1440: URL: https://github.com/apache/lucene-solr/pull/1440#issuecomment-617669855 Thanks for the review @jpountz! I addressed your feedback, including moving the serialization logic completely into SortFieldProvider. I'm not entirely happy with it as it

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1440: LUCENE-9330: Make SortFields responsible for index sorting and serialization

2020-04-22 Thread GitBox
romseygeek commented on a change in pull request #1440: URL: https://github.com/apache/lucene-solr/pull/1440#discussion_r412829154 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexSorter.java ## @@ -0,0 +1,500 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1440: LUCENE-9330: Make SortFields responsible for index sorting and serialization

2020-04-22 Thread GitBox
romseygeek commented on a change in pull request #1440: URL: https://github.com/apache/lucene-solr/pull/1440#discussion_r412786736 ## File path: lucene/core/src/java/org/apache/lucene/search/SortField.java ## @@ -392,4 +491,31 @@ public SortField rewrite(IndexSearcher

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1440: LUCENE-9330: Make SortFields responsible for index sorting and serialization

2020-04-22 Thread GitBox
romseygeek commented on a change in pull request #1440: URL: https://github.com/apache/lucene-solr/pull/1440#discussion_r412783967 ## File path: lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java ## @@ -527,45 +589,61 @@ private void indexPoint(PerField

[GitHub] [lucene-solr] dweiss commented on issue #1441: LUCENE-9332 validate source patterns using gradle

2020-04-22 Thread GitBox
dweiss commented on issue #1441: URL: https://github.com/apache/lucene-solr/pull/1441#issuecomment-617629898 bq. Do you have any idea on why I'm not able to resolve the rat dependency here or what I need for it? You removed the dependencies section... perhaps it's because of this?

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-04-22 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089365#comment-17089365 ] Uwe Schindler commented on LUCENE-9321: --- bq. In 2020 we could have some modern template engine

[jira] [Comment Edited] (LUCENE-9321) Port documentation task to gradle

2020-04-22 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089360#comment-17089360 ] Uwe Schindler edited comment on LUCENE-9321 at 4/22/20, 7:06 AM: - bq.

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-04-22 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089360#comment-17089360 ] Uwe Schindler commented on LUCENE-9321: --- bq. the stuff that confused me here were the ant magics