[jira] [Commented] (LUCENE-9640) Add TrackingQuery to track matching documents

2020-12-15 Thread Elbek Kamoliddinov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250097#comment-17250097 ] Elbek Kamoliddinov commented on LUCENE-9640: I have a naive implementation where

[jira] [Created] (LUCENE-9640) Add TrackingQuery to track matching documents

2020-12-15 Thread Elbek Kamoliddinov (Jira)
Elbek Kamoliddinov created LUCENE-9640: -- Summary: Add TrackingQuery to track matching documents Key: LUCENE-9640 URL: https://issues.apache.org/jira/browse/LUCENE-9640 Project: Lucene - Core

[jira] [Comment Edited] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

2020-12-15 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250026#comment-17250026 ] Thomas Wöckinger edited comment on SOLR-14923 at 12/16/20, 12:29 AM: -

[jira] [Commented] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

2020-12-15 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250026#comment-17250026 ] Thomas Wöckinger commented on SOLR-14923: - That's good news, i can support you, if you want, just

[jira] [Updated] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

2020-12-15 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Wöckinger updated SOLR-14923: Affects Version/s: 8.7 > Indexing performance is unacceptable when child documents are

[GitHub] [lucene-solr] madrob commented on pull request #2118: SOLR-15031: Prevent null being wrapped in a QueryValueSource

2020-12-15 Thread GitBox
madrob commented on pull request #2118: URL: https://github.com/apache/lucene-solr/pull/2118#issuecomment-745607522 Thanks for adding the test! it passes for me when run alone, but not as part of the full class, can you verify in your environment as well? `./gradlew :solr:core:test

[GitHub] [lucene-solr] madrob commented on pull request #2118: SOLR-15031: Prevent null being wrapped in a QueryValueSource

2020-12-15 Thread GitBox
madrob commented on pull request #2118: URL: https://github.com/apache/lucene-solr/pull/2118#issuecomment-745608863 Also, would you mind adding an entry to `solr/CHANGES.txt` with how you would like proper credit/attribution? I'll make sure that it gets to the right section, so don't

[GitHub] [lucene-solr] madrob commented on pull request #2121: SOLR-10860: Return proper error code for bad input incase of inplace updates

2020-12-15 Thread GitBox
madrob commented on pull request #2121: URL: https://github.com/apache/lucene-solr/pull/2121#issuecomment-745598327 @munendrasn all of your comments make sense, thanks. let's update the error message as you describe and then this looks good.

[jira] [Commented] (LUCENE-9444) Need an API to easily fetch facet labels for a field in a document

2020-12-15 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249980#comment-17249980 ] Ankur commented on LUCENE-9444: --- [~mikemccand], Sorry for the late response. Yes we can resolve this one

[jira] [Resolved] (LUCENE-9444) Need an API to easily fetch facet labels for a field in a document

2020-12-15 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankur resolved LUCENE-9444. --- Resolution: Fixed > Need an API to easily fetch facet labels for a field in a document >

[jira] [Commented] (SOLR-15029) More gracefully allow Shard Leader to give up leadership

2020-12-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249976#comment-17249976 ] ASF subversion and git services commented on SOLR-15029: Commit

[jira] [Commented] (SOLR-13027) Harden LeaderTragicEventTest.

2020-12-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249977#comment-17249977 ] ASF subversion and git services commented on SOLR-13027: Commit

[jira] [Commented] (SOLR-15029) More gracefully allow Shard Leader to give up leadership

2020-12-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249978#comment-17249978 ] ASF subversion and git services commented on SOLR-15029: Commit

[jira] [Commented] (SOLR-13027) Harden LeaderTragicEventTest.

2020-12-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249979#comment-17249979 ] ASF subversion and git services commented on SOLR-13027: Commit

[jira] [Resolved] (SOLR-15029) More gracefully allow Shard Leader to give up leadership

2020-12-15 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-15029. -- Resolution: Fixed > More gracefully allow Shard Leader to give up leadership >

[GitHub] [lucene-solr] madrob closed pull request #2120: SOLR-15029 More gracefully give up shard leadership

2020-12-15 Thread GitBox
madrob closed pull request #2120: URL: https://github.com/apache/lucene-solr/pull/2120 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-13102) Shared storage Directory implementation

2020-12-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249965#comment-17249965 ] David Smiley commented on SOLR-13102: - I forgot about this proposal.  Still; [~ysee...@gmail.com] 

[jira] [Commented] (SOLR-15051) Shared storage -- BlobDirectory (de-duping)

2020-12-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249961#comment-17249961 ] David Smiley commented on SOLR-15051: - BTW I started with a SIP but then I doubted this because

[jira] [Updated] (SOLR-15051) Shared storage -- BlobDirectory (de-duping)

2020-12-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-15051: Description: This proposal is a way to accomplish shared storage in SolrCloud with a few key

[jira] [Created] (SOLR-15051) Shared storage -- BlobDirectory (de-duping)

2020-12-15 Thread David Smiley (Jira)
David Smiley created SOLR-15051: --- Summary: Shared storage -- BlobDirectory (de-duping) Key: SOLR-15051 URL: https://issues.apache.org/jira/browse/SOLR-15051 Project: Solr Issue Type:

[jira] [Commented] (SOLR-15026) MiniSolrCloudCluster can inconsistently get confused about when it's using SSL

2020-12-15 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249891#comment-17249891 ] Mike Drob commented on SOLR-15026: -- The relevant bit of why the change is these system properties -

[jira] [Comment Edited] (SOLR-14886) Suppress stack trace in Query response.

2020-12-15 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249854#comment-17249854 ] Isabelle Giguere edited comment on SOLR-14886 at 12/15/20, 6:45 PM:

[jira] [Comment Edited] (SOLR-14886) Suppress stack trace in Query response.

2020-12-15 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249854#comment-17249854 ] Isabelle Giguere edited comment on SOLR-14886 at 12/15/20, 6:44 PM:

[jira] [Commented] (SOLR-14886) Suppress stack trace in Query response.

2020-12-15 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249854#comment-17249854 ] Isabelle Giguere commented on SOLR-14886: - [~gerlowskija] The full stack trace in the error

[jira] [Comment Edited] (SOLR-14034) remove deprecated min_rf references

2020-12-15 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249836#comment-17249836 ] Christine Poerschke edited comment on SOLR-14034 at 12/15/20, 6:19 PM:

[GitHub] [lucene-solr] cpoerschke closed pull request #1705: factor out static LTRQParserPlugin.newLTRScoringQuery(...) method

2020-12-15 Thread GitBox
cpoerschke closed pull request #1705: URL: https://github.com/apache/lucene-solr/pull/1705 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (SOLR-14034) remove deprecated min_rf references

2020-12-15 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249836#comment-17249836 ] Christine Poerschke commented on SOLR-14034: Hello everyone. I'm not very familiar with the

[GitHub] [lucene-solr] jbampton commented on a change in pull request #2120: SOLR-15029 More gracefully give up shard leadership

2020-12-15 Thread GitBox
jbampton commented on a change in pull request #2120: URL: https://github.com/apache/lucene-solr/pull/2120#discussion_r543515585 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/ShardTerms.java ## @@ -102,16 +101,16 @@ public ShardTerms

[GitHub] [lucene-solr] jbampton commented on a change in pull request #2121: SOLR-10860: Return proper error code for bad input incase of inplace updates

2020-12-15 Thread GitBox
jbampton commented on a change in pull request #2121: URL: https://github.com/apache/lucene-solr/pull/2121#discussion_r543503718 ## File path: solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java ## @@ -143,6 +147,15 @@ public SolrInputDocument

[GitHub] [lucene-solr] jbampton commented on a change in pull request #2122: SOLR-14950: Fix copyfield regeneration with explicit src/dest matching dyn rule

2020-12-15 Thread GitBox
jbampton commented on a change in pull request #2122: URL: https://github.com/apache/lucene-solr/pull/2122#discussion_r543500974 ## File path: solr/core/src/test/org/apache/solr/rest/schema/TestBulkSchemaAPI.java ## @@ -773,6 +773,108 @@ public void testCopyFieldRules() throws

[jira] [Comment Edited] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2020-12-15 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249692#comment-17249692 ] Joel Bernstein edited comment on SOLR-15036 at 12/15/20, 4:32 PM: -- The

[jira] [Deleted] (SOLR-15050) Проводка Москвич 2140

2020-12-15 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev deleted SOLR-15050: > Проводка Москвич 2140 > - > > Key: SOLR-15050 >

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2020-12-15 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249765#comment-17249765 ] Timothy Potter commented on SOLR-15036: --- Confirmed, it works nicely now! Thanks for your help Joel

[jira] [Updated] (SOLR-15050) Проводка Москвич 2140

2020-12-15 Thread Vladimir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir updated SOLR-15050: Description: !2365641414_w640_h640_2365641414.jpg|width=179,height=179! Проводка на Москвич 2140 1.  Жгут

[GitHub] [lucene-solr] mikemccand commented on pull request #2080: LUCENE-8947: Skip field length accumulation when norms are disabled

2020-12-15 Thread GitBox
mikemccand commented on pull request #2080: URL: https://github.com/apache/lucene-solr/pull/2080#issuecomment-745375768 > > > Hmm, but I think sumTotalTermFreq, which is per field sum of all totalTermFreq across all terms in that field, could overflow long even today, in and adversarial

[jira] [Created] (SOLR-15050) Проводка Москвич 2140

2020-12-15 Thread Vladimir (Jira)
Vladimir created SOLR-15050: --- Summary: Проводка Москвич 2140 Key: SOLR-15050 URL: https://issues.apache.org/jira/browse/SOLR-15050 Project: Solr Issue Type: Task Security Level: Public

[GitHub] [lucene-solr] jbampton commented on a change in pull request #2132: SOLR-15036: auto- select / rollup / sort / plist over facet expression when using a collection alias with multiple collecti

2020-12-15 Thread GitBox
jbampton commented on a change in pull request #2132: URL: https://github.com/apache/lucene-solr/pull/2132#discussion_r543443487 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/FacetStream.java ## @@ -351,25 +361,26 @@ public String getCollection() {

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2020-12-15 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249747#comment-17249747 ] Timothy Potter commented on SOLR-15036: --- Oh darn, I should have spotted that! Sorry for the noise

[GitHub] [lucene-solr] jbampton commented on a change in pull request #2134: SOLR-15038: Add elevateDocsWithoutMatchingQ and onlyElevatedReprese…

2020-12-15 Thread GitBox
jbampton commented on a change in pull request #2134: URL: https://github.com/apache/lucene-solr/pull/2134#discussion_r543432124 ## File path: solr/core/src/java/org/apache/solr/search/CollapsingQParserPlugin.java ## @@ -689,15 +693,18 @@ public void finish() throws

[jira] [Commented] (LUCENE-9021) QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance

2020-12-15 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249741#comment-17249741 ] Mikhail Khludnev commented on LUCENE-9021: -- Thanks, [~pbruski_]. It seems we've done here. 

[GitHub] [lucene-solr] jbampton commented on a change in pull request #2135: SOLR-15038: Add elevateDocsWithoutMatchingQ and onlyElevatedReprese…

2020-12-15 Thread GitBox
jbampton commented on a change in pull request #2135: URL: https://github.com/apache/lucene-solr/pull/2135#discussion_r543423038 ## File path: solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java ## @@ -504,25 +506,27 @@ private void

[jira] [Updated] (LUCENE-9021) QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance

2020-12-15 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated LUCENE-9021: - Fix Version/s: 8.8 Assignee: Mikhail Khludnev Resolution: Fixed

[GitHub] [lucene-solr] jbampton commented on a change in pull request #2137: SOLR-14251 Add option skipFreeSpaceCheck to skip checking for availble disk space before splitting shards. Useful with shar

2020-12-15 Thread GitBox
jbampton commented on a change in pull request #2137: URL: https://github.com/apache/lucene-solr/pull/2137#discussion_r543419505 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java ## @@ -129,10 +130,16 @@ public boolean

[jira] [Comment Edited] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2020-12-15 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249692#comment-17249692 ] Joel Bernstein edited comment on SOLR-15036 at 12/15/20, 1:48 PM: -- The

[jira] [Comment Edited] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2020-12-15 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249692#comment-17249692 ] Joel Bernstein edited comment on SOLR-15036 at 12/15/20, 1:46 PM: -- The

[jira] [Comment Edited] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2020-12-15 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249692#comment-17249692 ] Joel Bernstein edited comment on SOLR-15036 at 12/15/20, 1:33 PM: -- The

[jira] [Comment Edited] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2020-12-15 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249692#comment-17249692 ] Joel Bernstein edited comment on SOLR-15036 at 12/15/20, 1:31 PM: -- The

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2020-12-15 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249692#comment-17249692 ] Joel Bernstein commented on SOLR-15036: --- The fl for drill needs to include the *a_d* field.

[jira] [Comment Edited] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2020-12-15 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249692#comment-17249692 ] Joel Bernstein edited comment on SOLR-15036 at 12/15/20, 1:30 PM: -- The

[jira] [Commented] (LUCENE-9638) TestVectorValues.testIndexMultipleVectorFields reproducing test failure

2020-12-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249686#comment-17249686 ] ASF subversion and git services commented on LUCENE-9638: - Commit

[jira] [Resolved] (LUCENE-9638) TestVectorValues.testIndexMultipleVectorFields reproducing test failure

2020-12-15 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Sokolov resolved LUCENE-9638. - Resolution: Fixed > TestVectorValues.testIndexMultipleVectorFields reproducing test

[jira] [Created] (LUCENE-9639) Add unit tests for SImpleTextVector format

2020-12-15 Thread Michael Sokolov (Jira)
Michael Sokolov created LUCENE-9639: --- Summary: Add unit tests for SImpleTextVector format Key: LUCENE-9639 URL: https://issues.apache.org/jira/browse/LUCENE-9639 Project: Lucene - Core

[jira] [Commented] (LUCENE-9638) TestVectorValues.testIndexMultipleVectorFields reproducing test failure

2020-12-15 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249684#comment-17249684 ] Michael Sokolov commented on LUCENE-9638: - Hmm well we do not have any unit tests for

[jira] [Commented] (LUCENE-9638) TestVectorValues.testIndexMultipleVectorFields reproducing test failure

2020-12-15 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249683#comment-17249683 ] Michael Sokolov commented on LUCENE-9638: - Thanks, yes it's writing an end marker after each

[jira] [Resolved] (SOLR-14728) Add self join optimization to the TopLevelJoinQuery

2020-12-15 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-14728. Resolution: Duplicate > Add self join optimization to the TopLevelJoinQuery >

[jira] [Commented] (SOLR-14728) Add self join optimization to the TopLevelJoinQuery

2020-12-15 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249668#comment-17249668 ] Jason Gerlowski commented on SOLR-14728: Hey [~jbernste] I'm going to close this out as a

[jira] [Created] (LUCENE-9638) TestVectorValues.testIndexMultipleVectorFields reproducing test failure

2020-12-15 Thread Michael McCandless (Jira)
Michael McCandless created LUCENE-9638: -- Summary: TestVectorValues.testIndexMultipleVectorFields reproducing test failure Key: LUCENE-9638 URL: https://issues.apache.org/jira/browse/LUCENE-9638

[GitHub] [lucene-solr] jbampton commented on a change in pull request #2136: SOLR-15037: fix prevent config change listener to reload core while s…

2020-12-15 Thread GitBox
jbampton commented on a change in pull request #2136: URL: https://github.com/apache/lucene-solr/pull/2136#discussion_r543243184 ## File path: solr/core/src/java/org/apache/solr/schema/SchemaManager.java ## @@ -103,8 +104,9 @@ private List doOperations(List operations) throws

[GitHub] [lucene-solr] jbampton commented on a change in pull request #2141: LUCENE-9346: Support minimumNumberShouldMatch in WANDScorer

2020-12-15 Thread GitBox
jbampton commented on a change in pull request #2141: URL: https://github.com/apache/lucene-solr/pull/2141#discussion_r543238073 ## File path: lucene/core/src/java/org/apache/lucene/search/Boolean2ScorerSupplier.java ## @@ -195,10 +201,13 @@ private Scorer opt(Collection

[GitHub] [lucene-solr] jbampton commented on a change in pull request #2142: SOLR-14923: Reload RealtimeSearcher on next getInputDocument if forced

2020-12-15 Thread GitBox
jbampton commented on a change in pull request #2142: URL: https://github.com/apache/lucene-solr/pull/2142#discussion_r543234918 ## File path: solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java ## @@ -618,6 +626,16 @@ public static

[GitHub] [lucene-solr] jbampton commented on a change in pull request #2146: SOLR-15049: Add TopLevelJoinQuery optimization for 'self-joins'

2020-12-15 Thread GitBox
jbampton commented on a change in pull request #2146: URL: https://github.com/apache/lucene-solr/pull/2146#discussion_r543233296 ## File path: solr/core/src/java/org/apache/solr/search/TopLevelJoinQuery.java ## @@ -218,4 +218,28 @@ public BitsetBounds(long lower, long upper) {

[GitHub] [lucene-solr] jbampton commented on a change in pull request #2147: LUCENE-9637: Clean up ShapeField/ShapeQuery random test

2020-12-15 Thread GitBox
jbampton commented on a change in pull request #2147: URL: https://github.com/apache/lucene-solr/pull/2147#discussion_r543223927 ## File path: lucene/core/src/test/org/apache/lucene/document/BaseXYShapeTestCase.java ## @@ -126,24 +132,12 @@ protected boolean

[GitHub] [lucene-solr] iverase opened a new pull request #2147: LUCENE-9637: Clean up ShapeField/ShapeQuery random test

2020-12-15 Thread GitBox
iverase opened a new pull request #2147: URL: https://github.com/apache/lucene-solr/pull/2147 Removes some unused code and replaces the Point implementation on the test with the Point implementation in the geo package. cc: @nknize

[jira] [Created] (LUCENE-9637) Clean up ShapeField /ShapeQuery random test

2020-12-15 Thread Ignacio Vera (Jira)
Ignacio Vera created LUCENE-9637: Summary: Clean up ShapeField /ShapeQuery random test Key: LUCENE-9637 URL: https://issues.apache.org/jira/browse/LUCENE-9637 Project: Lucene - Core Issue

[GitHub] [lucene-solr] sigram commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

2020-12-15 Thread GitBox
sigram commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r543196623 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/CollectionMetricsBuilder.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] sigram commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

2020-12-15 Thread GitBox
sigram commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r543196623 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/CollectionMetricsBuilder.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] sigram commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

2020-12-15 Thread GitBox
sigram commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r543195639 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/CollectionMetricsBuilder.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] sigram commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

2020-12-15 Thread GitBox
sigram commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r543193912 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/ShardMetrics.java ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software

[jira] [Resolved] (LUCENE-9627) Small refactor of codec classes

2020-12-15 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-9627. -- Fix Version/s: master (9.0) Assignee: Ignacio Vera Resolution: Fixed > Small

[jira] [Commented] (LUCENE-9627) Small refactor of codec classes

2020-12-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249578#comment-17249578 ] ASF subversion and git services commented on LUCENE-9627: - Commit

[GitHub] [lucene-solr] iverase merged pull request #2109: LUCENE-9627: Small refactor of codec classes

2020-12-15 Thread GitBox
iverase merged pull request #2109: URL: https://github.com/apache/lucene-solr/pull/2109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] gf2121 commented on pull request #2113: LUCENE-9629: Use computed masks

2020-12-15 Thread GitBox
gf2121 commented on pull request #2113: URL: https://github.com/apache/lucene-solr/pull/2113#issuecomment-745134305 > @dweiss Thank you very much for the guiding of how to do a benchmark on Lucene, the lueneutil tool is really nice! > I repeatedly execute the wikimedium1m 20 times, the