[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9570: Description: Review and correct all the javadocs before they're messed up by automatic

[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9570: Description: Review and correct all the javadocs before they're messed up by automatic

[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9570: Description: Review and correct all the javadocs before they're messed up by automatic

[jira] [Created] (LUCENE-9654) Expressions module gramar antlr code regeneration missing

2021-01-02 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9654: --- Summary: Expressions module gramar antlr code regeneration missing Key: LUCENE-9654 URL: https://issues.apache.org/jira/browse/LUCENE-9654 Project: Lucene - Core

[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9570: Description: Review and correct all the javadocs before they're messed up by automatic

[GitHub] [lucene-solr] zacharymorn commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2021-01-02 Thread GitBox
zacharymorn commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-753560734 Hi @dweiss, for the JDK compiler issue, I ended up submitting a bug report to open jdk (internal review id 9068426) as I'm hoping to be able to refer to this issue in

[GitHub] [lucene-solr] zacharymorn commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2021-01-02 Thread GitBox
zacharymorn commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-753557228 Hi Uwe, I've gone ahead and pushed a commit for the following: 1. Add checksum computation 2. Add a new test to exercise the DirectIODirectory with actual index

[GitHub] [lucene-solr] zacharymorn removed a comment on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2021-01-02 Thread GitBox
zacharymorn removed a comment on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-753556939 Hi Uwe, I've gone ahead and pushed a commit for the following: 1. Add checksum This is an

[GitHub] [lucene-solr] zacharymorn commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2021-01-02 Thread GitBox
zacharymorn commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-753556939 Hi Uwe, I've gone ahead and pushed a commit for the following: 1. Add checksum This is an automated

[GitHub] [lucene-solr] uschindler commented on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-02 Thread GitBox
uschindler commented on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-753547873 I fixed the rmeinaing TODOs regarding a safe close of *all* segments, when exceptions on `map()` occur. When closing the master IndexInput, we also make sure to unmap

[GitHub] [lucene-solr] uschindler edited a comment on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-02 Thread GitBox
uschindler edited a comment on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-753511728 @dweiss I found a workaround by adding the include/excludes as we use in Ant build. Why were those removed? Should I maybe reopen a new issue to add them back in

[GitHub] [lucene-solr] uschindler edited a comment on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-02 Thread GitBox
uschindler edited a comment on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-753512086 FYI, after I was able to run tests in a more convenient way, I figured out that some tests fail from time to time because of using `HandleTrackingFS`. I disabled

[GitHub] [lucene-solr] uschindler commented on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-02 Thread GitBox
uschindler commented on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-753512086 FYI, after I was able to run tests in a more convenient way, I figured out that some tests fail from time to time because of using `HandleTrackingFS`. I disabled all

[GitHub] [lucene-solr] uschindler edited a comment on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-02 Thread GitBox
uschindler edited a comment on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-753511728 @dweiss I found a workaround by adding the include/excludes as we use in Ant build. Why were those removed? Should I maybe reopen a new issue. I have the

[GitHub] [lucene-solr] uschindler commented on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-02 Thread GitBox
uschindler commented on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-753511728 @dweiss I found a workaround by adding the include/excludes as we use in Ant build. Why were those removed? Should I maybe reopen a new issue. I have the feeling

[GitHub] [lucene-solr] uschindler edited a comment on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-02 Thread GitBox
uschindler edited a comment on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-753503210 @dweiss I need your help here. There is one thing that drives me crazy: with the changes (actually adding `--add-modules jdk.incubator.foreign` to the test

[GitHub] [lucene-solr] uschindler edited a comment on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-02 Thread GitBox
uschindler edited a comment on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-753503210 @dweiss I need your help here. There is one thing that drives me crazy: with the changes (actually adding `--add-modules jdk.incubator.foreign` to the test

[GitHub] [lucene-solr] uschindler commented on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-02 Thread GitBox
uschindler commented on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-753503210 @dweiss I need your help here. There is one thing that drives me crazy: with the changes (actually adding `--add-modules", "jdk.incubator.foreign` to the test command

[GitHub] [lucene-solr] uschindler edited a comment on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-02 Thread GitBox
uschindler edited a comment on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-753492065 > Very exciting! Thank you for leading the way here, Uwe. > >> The most horrible thing I have seen is that our CFS file format starts the "inner" files

[GitHub] [lucene-solr] uschindler commented on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-02 Thread GitBox
uschindler commented on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-753492065 > Very exciting! Thank you for leading the way here, Uwe. > >> The most horrible thing I have seen is that our CFS file format starts the "inner" files totally

[GitHub] [lucene-solr] msokolov commented on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-02 Thread GitBox
msokolov commented on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-753491649 Very exciting! Thank you for leading the way here, Uwe. > The most horrible thing I have seen is that our CFS file format starts the "inner" files totally unaligned.

[jira] [Updated] (LUCENE-9653) Investigate usage of incubating jdk.incubator.foreign for MMapDirectory

2021-01-02 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-9653: -- Summary: Investigate usage of incubating jdk.incubator.foreign for MMapDirectory (was:

[jira] [Created] (LUCENE-9653) Imvestigate using of incubating jdk.incubator.foreign for MMapDirectory

2021-01-02 Thread Uwe Schindler (Jira)
Uwe Schindler created LUCENE-9653: - Summary: Imvestigate using of incubating jdk.incubator.foreign for MMapDirectory Key: LUCENE-9653 URL: https://issues.apache.org/jira/browse/LUCENE-9653 Project:

[jira] [Commented] (LUCENE-9563) Add .editorConfig

2021-01-02 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257418#comment-17257418 ] Michael Sokolov commented on LUCENE-9563: - > I don't know about emacs but a quick Google search

[GitHub] [lucene-solr] jpountz commented on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-02 Thread GitBox
jpountz commented on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-753490290 > In future we should throw away on coping/loading our stuff to heap and maybe throw away IndexInput completely and base our code fully on random access. The new

[GitHub] [lucene-solr] uschindler opened a new pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-02 Thread GitBox
uschindler opened a new pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176 This is just a draft PR for a first insight on memory maaping improvements in JDK 16+. Some background information: Starting with JDK-14, there is a new incubating module

[jira] [Created] (SOLR-15065) Migration guides for using packages instead of contribs

2021-01-02 Thread Ishan Chattopadhyaya (Jira)
Ishan Chattopadhyaya created SOLR-15065: --- Summary: Migration guides for using packages instead of contribs Key: SOLR-15065 URL: https://issues.apache.org/jira/browse/SOLR-15065 Project: Solr

[jira] [Commented] (SOLR-15065) Migration guides for using packages instead of contribs

2021-01-02 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257377#comment-17257377 ] Ishan Chattopadhyaya commented on SOLR-15065: - Ping [~rohitbemax], FYI. > Migration guides