[GitHub] [lucene] zacharymorn closed pull request #81: LUCENE-9335: [WIP] Speed up pure disjunction with BMM

2021-04-15 Thread GitBox
zacharymorn closed pull request #81: URL: https://github.com/apache/lucene/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [lucene] zacharymorn commented on pull request #81: LUCENE-9335: [WIP] Speed up pure disjunction with BMM

2021-04-15 Thread GitBox
zacharymorn commented on pull request #81: URL: https://github.com/apache/lucene/pull/81#issuecomment-820881711 Sounds good. Will start with a new `Scorer` implementation first and later come back to `BulkScorer` for further exploration. For now, I'll close this PR. -- This is an

[jira] [Commented] (LUCENE-9334) Require consistency between data-structures on a per-field basis

2021-04-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17322491#comment-17322491 ] ASF subversion and git services commented on LUCENE-9334: - Commit

[GitHub] [lucene] mayya-sharipova merged pull request #87: Fix test that modifies schema

2021-04-15 Thread GitBox
mayya-sharipova merged pull request #87: URL: https://github.com/apache/lucene/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [lucene] mayya-sharipova opened a new pull request #87: Fix test that modifies schema

2021-04-15 Thread GitBox
mayya-sharipova opened a new pull request #87: URL: https://github.com/apache/lucene/pull/87 LUCENE-9334 requires that docs have the same schema across the whole schema. This fixes the test TestDemoParallelLeafReader.testRandomMultipleSchemaGensSameField that attempts to modify

[GitHub] [lucene] jpountz commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-04-15 Thread GitBox
jpountz commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r614222974 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDDefaultReader.java ## @@ -0,0 +1,899 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene] jpountz commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-04-15 Thread GitBox
jpountz commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r614220780 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDDefaultReader.java ## @@ -0,0 +1,899 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene-solr] gus-asf commented on pull request #2411: SOLR-13696 Simplify routed alias tests to avoid flakiness, improve debugging

2021-04-15 Thread GitBox
gus-asf commented on pull request #2411: URL: https://github.com/apache/lucene-solr/pull/2411#issuecomment-820540948 Yeah sorry haven't got back to this. Work is quite busy. my recollection is that my initial thought was that the concern raised is not actually a problem since no tests run

[GitHub] [lucene] mayya-sharipova merged pull request #86: Temporarily mute TestLucene50TermVectorsFormat:testMerge

2021-04-15 Thread GitBox
mayya-sharipova merged pull request #86: URL: https://github.com/apache/lucene/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [lucene-solr] madrob commented on pull request #2411: SOLR-13696 Simplify routed alias tests to avoid flakiness, improve debugging

2021-04-15 Thread GitBox
madrob commented on pull request #2411: URL: https://github.com/apache/lucene-solr/pull/2411#issuecomment-820528027 > it didn't seem reasonable to be trying to set up authentication just for a test. I think this would be the correct approach. Are there other tests you can borrow

[jira] [Commented] (LUCENE-9334) Require consistency between data-structures on a per-field basis

2021-04-15 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17322274#comment-17322274 ] Mayya Sharipova commented on LUCENE-9334: - [~julietibs]Thanks for the report on this test

[GitHub] [lucene] mayya-sharipova opened a new pull request #86: Temporarily mute TestLucene50TermVectorsFormat:testMerge

2021-04-15 Thread GitBox
mayya-sharipova opened a new pull request #86: URL: https://github.com/apache/lucene/pull/86 Relates to #11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [lucene] iverase opened a new pull request #85: LUCENE-9907: Make MonotonicBlockPackedReader/writer depend on DirectReader/writer

2021-04-15 Thread GitBox
iverase opened a new pull request #85: URL: https://github.com/apache/lucene/pull/85 `MonotonicBlockPackedReader` and `MonotonicBlockPackedWriter` are used in the `FixedGapTermsIndexReader` and `FixedGapTermsIndexWriter` respectively. Those readers/ writers from internally from

[GitHub] [lucene] iverase merged pull request #72: LUCENE-9907: Remove packedInts#getReaderNoHeader dependency on TermsVectorFieldsFormat

2021-04-15 Thread GitBox
iverase merged pull request #72: URL: https://github.com/apache/lucene/pull/72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [lucene] jpountz commented on a change in pull request #72: LUCENE-9907: Remove packedInts#getReaderNoHeader dependency on TermsVectorFieldsFormat

2021-04-15 Thread GitBox
jpountz commented on a change in pull request #72: URL: https://github.com/apache/lucene/pull/72#discussion_r614092381 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingTermVectorsReader.java ## @@ -295,6 +300,38 @@ public

[GitHub] [lucene] iverase commented on a change in pull request #72: LUCENE-9907: Remove packedInts#getReaderNoHeader dependency on TermsVectorFieldsFormat

2021-04-15 Thread GitBox
iverase commented on a change in pull request #72: URL: https://github.com/apache/lucene/pull/72#discussion_r614079868 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingTermVectorsReader.java ## @@ -295,6 +300,38 @@ public

[GitHub] [lucene] iverase commented on a change in pull request #72: LUCENE-9907: Remove packedInts#getReaderNoHeader dependency on TermsVectorFieldsFormat

2021-04-15 Thread GitBox
iverase commented on a change in pull request #72: URL: https://github.com/apache/lucene/pull/72#discussion_r614076033 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingTermVectorsWriter.java ## @@ -223,6 +224,7 @@ void

[GitHub] [lucene] jpountz commented on a change in pull request #72: LUCENE-9907: Remove packedInts#getReaderNoHeader dependency on TermsVectorFieldsFormat

2021-04-15 Thread GitBox
jpountz commented on a change in pull request #72: URL: https://github.com/apache/lucene/pull/72#discussion_r614052826 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingTermVectorsReader.java ## @@ -295,6 +300,38 @@ public

[GitHub] [lucene] iverase commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-04-15 Thread GitBox
iverase commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r614031179 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDDefaultReader.java ## @@ -0,0 +1,899 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene] iverase commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-04-15 Thread GitBox
iverase commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r614033996 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDDefaultReader.java ## @@ -0,0 +1,899 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene] iverase commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-04-15 Thread GitBox
iverase commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r614031261 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextBKDReader.java ## @@ -22,34 +22,31 @@ import java.io.IOException; import

[GitHub] [lucene] iverase commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-04-15 Thread GitBox
iverase commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r614031179 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDDefaultReader.java ## @@ -0,0 +1,899 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene] iverase commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-04-15 Thread GitBox
iverase commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r614030442 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDDefaultReader.java ## @@ -0,0 +1,899 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene] iverase commented on pull request #72: LUCENE-9907: Remove packedInts#getReaderNoHeader dependency on TermsVectorFieldsFormat

2021-04-15 Thread GitBox
iverase commented on pull request #72: URL: https://github.com/apache/lucene/pull/72#issuecomment-820374588 I have added the length needed to store the int array so we can retrieve it before reading it. In the read side, I found that wrapping the IndexInput is tricky as you might

[GitHub] [lucene] rmuir commented on pull request #82: LUCENE-9928: speed up analysis/icu regeneration

2021-04-15 Thread GitBox
rmuir commented on pull request #82: URL: https://github.com/apache/lucene/pull/82#issuecomment-820357230 I'm forcing --rerun-tasks when i do this. For the icu regeneration the primary input is the jar file version as I mentioned before. -- This is an automated message from the Apache

[GitHub] [lucene] janhoy commented on a change in pull request #84: LUCENE-9929 Make ScandinavianNormalizationFilter configurable wrt fol…

2021-04-15 Thread GitBox
janhoy commented on a change in pull request #84: URL: https://github.com/apache/lucene/pull/84#discussion_r613994057 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ScandinavianNormalizationFilter.java ## @@ -33,14 +34,45 @@ *

[GitHub] [lucene] dweiss commented on pull request #82: LUCENE-9928: speed up analysis/icu regeneration

2021-04-15 Thread GitBox
dweiss commented on pull request #82: URL: https://github.com/apache/lucene/pull/82#issuecomment-820315980 Sure, no problem. If you reuse it often then you could also try to make it fully incremental by adding inputs and outputs to that task, then it'd be skipped if there's no need to

[GitHub] [lucene] jpountz commented on a change in pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

2021-04-15 Thread GitBox
jpountz commented on a change in pull request #7: URL: https://github.com/apache/lucene/pull/7#discussion_r613927061 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDDefaultReader.java ## @@ -0,0 +1,899 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene] rmuir commented on pull request #82: LUCENE-9928: speed up analysis/icu regeneration

2021-04-15 Thread GitBox
rmuir commented on pull request #82: URL: https://github.com/apache/lucene/pull/82#issuecomment-820296271 @dweiss I'm using `regenerate -x bigDFA` quite often, and this icuCompileLinux task is my bottleneck. I've been running this quite often recently! This patch drops it from 160s ->

[jira] [Commented] (LUCENE-8739) ZSTD Compressor support in Lucene

2021-04-15 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17322015#comment-17322015 ] Adrien Grand commented on LUCENE-8739: -- I forgot to update this issue but I actually played with

[jira] [Created] (LUCENE-9930) UkrainianMorfologikAnalyzer reloads its Dictionary for every new TokenStreamComponents instance

2021-04-15 Thread Alan Woodward (Jira)
Alan Woodward created LUCENE-9930: - Summary: UkrainianMorfologikAnalyzer reloads its Dictionary for every new TokenStreamComponents instance Key: LUCENE-9930 URL: https://issues.apache.org/jira/browse/LUCENE-9930

[jira] [Resolved] (LUCENE-9919) ZSTD Compressor/Decompressor support in Lucene

2021-04-15 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-9919. -- Resolution: Duplicate > ZSTD Compressor/Decompressor support in Lucene >

[jira] [Commented] (LUCENE-9929) Make ScandinavianNormalizationFilter configurable wrt foldings

2021-04-15 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17322005#comment-17322005 ] Adrien Grand commented on LUCENE-9929: -- +1 to avoid introducing options. I'd rather like to keep a

[jira] [Commented] (LUCENE-9843) Remove compression option on doc values

2021-04-15 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17321994#comment-17321994 ] Adrien Grand commented on LUCENE-9843: -- I would have preferred to remove the compression option by

[GitHub] [lucene-solr] atris closed pull request #2403: SOLR-15164: Implement Task Management Interface

2021-04-15 Thread GitBox
atris closed pull request #2403: URL: https://github.com/apache/lucene-solr/pull/2403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [lucene] jpountz commented on pull request #81: LUCENE-9335: [WIP] Speed up pure disjunction with BMM

2021-04-15 Thread GitBox
jpountz commented on pull request #81: URL: https://github.com/apache/lucene/pull/81#issuecomment-820199532 > I guess the next step for me would be to try to implement a new Scorer (instead of BulkScorer) using BMM, or update the existing DisjunctionSumScorer to incorporate BMM, and see

[GitHub] [lucene] dweiss commented on pull request #82: LUCENE-9928: speed up analysis/icu regeneration

2021-04-15 Thread GitBox
dweiss commented on pull request #82: URL: https://github.com/apache/lucene/pull/82#issuecomment-820174362 Nice! Still - these should only run *very* infrequently, right? On 8x we regenerated every few... months? :) I'm sorry for delays on other issues, full queue of priorities. --