sqshq edited a comment on pull request #149:
URL: https://github.com/apache/lucene/pull/149#issuecomment-849309776
@gsmiller I've got your point, and certainly don't mind making the Taxonomy
part consistent for this edge case as well.
Please take a look:
sqshq commented on pull request #149:
URL: https://github.com/apache/lucene/pull/149#issuecomment-849309776
@gsmiller I got your point, and certainly don't mind making the Taxonomy
part consistent for this edge case as well.
Please take a look:
zacharymorn commented on pull request #128:
URL: https://github.com/apache/lucene/pull/128#issuecomment-849250243
Here's the latest console output I got from running against a local small
index
```
> Task :lucene:core:CheckIndex.main()
-threadCount currently only supports up
[
https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352206#comment-17352206
]
Tomoko Uchida commented on LUCENE-9448:
---
A question - how Luke will be distributed as of lucene
gsmiller commented on pull request #149:
URL: https://github.com/apache/lucene/pull/149#issuecomment-849160773
Thanks for diving into this @sqshq! Yeah, I think I agree with all this. I
suppose the subtle difference here is that in taxonomy-based facet counting,
`FacetsConfig` would never
[
https://issues.apache.org/jira/browse/LUCENE-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved LUCENE-9204.
---
Fix Version/s: main (9.0)
Resolution: Fixed
> Move span queries to the queries
[
https://issues.apache.org/jira/browse/LUCENE-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved LUCENE-9545.
---
Fix Version/s: main (9.0)
Resolution: Fixed
> Remove Analyzer.get/setVersion()
>
[
https://issues.apache.org/jira/browse/LUCENE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352068#comment-17352068
]
Gautam Worah commented on LUCENE-9949:
--
It does not. I retried it with `./gradlew check
[
https://issues.apache.org/jira/browse/LUCENE-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352054#comment-17352054
]
David Smiley commented on LUCENE-8143:
--
I agree. If inner boosting is broken, SpanBoostQuery is
[
https://issues.apache.org/jira/browse/LUCENE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352045#comment-17352045
]
Michael McCandless commented on LUCENE-9949:
Hmm does the failure reproduce [~gworah]?
>
sqshq commented on pull request #149:
URL: https://github.com/apache/lucene/pull/149#issuecomment-848952461
Hi Greg,
You are right, [`TaxonomyFacets` fail with
[
https://issues.apache.org/jira/browse/LUCENE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gautam Worah updated LUCENE-9949:
-
Issue Type: Bug (was: Improvement)
> Flaky test in TestCachePurging.testBackgroundPurges
>
dsmiley commented on pull request #154:
URL: https://github.com/apache/lucene/pull/154#issuecomment-848947225
@mikemccand I'm curious why you say:
> This was an overly complex approach to backwards compatibility!
I think it's rather simple, and the PR was simple as well showing it
[
https://issues.apache.org/jira/browse/LUCENE-9454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351923#comment-17351923
]
ASF subversion and git services commented on LUCENE-9454:
-
Commit
romseygeek merged pull request #154:
URL: https://github.com/apache/lucene/pull/154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
romseygeek commented on pull request #154:
URL: https://github.com/apache/lucene/pull/154#issuecomment-848901996
> +1, this is 9.0 only?
Yes, I should have made that clear, sorry!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351857#comment-17351857
]
Tomoko Uchida commented on LUCENE-9448:
---
Ok thank you [~uschindler] for your feedback, too.
>
[
https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351849#comment-17351849
]
Uwe Schindler commented on LUCENE-9448:
---
No fat jars, please! It is fine with shading sometimes to
[
https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351845#comment-17351845
]
Tomoko Uchida commented on LUCENE-9448:
---
Ok thank you [~dweiss] for your comment.
> Make an
[
https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351843#comment-17351843
]
Dawid Weiss commented on LUCENE-9448:
-
I prefer if it's an explicit - JAR + proper manifest. This
[
https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351840#comment-17351840
]
Tomoko Uchida commented on LUCENE-9448:
---
I cleaned up the obsoleted sh and bat scripts. Now luke
[
https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351830#comment-17351830
]
ASF subversion and git services commented on LUCENE-9448:
-
Commit
janhoy commented on pull request #136:
URL: https://github.com/apache/lucene/pull/136#issuecomment-848803076
Since release 8.9 is in feature freeze I now target this at 9.0.0. I moved
CHANGES entry and @since tags. Will commit later this week.
--
This is an automated message from the
janhoy commented on a change in pull request #136:
URL: https://github.com/apache/lucene/pull/136#discussion_r639745969
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/sv/SwedishMinimalStemmer.java
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache
gerlowskija opened a new pull request #2501:
URL: https://github.com/apache/lucene-solr/pull/2501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
[
https://issues.apache.org/jira/browse/LUCENE-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351738#comment-17351738
]
Dawid Weiss commented on LUCENE-9975:
-
Oh, sorry for being dim. You're right! I'll clean this up.
>
gsmiller commented on pull request #142:
URL: https://github.com/apache/lucene/pull/142#issuecomment-848700105
Thanks for the feedback @msokolov!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gsmiller commented on a change in pull request #142:
URL: https://github.com/apache/lucene/pull/142#discussion_r639646070
##
File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysQuery.java
##
@@ -40,21 +41,65 @@
// TODO change the way DrillSidewaysScorer is
gsmiller commented on a change in pull request #142:
URL: https://github.com/apache/lucene/pull/142#discussion_r639641681
##
File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysQuery.java
##
@@ -40,21 +41,65 @@
// TODO change the way DrillSidewaysScorer is
gsmiller commented on a change in pull request #142:
URL: https://github.com/apache/lucene/pull/142#discussion_r639641131
##
File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysQuery.java
##
@@ -142,7 +212,19 @@ public BulkScorer bulkScorer(LeafReaderContext
[
https://issues.apache.org/jira/browse/LUCENE-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351680#comment-17351680
]
Uwe Schindler commented on LUCENE-9975:
---
{quote}I think this issue could be elegantly solved by
[
https://issues.apache.org/jira/browse/LUCENE-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351678#comment-17351678
]
Uwe Schindler edited comment on LUCENE-9975 at 5/26/21, 9:59 AM:
-
There
[
https://issues.apache.org/jira/browse/LUCENE-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351678#comment-17351678
]
Uwe Schindler edited comment on LUCENE-9975 at 5/26/21, 9:55 AM:
-
There
[
https://issues.apache.org/jira/browse/LUCENE-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351678#comment-17351678
]
Uwe Schindler commented on LUCENE-9975:
---
There are no signatures (*.asc) files. Those are not
[
https://issues.apache.org/jira/browse/LUCENE-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351675#comment-17351675
]
Alan Woodward commented on LUCENE-9545:
---
Nudging this one back to life again with a PR:
romseygeek opened a new pull request #154:
URL: https://github.com/apache/lucene/pull/154
Version switching on Analyzer behaviour should be implemented
in the various component factories, rather than on a mutable
setting on Analyzer itself.
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/LUCENE-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351667#comment-17351667
]
Dawid Weiss commented on LUCENE-9975:
-
I'm a bit confused. The build currently says we don't sign
[
https://issues.apache.org/jira/browse/LUCENE-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward reassigned LUCENE-8143:
-
Assignee: Alan Woodward
> Remove SpanBoostQuery
> -
>
>
[
https://issues.apache.org/jira/browse/LUCENE-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351662#comment-17351662
]
Alan Woodward commented on LUCENE-8143:
---
Now that Spans are in the queries module this seems like
romseygeek merged pull request #152:
URL: https://github.com/apache/lucene/pull/152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[
https://issues.apache.org/jira/browse/LUCENE-9977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9977:
--
Issue Type: Bug (was: Task)
> Gradle's RAT task has missing inputs, so it can't figure out
[
https://issues.apache.org/jira/browse/LUCENE-9977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351656#comment-17351656
]
Dawid Weiss commented on LUCENE-9977:
-
I'll take a look later, thanks Uwe.
> Gradle's RAT task has
[
https://issues.apache.org/jira/browse/LUCENE-9977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351658#comment-17351658
]
Uwe Schindler commented on LUCENE-9977:
---
Solr issue: SOLR-15436
> Gradle's RAT task has missing
[
https://issues.apache.org/jira/browse/LUCENE-9977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9977:
--
Component/s: general/build
> Gradle's RAT task has missing inputs, so it can't figure out
Uwe Schindler created LUCENE-9977:
-
Summary: Gradle's RAT task has missing inputs, so it can't figure
out when to run
Key: LUCENE-9977
URL: https://issues.apache.org/jira/browse/LUCENE-9977
Project:
[
https://issues.apache.org/jira/browse/LUCENE-9977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351654#comment-17351654
]
Uwe Schindler commented on LUCENE-9977:
---
Hi,
I tried to fix the problem but gave up because of
[
https://issues.apache.org/jira/browse/LUCENE-9589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351653#comment-17351653
]
Jan Høydahl commented on LUCENE-9589:
-
I got feedback in PR (thanks [~karl.wettin]), intending to
glawson0 commented on a change in pull request #146:
URL: https://github.com/apache/lucene/pull/146#discussion_r639529557
##
File path:
lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestFlattenGraphFilter.java
##
@@ -314,5 +314,116 @@ public void
Dawid Weiss created LUCENE-9976:
---
Summary: WANDScorer assertion error in ensureConsistent
Key: LUCENE-9976
URL: https://issues.apache.org/jira/browse/LUCENE-9976
Project: Lucene - Core
Issue
[
https://issues.apache.org/jira/browse/LUCENE-9974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351627#comment-17351627
]
ASF subversion and git services commented on LUCENE-9974:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9974.
-
Fix Version/s: main (9.0)
Resolution: Fixed
> The test-framework module should apply the
dweiss merged pull request #153:
URL: https://github.com/apache/lucene/pull/153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
zacharymorn commented on pull request #128:
URL: https://github.com/apache/lucene/pull/128#issuecomment-848533196
I just tried to run `CheckIndex#checkIndex` via command line with index
built for other task, but it failed from `Version` check (even without my
latest changes):
```
if
zacharymorn commented on a change in pull request #128:
URL: https://github.com/apache/lucene/pull/128#discussion_r639460784
##
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##
@@ -1058,16 +1261,14 @@ public Status checkIndex(List onlySegments)
zacharymorn commented on a change in pull request #128:
URL: https://github.com/apache/lucene/pull/128#discussion_r639460089
##
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##
@@ -731,74 +810,173 @@ public Status checkIndex(List onlySegments)
throws
zacharymorn commented on a change in pull request #128:
URL: https://github.com/apache/lucene/pull/128#discussion_r639459734
##
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##
@@ -731,74 +810,173 @@ public Status checkIndex(List onlySegments)
throws
zacharymorn commented on a change in pull request #128:
URL: https://github.com/apache/lucene/pull/128#discussion_r639457972
##
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##
@@ -700,29 +771,37 @@ public Status checkIndex(List onlySegments)
throws
zacharymorn commented on a change in pull request #128:
URL: https://github.com/apache/lucene/pull/128#discussion_r639455850
##
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##
@@ -926,17 +1100,19 @@ public Status checkIndex(List onlySegments)
throws
zacharymorn commented on a change in pull request #128:
URL: https://github.com/apache/lucene/pull/128#discussion_r639455850
##
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##
@@ -926,17 +1100,19 @@ public Status checkIndex(List onlySegments)
throws
zacharymorn edited a comment on pull request #128:
URL: https://github.com/apache/lucene/pull/128#issuecomment-848482687
Thanks @mikemccand for the feedback comment, as well as running the index
check and posting the results here! I was planning to do that next after adding
some more
60 matches
Mail list logo
