[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index parts check within each segment

2021-05-27 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r641274199 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -3720,6 +3957,20 @@ public static Options parseOptions(String[] args) {

[GitHub] [lucene-solr] donnerpeter commented on pull request #2499: LUCENE-9687: Hunspell support improvements

2021-05-27 Thread GitBox
donnerpeter commented on pull request #2499: URL: https://github.com/apache/lucene-solr/pull/2499#issuecomment-850121178 @dweiss @rmuir I'd be grateful for an opinion on this PR and whether Lucene 8.9 needs this change at all. -- This is an automated message from the Apache Git Service.

[GitHub] [lucene] dsmiley commented on a change in pull request #155: LUCENE-8143: Remove no-op SpanBoostQuery

2021-05-27 Thread GitBox
dsmiley commented on a change in pull request #155: URL: https://github.com/apache/lucene/pull/155#discussion_r641254711 ## File path: lucene/queryparser/src/test/org/apache/lucene/queryparser/xml/TestCoreParser.java ## @@ -201,6 +206,39 @@ public void

[GitHub] [lucene] glawson0 commented on a change in pull request #157: LUCENE-9963 Fix issue with FlattenGraphFilter throwing exceptions from holes

2021-05-27 Thread GitBox
glawson0 commented on a change in pull request #157: URL: https://github.com/apache/lucene/pull/157#discussion_r641212886 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/core/FlattenGraphFilter.java ## @@ -193,14 +194,25 @@ private boolean

[jira] [Commented] (LUCENE-9963) Flatten graph filter has errors when there are holes at beginning or end of alternate paths

2021-05-27 Thread Geoffrey Lawson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352935#comment-17352935 ] Geoffrey Lawson commented on LUCENE-9963: - I've created a draft pull request for the fix:

[GitHub] [lucene] glawson0 opened a new pull request #157: LUCENE-9963 Fix issue with FlattenGraphFilter throwing exceptions from holes

2021-05-27 Thread GitBox
glawson0 opened a new pull request #157: URL: https://github.com/apache/lucene/pull/157 # Description There are various situations were the flatten graph filter may throw an exception or drop tokens due to mishandling of holes in the analysis graph. The primary causes

[jira] [Resolved] (LUCENE-9507) Custom order for leaves in DirectoryReader, IndexWriter and searcher

2021-05-27 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova resolved LUCENE-9507. - Resolution: Fixed > Custom order for leaves in DirectoryReader, IndexWriter and

[jira] [Updated] (LUCENE-9507) Custom order for leaves in DirectoryReader, IndexWriter and searcher

2021-05-27 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova updated LUCENE-9507: Fix Version/s: 8.9 main (9.0) > Custom order for leaves in

[jira] [Updated] (LUCENE-9935) Bulk merges for stored fields when index sorting is enabled

2021-05-27 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova updated LUCENE-9935: Fix Version/s: 8.9 > Bulk merges for stored fields when index sorting is enabled >

[GitHub] [lucene] dweiss commented on a change in pull request #156: LUCENE-9975: don't require signing of 'unsignedJars' publication

2021-05-27 Thread GitBox
dweiss commented on a change in pull request #156: URL: https://github.com/apache/lucene/pull/156#discussion_r640819830 ## File path: gradle/publishing/defaults-maven.gradle ## @@ -209,11 +214,11 @@ configure(subprojects.findAll { it.path in rootProject.published }) { prj ->

[GitHub] [lucene] dweiss opened a new pull request #156: LUCENE-9975: don't require signing of 'unsignedJars' publication

2021-05-27 Thread GitBox
dweiss opened a new pull request #156: URL: https://github.com/apache/lucene/pull/156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Updated] (LUCENE-9937) ann-benchmarks results for HNSW search

2021-05-27 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-9937: - Description: I hooked up our HNSW implementation to

[jira] [Commented] (LUCENE-9625) Benchmark KNN search with ann-benchmarks

2021-05-27 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352621#comment-17352621 ] Michael Sokolov commented on LUCENE-9625: - Yes, once we have a publicly-available release I

[jira] [Commented] (LUCENE-9625) Benchmark KNN search with ann-benchmarks

2021-05-27 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352600#comment-17352600 ] Julie Tibshirani commented on LUCENE-9625: -- I somehow completely missed this before posting my

[jira] [Commented] (LUCENE-9204) Move span queries to the queries module

2021-05-27 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352589#comment-17352589 ] Michael Gibney commented on LUCENE-9204: {quote}Intervals automatically rewrite disjunctions

[GitHub] [lucene] dweiss commented on pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index parts check within each segment

2021-05-27 Thread GitBox
dweiss commented on pull request #128: URL: https://github.com/apache/lucene/pull/128#issuecomment-849741666 bq. LOL!! Now what am I going to do with my 117 remaining cores!! I think this is very appropriate: https://en.wikipedia.org/wiki/Core_War -- This is an automated

[jira] [Updated] (LUCENE-9979) Implement negation of facet path in DrillDownQuery

2021-05-27 Thread Nicola Buso (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicola Buso updated LUCENE-9979: Attachment: 0001-Implement-negate-facet-path-in-DrillDownQuery.patch > Implement negation of

[jira] [Created] (LUCENE-9979) Implement negation of facet path in DrillDownQuery

2021-05-27 Thread Nicola Buso (Jira)
Nicola Buso created LUCENE-9979: --- Summary: Implement negation of facet path in DrillDownQuery Key: LUCENE-9979 URL: https://issues.apache.org/jira/browse/LUCENE-9979 Project: Lucene - Core

[GitHub] [lucene] gsmiller commented on pull request #149: LUCENE-9971: SortedSetDocValuesFacetCounts throws exception in case of unseen dimension (unlike other Facet implementations)

2021-05-27 Thread GitBox
gsmiller commented on pull request #149: URL: https://github.com/apache/lucene/pull/149#issuecomment-849695286 Thanks for taking this on @sqshq! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (LUCENE-9204) Move span queries to the queries module

2021-05-27 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352541#comment-17352541 ] Alan Woodward commented on LUCENE-9204: --- > The "the big bad wolf" example (in ES docs above) is

[GitHub] [lucene] gsmiller commented on a change in pull request #149: LUCENE-9971: SortedSetDocValuesFacetCounts throws exception in case of unseen dimension (unlike other Facet implementations)

2021-05-27 Thread GitBox
gsmiller commented on a change in pull request #149: URL: https://github.com/apache/lucene/pull/149#discussion_r640649039 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java ## @@ -110,17 +109,10 @@ public boolean siblingsLoaded() {

[GitHub] [lucene] msokolov commented on pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index parts check within each segment

2021-05-27 Thread GitBox
msokolov commented on pull request #128: URL: https://github.com/apache/lucene/pull/128#issuecomment-849694198 Not bitcoin mining I hope On Thu, May 27, 2021 at 8:56 AM Michael McCandless ***@***.***> wrote: > -threadCount currently only supports up to 11 threads. Value

[jira] [Commented] (LUCENE-9204) Move span queries to the queries module

2021-05-27 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352537#comment-17352537 ] Michael Gibney commented on LUCENE-9204: [~romseygeek], [~mikemccand]: on the topic of comparing

[GitHub] [lucene] mikemccand commented on pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index parts check within each segment

2021-05-27 Thread GitBox
mikemccand commented on pull request #128: URL: https://github.com/apache/lucene/pull/128#issuecomment-849681533 Phew, aha! I caught my mistake! When I ran `CheckIndex`, I failed to pass the `.broken` index -- I was just checking the original (presumably NOT corrupt) index. I reran

[GitHub] [lucene-solr] martin-huber commented on pull request #1608: LUCENE-9379: Encrypting Directory - functional but to optimize

2021-05-27 Thread GitBox
martin-huber commented on pull request #1608: URL: https://github.com/apache/lucene-solr/pull/1608#issuecomment-849677976 @bruno-roustant we tried to integrate your FileEncryptingDirectory in our use case. We before already did own attempts for a similar goal and in order to test it

[GitHub] [lucene] mikemccand commented on pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index parts check within each segment

2021-05-27 Thread GitBox
mikemccand commented on pull request #128: URL: https://github.com/apache/lucene/pull/128#issuecomment-849677698 OK, I have good news and bad news. Good news first! I wrote a [simple little Python

[jira] [Comment Edited] (LUCENE-9379) Directory based approach for index encryption

2021-05-27 Thread Martin Huber (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352508#comment-17352508 ] Martin Huber edited comment on LUCENE-9379 at 5/27/21, 2:15 PM:

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2021-05-27 Thread Martin Huber (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352508#comment-17352508 ] Martin Huber commented on LUCENE-9379: -- [~broustant]  - one very valid use case that is not

[GitHub] [lucene] mikemccand commented on pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index parts check within each segment

2021-05-27 Thread GitBox
mikemccand commented on pull request #128: URL: https://github.com/apache/lucene/pull/128#issuecomment-849627976 OK I re-ran with the latest PR and I LOVE the output -- the lines come as each check finishes, so you can see what is fast/slow. It seems postings is slowest, preceded by doc

[GitHub] [lucene] mikemccand commented on a change in pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index parts check within each segment

2021-05-27 Thread GitBox
mikemccand commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r640598779 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -3720,6 +3957,20 @@ public static Options parseOptions(String[] args) {

[GitHub] [lucene] romseygeek commented on pull request #155: LUCENE-8143: Remove no-op SpanBoostQuery

2021-05-27 Thread GitBox
romseygeek commented on pull request #155: URL: https://github.com/apache/lucene/pull/155#issuecomment-849612166 > Do we need a MIGRATE.txt entry explaining the situation? Yes, and a CHANGES as well, which I always forget to do. Thanks! -- This is an automated message from the

[GitHub] [lucene] mikemccand commented on pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index parts check within each segment

2021-05-27 Thread GitBox
mikemccand commented on pull request #128: URL: https://github.com/apache/lucene/pull/128#issuecomment-849611238 > -threadCount currently only supports up to 11 threads. Value higher than that will be capped. LOL!! Now what am I going to do with my 117 remaining cores!! -- This

[jira] [Commented] (LUCENE-9448) Make an equivalent to Ant's "run" target for Luke module

2021-05-27 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352384#comment-17352384 ] Tomoko Uchida commented on LUCENE-9448: --- I opened LUCENE-9978 to explore the possibility, also

[jira] [Commented] (LUCENE-9448) Make an equivalent to Ant's "run" target for Luke module

2021-05-27 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352381#comment-17352381 ] Dawid Weiss commented on LUCENE-9448: - I think so. This requires changes in how the distribution is

[jira] [Commented] (LUCENE-9448) Make an equivalent to Ant's "run" target for Luke module

2021-05-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352380#comment-17352380 ] ASF subversion and git services commented on LUCENE-9448: - Commit

[jira] [Commented] (LUCENE-8143) Remove SpanBoostQuery

2021-05-27 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352363#comment-17352363 ] Alan Woodward commented on LUCENE-8143: --- I opened a new PR:

[jira] [Commented] (LUCENE-9978) [DISSCUSS] Make Luke a standalone package distribution

2021-05-27 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352359#comment-17352359 ] Tomoko Uchida commented on LUCENE-9978: --- First of all, we need to decide if distributing Luke as a

[jira] [Updated] (LUCENE-9978) [DISSCUSS] Make Luke a standalone package distribution

2021-05-27 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-9978: -- Summary: [DISSCUSS] Make Luke a standalone package distribution (was: [DISCUSS] Make Luke as

[jira] [Created] (LUCENE-9978) [DISCUSS] Make Luke as a standalone package distribution

2021-05-27 Thread Tomoko Uchida (Jira)
Tomoko Uchida created LUCENE-9978: - Summary: [DISCUSS] Make Luke as a standalone package distribution Key: LUCENE-9978 URL: https://issues.apache.org/jira/browse/LUCENE-9978 Project: Lucene - Core

[GitHub] [lucene] romseygeek commented on pull request #155: LUCENE-8143: Remove no-op SpanBoostQuery

2021-05-27 Thread GitBox
romseygeek commented on pull request #155: URL: https://github.com/apache/lucene/pull/155#issuecomment-849492633 I added some tests to the complex query parser and xml query parser to ensure that top-level boosts are still correctly applied. Other than that, this is pretty simple, mostly

[GitHub] [lucene] romseygeek opened a new pull request #155: LUCENE-8143: Remove no-op SpanBoostQuery

2021-05-27 Thread GitBox
romseygeek opened a new pull request #155: URL: https://github.com/apache/lucene/pull/155 Boosts are ignored on inner span queries, and top-level boosts can be applied by using a normal BoostQuery, so SpanBoostQuery itself is redundant and trappy. This commit removes it entirely.

[jira] [Commented] (LUCENE-9448) Make an equivalent to Ant's "run" target for Luke module

2021-05-27 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352320#comment-17352320 ] Tomoko Uchida commented on LUCENE-9448: --- I would prefer a standalone Luke package to current

[GitHub] [lucene] zacharymorn commented on pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index parts check within each segment

2021-05-27 Thread GitBox
zacharymorn commented on pull request #128: URL: https://github.com/apache/lucene/pull/128#issuecomment-849375766 > There is a typo in "deleteions"? Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [lucene] dweiss commented on pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index parts check within each segment

2021-05-27 Thread GitBox
dweiss commented on pull request #128: URL: https://github.com/apache/lucene/pull/128#issuecomment-849356353 There is a typo in "deleteions"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (LUCENE-9448) Make an equivalent to Ant's "run" target for Luke module

2021-05-27 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352293#comment-17352293 ] Dawid Weiss commented on LUCENE-9448: - I don't think there is any decision on this, Tomoko. What do