[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2021-05-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353645#comment-17353645 ] Robert Muir commented on LUCENE-9379: - As always, you can count on arch to have some good user-level

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2021-05-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353644#comment-17353644 ] Robert Muir commented on LUCENE-9379: - Sorry, the above comment is really wrong. Please see my

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353637#comment-17353637 ] Robert Muir commented on LUCENE-9981: - Before we {{det(reverse())}} this automaton to compute the

[jira] [Updated] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9981: Attachment: LUCENE-9981_test.patch > CompiledAutomaton.getCommonSuffix can be extraordinarily

[GitHub] [lucene] gsmiller commented on a change in pull request #159: LUCENE-9945: extend DrillSideways to expose FacetCollector and drill-down dimensions

2021-05-28 Thread GitBox
gsmiller commented on a change in pull request #159: URL: https://github.com/apache/lucene/pull/159#discussion_r641859710 ## File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java ## @@ -335,10 +342,22 @@ protected boolean scoreSubDocsAtOnce() { /**

[jira] [Created] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-28 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9981: --- Summary: CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit Key: LUCENE-9981 URL:

[GitHub] [lucene] sejal-pawar commented on a change in pull request #159: LUCENE-9945: extend DrillSideways to expose FacetCollector and drill-down dimensions

2021-05-28 Thread GitBox
sejal-pawar commented on a change in pull request #159: URL: https://github.com/apache/lucene/pull/159#discussion_r641856799 ## File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java ## @@ -335,10 +342,22 @@ protected boolean scoreSubDocsAtOnce() {

[jira] [Commented] (LUCENE-9945) Extend DrillSideways to support exposing FacetCollectors directly

2021-05-28 Thread Sejal Pawar (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353635#comment-17353635 ] Sejal Pawar commented on LUCENE-9945: - Pull request: https://github.com/apache/lucene/pull/159 >

[GitHub] [lucene] sejal-pawar commented on a change in pull request #159: LUCENE-9945: extend DrillSideways to expose FacetCollector and drill-down dimensions

2021-05-28 Thread GitBox
sejal-pawar commented on a change in pull request #159: URL: https://github.com/apache/lucene/pull/159#discussion_r641856799 ## File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java ## @@ -335,10 +342,22 @@ protected boolean scoreSubDocsAtOnce() {

[GitHub] [lucene] gsmiller commented on a change in pull request #159: LUCENE-9945: extend DrillSideways to expose FacetCollector and drill-down dimensions

2021-05-28 Thread GitBox
gsmiller commented on a change in pull request #159: URL: https://github.com/apache/lucene/pull/159#discussion_r641852899 ## File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java ## @@ -335,10 +342,22 @@ protected boolean scoreSubDocsAtOnce() { /**

[GitHub] [lucene] gsmiller commented on a change in pull request #138: LUCENE-9956: Make getBaseQuery, getDrillDownQueries API from DrillDownQuery public

2021-05-28 Thread GitBox
gsmiller commented on a change in pull request #138: URL: https://github.com/apache/lucene/pull/138#discussion_r641848546 ## File path: lucene/facet/src/java/org/apache/lucene/facet/DrillDownQuery.java ## @@ -170,16 +185,36 @@ private BooleanQuery getBooleanQuery() {

[GitHub] [lucene] sejal-pawar opened a new pull request #159: extend DrillSideways to expose FacetCollector and drill-down dimensions

2021-05-28 Thread GitBox
sejal-pawar opened a new pull request #159: URL: https://github.com/apache/lucene/pull/159 # Description (From [LUCENE-9945](https://issues.apache.org/jira/browse/LUCENE-9945)) The DrillSideways logic currently encapsulates, 1) the creation of multiple FacetsCollector

[jira] [Updated] (LUCENE-9964) FacetResult.labelValues.value is not accurate for duplicate labels in a document

2021-05-28 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gautam Worah updated LUCENE-9964: - Issue Type: Bug (was: Improvement) > FacetResult.labelValues.value is not accurate for

[jira] [Updated] (LUCENE-9945) Extend DrillSideways to support exposing FacetCollectors directly

2021-05-28 Thread Sejal Pawar (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sejal Pawar updated LUCENE-9945: Attachment: (was: LUCENE-9945.patch) > Extend DrillSideways to support exposing

[jira] [Updated] (LUCENE-9945) Extend DrillSideways to support exposing FacetCollectors directly

2021-05-28 Thread Sejal Pawar (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sejal Pawar updated LUCENE-9945: Attachment: LUCENE-9945.patch > Extend DrillSideways to support exposing FacetCollectors directly

[GitHub] [lucene-solr] rmuir commented on pull request #2499: LUCENE-9687: Hunspell support improvements

2021-05-28 Thread GitBox
rmuir commented on pull request #2499: URL: https://github.com/apache/lucene-solr/pull/2499#issuecomment-850699447 I'm sorry i've been nonresponsive, been crazy busy, just came up for air now. Thank you for backporting this to 8.x! Great improvements to get out there to the users now.

[GitHub] [lucene] gautamworah96 commented on a change in pull request #138: LUCENE-9956: Make getBaseQuery, getDrillDownQueries API from DrillDownQuery public

2021-05-28 Thread GitBox
gautamworah96 commented on a change in pull request #138: URL: https://github.com/apache/lucene/pull/138#discussion_r641822305 ## File path: lucene/facet/src/java/org/apache/lucene/facet/DrillDownQuery.java ## @@ -170,15 +184,43 @@ private BooleanQuery getBooleanQuery() {

[GitHub] [lucene] dnhatn commented on pull request #158: LUCENE-9980: Do not expose deleted commit points in IndexDeletionPolicy

2021-05-28 Thread GitBox
dnhatn commented on pull request #158: URL: https://github.com/apache/lucene/pull/158#issuecomment-850650666 @mikemccand Would you mind taking a look? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [lucene] dnhatn opened a new pull request #158: LUCENE-9980: Do not expose deleted commit points in IndexDeletionPolicy

2021-05-28 Thread GitBox
dnhatn opened a new pull request #158: URL: https://github.com/apache/lucene/pull/158 If we fail to delete files that belong to a commit point, then we will expose that deleted commit in the next calls of `IndexDeletionPolicy#onCommit()`. I think we should never expose those deleted

[jira] [Created] (LUCENE-9980) Do not expose deleted commits in IndexDeletionPolicy#onCommit

2021-05-28 Thread Nhat Nguyen (Jira)
Nhat Nguyen created LUCENE-9980: --- Summary: Do not expose deleted commits in IndexDeletionPolicy#onCommit Key: LUCENE-9980 URL: https://issues.apache.org/jira/browse/LUCENE-9980 Project: Lucene - Core

[jira] [Commented] (LUCENE-9687) Hunspell support improvements

2021-05-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353510#comment-17353510 ] ASF subversion and git services commented on LUCENE-9687: - Commit

[GitHub] [lucene-solr] donnerpeter merged pull request #2499: LUCENE-9687: Hunspell support improvements

2021-05-28 Thread GitBox
donnerpeter merged pull request #2499: URL: https://github.com/apache/lucene-solr/pull/2499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [lucene-solr] dweiss commented on pull request #2499: LUCENE-9687: Hunspell support improvements

2021-05-28 Thread GitBox
dweiss commented on pull request #2499: URL: https://github.com/apache/lucene-solr/pull/2499#issuecomment-850444097 Hi @donnerpeter ! I think it's a change that is beneficial for folks who use Hunspell and if you've already put the effort to backport, why not apply it? -- This is an

[GitHub] [lucene-solr] gerlowskija merged pull request #2501: SOLR-15090: Allow backup storage in GCS

2021-05-28 Thread GitBox
gerlowskija merged pull request #2501: URL: https://github.com/apache/lucene-solr/pull/2501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Resolved] (LUCENE-9589) Swedish Minimal Stemmer

2021-05-28 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved LUCENE-9589. - Fix Version/s: main (9.0) Resolution: Fixed > Swedish Minimal Stemmer >

[jira] [Commented] (LUCENE-9589) Swedish Minimal Stemmer

2021-05-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353316#comment-17353316 ] ASF subversion and git services commented on LUCENE-9589: - Commit

[GitHub] [lucene] janhoy merged pull request #136: LUCENE-9589 Swedish Minimal Stemmer

2021-05-28 Thread GitBox
janhoy merged pull request #136: URL: https://github.com/apache/lucene/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [lucene] rmuir commented on pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index parts check within each segment

2021-05-28 Thread GitBox
rmuir commented on pull request #128: URL: https://github.com/apache/lucene/pull/128#issuecomment-850340290 I'm gonna throw out the crazy idea to make `-fast` the new default. The previous `-slow` could be moved to `-slower` and the previous current behavior could be activated by `-slow`.

[GitHub] [lucene] rmuir commented on pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index parts check within each segment

2021-05-28 Thread GitBox
rmuir commented on pull request #128: URL: https://github.com/apache/lucene/pull/128#issuecomment-850335925 > The python tool looks very cool and thanks for testing it! One issue though is that this bit flipping is causing checksum integrity check failures before the concurrent segment

[GitHub] [lucene] rmuir commented on pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index parts check within each segment

2021-05-28 Thread GitBox
rmuir commented on pull request #128: URL: https://github.com/apache/lucene/pull/128#issuecomment-850330270 > I was finally able to rebuild my local index with wikibigall generating 15 segments, and performed 2 test runs with different threadCount. With 11 threadCount, it took 359.293 sec

[jira] [Commented] (LUCENE-9975) Don't require artifact signing for local maven artifact publishing

2021-05-28 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353231#comment-17353231 ] Uwe Schindler commented on LUCENE-9975: --- Hi, I removed the {{-x signJarsPublication}} from the

[jira] [Resolved] (LUCENE-9975) Don't require artifact signing for local maven artifact publishing

2021-05-28 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9975. - Fix Version/s: main (9.0) Resolution: Fixed > Don't require artifact signing for local

[jira] [Commented] (LUCENE-9975) Don't require artifact signing for local maven artifact publishing

2021-05-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353136#comment-17353136 ] ASF subversion and git services commented on LUCENE-9975: - Commit

[GitHub] [lucene] dweiss merged pull request #156: LUCENE-9975: don't require signing of 'unsignedJars' publication

2021-05-28 Thread GitBox
dweiss merged pull request #156: URL: https://github.com/apache/lucene/pull/156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [lucene] dweiss commented on pull request #156: LUCENE-9975: don't require signing of 'unsignedJars' publication

2021-05-28 Thread GitBox
dweiss commented on pull request #156: URL: https://github.com/apache/lucene/pull/156#issuecomment-850298459 bq. I don't know how this works It's simple but not straightforward. The two entries under "publications" (jars and unsignedJars) cause gradle to create a bunch of

[jira] [Commented] (LUCENE-9204) Move span queries to the queries module

2021-05-28 Thread Jim Ferenczi (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353119#comment-17353119 ] Jim Ferenczi commented on LUCENE-9204: -- The rewriting of disjunctions that contains duplicate is

[GitHub] [lucene] zacharymorn commented on pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index parts check within each segment

2021-05-28 Thread GitBox
zacharymorn commented on pull request #128: URL: https://github.com/apache/lucene/pull/128#issuecomment-850170387 > the lines come as each check finishes, so you can see what is fast/slow. It seems postings is slowest, preceded by doc values, and everything else is super fast. > Can't