[GitHub] [lucene-solr] dsmiley commented on pull request #2520: SOLR-15355 - Upgrade hadoop to version 3.2.2 to fix CVE

2021-06-29 Thread GitBox
dsmiley commented on pull request #2520: URL: https://github.com/apache/lucene-solr/pull/2520#issuecomment-871104080 RE HttpServer2, If tests pass; works for me. I looked a bit at the assertion you removed about the exception message and it's fine I suppose. I doubt it's pertinent what

[jira] [Updated] (LUCENE-8638) Remove deprecated code in master

2021-06-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-8638: - Priority: Blocker (was: Major) > Remove deprecated code in master >

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-06-29 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r661073094 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +349,139 @@ public

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-06-29 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r661074967 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +349,139 @@ public

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-06-29 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r661068707 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +349,139 @@ public

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-06-29 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r661073094 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +349,139 @@ public

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-06-29 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r661068707 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +349,139 @@ public

[GitHub] [lucene] gsmiller opened a new pull request #196: LUCENE-10000: Make MultiCollectorManager consistent with MultiCollector

2021-06-29 Thread GitBox
gsmiller opened a new pull request #196: URL: https://github.com/apache/lucene/pull/196 # Description MultiCollectorManager is now consistent with MultiCollector with respect to early termination, min score setting and score caching. # Solution MultiCollectorManager

[jira] [Commented] (LUCENE-9177) ICUNormalizer2CharFilter worst case is very slow

2021-06-29 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371619#comment-17371619 ] Michael Gibney commented on LUCENE-9177: In case anyone digs into this: my initial approach was

[jira] [Updated] (LUCENE-9905) Revise approach to specifying NN algorithm

2021-06-29 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated LUCENE-9905: -- Fix Version/s: main (9.0) > Revise approach to specifying NN algorithm >

[jira] [Updated] (LUCENE-9908) Move VectorValues#search to VectorReader and LeafReader

2021-06-29 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated LUCENE-9908: -- Fix Version/s: main (9.0) > Move VectorValues#search to VectorReader and LeafReader >

[GitHub] [lucene-solr] markrmiller edited a comment on pull request #2520: SOLR-15355 - Upgrade hadoop to version 3.2.2 to fix CVE

2021-06-29 Thread GitBox
markrmiller edited a comment on pull request #2520: URL: https://github.com/apache/lucene-solr/pull/2520#issuecomment-870728208 Forked in test code, so only done to modify something to make the test world happy. Perhaps allowing a file out location customization or something of the like.

[GitHub] [lucene-solr] markrmiller commented on pull request #2520: SOLR-15355 - Upgrade hadoop to version 3.2.2 to fix CVE

2021-06-29 Thread GitBox
markrmiller commented on pull request #2520: URL: https://github.com/apache/lucene-solr/pull/2520#issuecomment-870728208 Forget in test code, so only done to modify something to make the test world happy. Perhaps allowing a file out location customization or something of the like. Don't

[GitHub] [lucene-solr] antogruz commented on pull request #2520: SOLR-15355 - Upgrade hadoop to version 3.2.2 to fix CVE

2021-06-29 Thread GitBox
antogruz commented on pull request #2520: URL: https://github.com/apache/lucene-solr/pull/2520#issuecomment-870718435 Hey @dsmiley, for your information this is the Pull Request about fixing hadoop CVE. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] antogruz edited a comment on pull request #2520: SOLR-15355 - Upgrade hadoop to version 3.2.2 to fix CVE

2021-06-29 Thread GitBox
antogruz edited a comment on pull request #2520: URL: https://github.com/apache/lucene-solr/pull/2520#issuecomment-870717186 Hello @markrmiller, I mention you since you added the HttpServer2.java file back in 2016 forking it from hadoop project. Please tell me if we should handle this

[GitHub] [lucene-solr] antogruz commented on pull request #2520: SOLR-15355 - Upgrade hadoop to version 3.2.2 to fix CVE

2021-06-29 Thread GitBox
antogruz commented on pull request #2520: URL: https://github.com/apache/lucene-solr/pull/2520#issuecomment-870717186 Hello @markrmiller, I mention you since you added the HttpServer2.java file back in 2016 forking it from hadoop project. Please tell me if we should handle this file

[GitHub] [lucene-solr] antogruz opened a new pull request #2520: SOLR-15355 - Upgrade hadoop to version 3.2.2 to fix CVE

2021-06-29 Thread GitBox
antogruz opened a new pull request #2520: URL: https://github.com/apache/lucene-solr/pull/2520 To do that, I’ve needed to update 2 other files: 1) The HttpServer2.java. It has been forked from hadoop and would not be compatible anymore with this new version. I’ve only patched what

[GitHub] [lucene] rmuir commented on a change in pull request #191: LUCENE-9964: Duplicate long values in a field should only be counted once when using SortedNumericDocValuesFields

2021-06-29 Thread GitBox
rmuir commented on a change in pull request #191: URL: https://github.com/apache/lucene/pull/191#discussion_r660224322 ## File path: lucene/facet/src/test/org/apache/lucene/facet/TestLongValueFacetCounts.java ## @@ -382,19 +383,19 @@ public void testRandomMultiValued() throws

[GitHub] [lucene-solr] JohnHillegass closed pull request #1949: Jinja2_autoescape_false set to True

2021-06-29 Thread GitBox
JohnHillegass closed pull request #1949: URL: https://github.com/apache/lucene-solr/pull/1949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] gautamworah96 commented on a change in pull request #191: LUCENE-9964: Duplicate long values in a field should only be counted once when using SortedNumericDocValuesFields

2021-06-29 Thread GitBox
gautamworah96 commented on a change in pull request #191: URL: https://github.com/apache/lucene/pull/191#discussion_r660149249 ## File path: lucene/facet/src/test/org/apache/lucene/facet/TestLongValueFacetCounts.java ## @@ -382,19 +383,19 @@ public void

[GitHub] [lucene] mikemccand commented on pull request #146: LUCENE-9963 Add tests for alternate path failures in FlattenGraphFilter

2021-06-29 Thread GitBox
mikemccand commented on pull request #146: URL: https://github.com/apache/lucene/pull/146#issuecomment-869757664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [lucene] gsmiller commented on pull request #181: LUCENE-10001: Make CollectionTerminatedException handling in MultiCollector configurable

2021-06-29 Thread GitBox
gsmiller commented on pull request #181: URL: https://github.com/apache/lucene/pull/181#issuecomment-870083122 I've put this in "Draft" state for now after a suggestion over on the Jira issue to approach this differently. I'll update here (and take out of "Draft") once I've had a chance

[GitHub] [lucene] mikemccand commented on a change in pull request #191: LUCENE-9964: Duplicate long values in a field should only be counted once when using SortedNumericDocValuesFields

2021-06-29 Thread GitBox
mikemccand commented on a change in pull request #191: URL: https://github.com/apache/lucene/pull/191#discussion_r659860846 ## File path: lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java ## @@ -162,8 +162,14 @@ private void count(String field, List

[GitHub] [lucene] mikemccand merged pull request #146: LUCENE-9963 Add tests for alternate path failures in FlattenGraphFilter

2021-06-29 Thread GitBox
mikemccand merged pull request #146: URL: https://github.com/apache/lucene/pull/146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-06-29 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r660154028 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +349,139 @@ public

[jira] [Updated] (LUCENE-9978) Make Luke a standalone package distribution

2021-06-29 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-9978: -- Description: Thanks to LUCENE-9448, we now have a neat gradle task to assemble a standalone

[jira] [Updated] (LUCENE-9978) Make Luke a standalone package distribution

2021-06-29 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-9978: -- Summary: Make Luke a standalone package distribution (was: [DISSCUSS] Make Luke a standalone