zhaih opened a new pull request #346:
URL: https://github.com/apache/lucene/pull/346
# Description
* Before caching the query, now LRUCache will check whether the query has
implemented the `Accountable` interface
* Implements `Accountable` for
zhaih commented on a change in pull request #225:
URL: https://github.com/apache/lucene/pull/225#discussion_r719908188
##
File path:
lucene/core/src/java/org/apache/lucene/util/automaton/CompiledAutomaton.java
##
@@ -250,15 +291,23 @@ public CompiledAutomaton(
}
}
[
https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423052#comment-17423052
]
Robert Muir commented on LUCENE-10130:
--
btw, being unsure about the data patterns was part of the
[
https://issues.apache.org/jira/browse/LUCENE-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423047#comment-17423047
]
Ankur commented on LUCENE-10134:
[~dweiss]
Thanks for cleaning up the resource leaks on error. Here is
goankur opened a new pull request #345:
URL: https://github.com/apache/lucene/pull/345
# Description
As part of
[LUCENE-10070](https://issues.apache.org/jira/browse/LUCENE-10070), facet
counting in `ConcurrentSortedSetDocValuesFacetCounts` was modified to check
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423028#comment-17423028
]
Chris M. Hostetter commented on LUCENE-9488:
gradle build gpg support for release signing
[
https://issues.apache.org/jira/browse/LUCENE-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Potter updated LUCENE-10141:
Fix Version/s: 8.10.1
8.11
> Update releaseWizard for 8x to correctly
[
https://issues.apache.org/jira/browse/LUCENE-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Potter resolved LUCENE-10131.
-
Fix Version/s: main (9.0)
Assignee: Timothy Potter
Resolution: Fixed
>
thelabdude commented on a change in pull request #343:
URL: https://github.com/apache/lucene/pull/343#discussion_r719780233
##
File path: lucene/core/src/java/org/apache/lucene/util/Version.java
##
@@ -168,6 +168,13 @@
*/
@Deprecated public static final Version
Timothy Potter created LUCENE-10141:
---
Summary: Update releaseWizard for 8x to correctly create
back-compat indices and update Version in main after repo split
Key: LUCENE-10141
URL:
[
https://issues.apache.org/jira/browse/LUCENE-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423011#comment-17423011
]
ASF subversion and git services commented on LUCENE-10131:
--
Commit
thelabdude merged pull request #343:
URL: https://github.com/apache/lucene/pull/343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
thelabdude commented on a change in pull request #343:
URL: https://github.com/apache/lucene/pull/343#discussion_r719739656
##
File path: lucene/core/src/java/org/apache/lucene/util/Version.java
##
@@ -168,6 +168,13 @@
*/
@Deprecated public static final Version
janhoy commented on a change in pull request #343:
URL: https://github.com/apache/lucene/pull/343#discussion_r719733791
##
File path: lucene/core/src/java/org/apache/lucene/util/Version.java
##
@@ -168,6 +168,13 @@
*/
@Deprecated public static final Version LUCENE_8_9_0
madrob commented on a change in pull request #343:
URL: https://github.com/apache/lucene/pull/343#discussion_r719728206
##
File path: lucene/core/src/java/org/apache/lucene/util/Version.java
##
@@ -168,6 +168,13 @@
*/
@Deprecated public static final Version LUCENE_8_9_0
dnhatn commented on a change in pull request #331:
URL: https://github.com/apache/lucene/pull/331#discussion_r719709277
##
File path:
lucene/test-framework/src/java/org/apache/lucene/search/AssertingBulkScorer.java
##
@@ -80,8 +80,23 @@ public int score(LeafCollector
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422990#comment-17422990
]
Mike Drob commented on LUCENE-9488:
---
I think [~hossman] did some work in the gpg signing, I’m not up
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422982#comment-17422982
]
Jan Høydahl commented on LUCENE-9488:
-
Mike, I'm currently updating releaseWizard in LUCENE-9809. I
[
https://issues.apache.org/jira/browse/LUCENE-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-10134:
-
Component/s: modules/facet
> TestSortedSetDocValuesFacets fails with Bits shared between
[
https://issues.apache.org/jira/browse/LUCENE-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422976#comment-17422976
]
Marc D'Mello commented on LUCENE-10080:
---
Hi [~gsmiller], I looked into it some more and I think
janhoy commented on pull request #344:
URL: https://github.com/apache/lucene/pull/344#issuecomment-931566819
Feel free to add commits to this PR if/when you spot more things that needs
fixing (including the entire scripts folder)
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/LUCENE-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422969#comment-17422969
]
Jan Høydahl commented on LUCENE-9809:
-
I prepared [https://github.com/apache/lucene/pull/344] for
thelabdude commented on a change in pull request #343:
URL: https://github.com/apache/lucene/pull/343#discussion_r719661346
##
File path:
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java
##
@@ -383,6 +383,7 @@ public void
janhoy opened a new pull request #344:
URL: https://github.com/apache/lucene/pull/344
https://issues.apache.org/jira/browse/LUCENE-9809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
madrob commented on a change in pull request #343:
URL: https://github.com/apache/lucene/pull/343#discussion_r719652888
##
File path:
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java
##
@@ -685,7 +686,7 @@ public void
[
https://issues.apache.org/jira/browse/LUCENE-9983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422937#comment-17422937
]
Haoyu Zhai commented on LUCENE-9983:
[~mikemccand] yes we can close it. But it seems I can't close
thelabdude opened a new pull request #343:
URL: https://github.com/apache/lucene/pull/343
Manually fixing up some steps missed during the 8.10 release process.
I don't think this is correct because 8.10 is not listed in the `oldNames`
array in `TestBackwardsCompatibility`. Somebody
mayya-sharipova commented on a change in pull request #331:
URL: https://github.com/apache/lucene/pull/331#discussion_r719549902
##
File path:
lucene/test-framework/src/java/org/apache/lucene/search/AssertingBulkScorer.java
##
@@ -80,8 +80,23 @@ public int score(LeafCollector
thelabdude commented on pull request #342:
URL: https://github.com/apache/lucene/pull/342#issuecomment-931453670
trying to fix 10131 too, so closing this and will re-open from a proper
branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please
thelabdude closed pull request #342:
URL: https://github.com/apache/lucene/pull/342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dnhatn commented on a change in pull request #331:
URL: https://github.com/apache/lucene/pull/331#discussion_r719548306
##
File path:
lucene/test-framework/src/java/org/apache/lucene/search/AssertingBulkScorer.java
##
@@ -80,8 +80,23 @@ public int score(LeafCollector
danmuzi commented on a change in pull request #338:
URL: https://github.com/apache/lucene/pull/338#discussion_r719541562
##
File path: lucene/core/src/java/org/apache/lucene/search/Sort.java
##
@@ -108,20 +55,6 @@ public Sort() {
/** Sorts by the criteria in the given
thelabdude opened a new pull request #342:
URL: https://github.com/apache/lucene/pull/342
Missed task when doing 8.10 release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/LUCENE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422853#comment-17422853
]
Nikolay Khitrin commented on LUCENE-10140:
--
I'm afraid, it will not cover complex
khitrin commented on pull request #341:
URL: https://github.com/apache/lucene/pull/341#issuecomment-931411794
@romseygeek , could you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
khitrin closed pull request #270:
URL: https://github.com/apache/lucene/pull/270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
khitrin commented on pull request #270:
URL: https://github.com/apache/lucene/pull/270#issuecomment-931400123
Superseded by #341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
khitrin opened a new pull request #341:
URL: https://github.com/apache/lucene/pull/341
# Description
Minimizing intervals (maybe just ORDERED and AT_LEAST, but not sure) can
move sub iterators to non-sub-match position inside match window, but
CachingMatchesIterator logic
mayya-sharipova commented on a change in pull request #331:
URL: https://github.com/apache/lucene/pull/331#discussion_r719487400
##
File path:
lucene/test-framework/src/java/org/apache/lucene/search/AssertingBulkScorer.java
##
@@ -80,8 +80,23 @@ public int score(LeafCollector
mayya-sharipova commented on a change in pull request #331:
URL: https://github.com/apache/lucene/pull/331#discussion_r719487400
##
File path:
lucene/test-framework/src/java/org/apache/lucene/search/AssertingBulkScorer.java
##
@@ -80,8 +80,23 @@ public int score(LeafCollector
[
https://issues.apache.org/jira/browse/LUCENE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422822#comment-17422822
]
Alan Woodward commented on LUCENE-10140:
I wonder if we can be cleverer about rewriting ORDERED
dnhatn commented on a change in pull request #331:
URL: https://github.com/apache/lucene/pull/331#discussion_r719480931
##
File path:
lucene/test-framework/src/java/org/apache/lucene/search/AssertingScorable.java
##
@@ -45,13 +45,41 @@ public static Scorable wrap(Scorable in)
Nikolay Khitrin created LUCENE-10140:
Summary: Minimizing intervals can give inaccurate positions for
duplicate terms
Key: LUCENE-10140
URL: https://issues.apache.org/jira/browse/LUCENE-10140
[
https://issues.apache.org/jira/browse/LUCENE-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reassigned LUCENE-9809:
---
Assignee: Jan Høydahl
> Adapt Release Wizard to only release Lucene
>
[
https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422815#comment-17422815
]
Michael McCandless commented on LUCENE-8739:
Wow, these are compelling results!
Can you try
mayya-sharipova commented on a change in pull request #331:
URL: https://github.com/apache/lucene/pull/331#discussion_r719451602
##
File path:
lucene/test-framework/src/java/org/apache/lucene/search/AssertingScorable.java
##
@@ -45,13 +45,41 @@ public static Scorable
Dawid Weiss created LUCENE-10139:
Summary: ExternalRefSorter should return a covariant with a
subtype of BytesRefIterator that is Closeable
Key: LUCENE-10139
URL:
[
https://issues.apache.org/jira/browse/LUCENE-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422785#comment-17422785
]
ASF subversion and git services commented on LUCENE-9713:
-
Commit
uschindler commented on a change in pull request #327:
URL: https://github.com/apache/lucene/pull/327#discussion_r719401321
##
File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java
##
@@ -94,38 +91,54 @@ private void flush() throws IOException {
uschindler commented on a change in pull request #327:
URL: https://github.com/apache/lucene/pull/327#discussion_r719401059
##
File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java
##
@@ -94,38 +91,54 @@ private void flush() throws IOException {
[
https://issues.apache.org/jira/browse/LUCENE-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422782#comment-17422782
]
ASF subversion and git services commented on LUCENE-9713:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422779#comment-17422779
]
ASF subversion and git services commented on LUCENE-9713:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9713.
-
Fix Version/s: main (9.0)
Resolution: Fixed
> Did we lose the UTF-8 BOM detection in
dweiss merged pull request #339:
URL: https://github.com/apache/lucene/pull/339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422767#comment-17422767
]
ASF subversion and git services commented on LUCENE-10135:
--
Commit
dweiss merged pull request #334:
URL: https://github.com/apache/lucene/pull/334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-10135.
--
Resolution: Fixed
> Correct passage selector behavior for long matching snippets
>
[
https://issues.apache.org/jira/browse/LUCENE-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422763#comment-17422763
]
Alan Woodward commented on LUCENE-9325:
---
Picking this one up again: I've opened
[
https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422761#comment-17422761
]
Michael Sokolov commented on LUCENE-8638:
-
> Shall we remove the 'blocker' tag from this issue
[
https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Sokolov updated LUCENE-8638:
Priority: Major (was: Blocker)
> Remove deprecated code in main
>
romseygeek opened a new pull request #338:
URL: https://github.com/apache/lucene/pull/338
Sort is used in all sorts of settings where we assume that it is immutable
(for example, in IndexWriterConfig). This commit makes it so, plus it also
updates the severely outdated javadoc.
--
dnhatn commented on a change in pull request #331:
URL: https://github.com/apache/lucene/pull/331#discussion_r719372028
##
File path:
lucene/test-framework/src/java/org/apache/lucene/search/AssertingScorable.java
##
@@ -45,13 +45,41 @@ public static Scorable wrap(Scorable in)
uschindler edited a comment on pull request #335:
URL: https://github.com/apache/lucene/pull/335#issuecomment-931255937
Hi,
I will close this PR because with JDK 11 it is problematic.
I improved the whole thing a bit by changing LongValues to be an interface
instead of an
uschindler commented on pull request #335:
URL: https://github.com/apache/lucene/pull/335#issuecomment-931258217
FYI, with JDK 18 the other branch works fast, it is just Java 11 that cannot
handle this.
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/LUCENE-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-10137.
Resolution: Won't Fix
This seems to be still problematic with Java 11.
> Refactor
uschindler closed pull request #335:
URL: https://github.com/apache/lucene/pull/335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
uschindler commented on pull request #335:
URL: https://github.com/apache/lucene/pull/335#issuecomment-931255937
Hi,
I will close this PR because with JDK 11 it is problematic.
I improved the whole thing a bit by changing LongValues to be an interface
instead of an abstract
[
https://issues.apache.org/jira/browse/LUCENE-10132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved LUCENE-10132.
Fix Version/s: main (9.0)
Assignee: Alan Woodward
Resolution: Fixed
>
romseygeek merged pull request #337:
URL: https://github.com/apache/lucene/pull/337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422693#comment-17422693
]
ASF subversion and git services commented on LUCENE-10118:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved LUCENE-10138.
Fix Version/s: main (9.0)
Assignee: Alan Woodward
Resolution: Fixed
>
[
https://issues.apache.org/jira/browse/LUCENE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422691#comment-17422691
]
ASF subversion and git services commented on LUCENE-10138:
--
Commit
romseygeek merged pull request #336:
URL: https://github.com/apache/lucene/pull/336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rmuir commented on pull request #335:
URL: https://github.com/apache/lucene/pull/335#issuecomment-931194035
where is the "heavy code duplication" ? You still have method to decode for
each bit size. But now we made things more complicated for hotspot.
--
This is an automated
ChrisHegarty opened a new pull request #337:
URL: https://github.com/apache/lucene/pull/337
# Description
Improve merge thread activity logging.
# Solution
Expand the log message when CMS.MergeThread completes its merge operation,
to include addition useful diagnostic
uschindler commented on pull request #335:
URL: https://github.com/apache/lucene/pull/335#issuecomment-931145999
Looks like there's a slowdown with facets. Digging (waiting for CPU
profiles)...
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/LUCENE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-10138:
---
Description:
By default, the gradle plugin repository downloads its plugins from jcenter.
[
https://issues.apache.org/jira/browse/LUCENE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422652#comment-17422652
]
Alan Woodward commented on LUCENE-10138:
I opened [https://github.com/apache/lucene/pull/336]
romseygeek opened a new pull request #336:
URL: https://github.com/apache/lucene/pull/336
The gradle plugin portal uses jcenter to resolve third-party plugins, which
can be flaky. This commit instructs gradle to look first in maven central,
and only use the plugin portal for gradle's
[
https://issues.apache.org/jira/browse/LUCENE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422647#comment-17422647
]
Dawid Weiss commented on LUCENE-10138:
--
Yup. I think you guys at es have better gradle engineers
uschindler commented on pull request #335:
URL: https://github.com/apache/lucene/pull/335#issuecomment-931098148
Actually I will do a perf test in a minute, but the code and call behaviour
here is more or less identical to before. Instead of creating the classes in
source code we let the
[
https://issues.apache.org/jira/browse/LUCENE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422644#comment-17422644
]
Alan Woodward commented on LUCENE-10138:
> jcenter is deprecated and should be removed from the
[
https://issues.apache.org/jira/browse/LUCENE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422643#comment-17422643
]
Dawid Weiss commented on LUCENE-10138:
--
Can you create a PR, Alan, so that I can see where you
[
https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422642#comment-17422642
]
Alan Woodward commented on LUCENE-8638:
---
> After that what remains marked as Deprecated I don't
[
https://issues.apache.org/jira/browse/LUCENE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422641#comment-17422641
]
Dawid Weiss commented on LUCENE-10138:
--
jcenter is deprecated and should be removed from the build
jpountz commented on pull request #335:
URL: https://github.com/apache/lucene/pull/335#issuecomment-931093010
I'm curious what luceneutil will report with this change, the sorting and
faceting tasks should give us a good idea of whether there is a slowdown or not.
--
This is an
Alan Woodward created LUCENE-10138:
--
Summary: Use maven central for gradle plugin repository
Key: LUCENE-10138
URL: https://issues.apache.org/jira/browse/LUCENE-10138
Project: Lucene - Core
uschindler commented on a change in pull request #327:
URL: https://github.com/apache/lucene/pull/327#discussion_r719199226
##
File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java
##
@@ -94,38 +91,54 @@ private void flush() throws IOException {
[
https://issues.apache.org/jira/browse/LUCENE-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422633#comment-17422633
]
Uwe Schindler commented on LUCENE-10137:
IMHO, LongValues should be a functional interface from
romseygeek merged pull request #329:
URL: https://github.com/apache/lucene/pull/329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422625#comment-17422625
]
Uwe Schindler commented on LUCENE-10137:
I also changed the RuntimeException to the new
[
https://issues.apache.org/jira/browse/LUCENE-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422626#comment-17422626
]
Uwe Schindler commented on LUCENE-10137:
PR is here: https://github.com/apache/lucene/pull/335
uschindler opened a new pull request #335:
URL: https://github.com/apache/lucene/pull/335
See https://issues.apache.org/jira/browse/LUCENE-10137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Uwe Schindler created LUCENE-10137:
--
Summary: Refactor DirectReader and remove heavy code duplication
Key: LUCENE-10137
URL: https://issues.apache.org/jira/browse/LUCENE-10137
Project: Lucene - Core
uschindler commented on a change in pull request #327:
URL: https://github.com/apache/lucene/pull/327#discussion_r719166524
##
File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java
##
@@ -94,38 +91,54 @@ private void flush() throws IOException {
uschindler commented on a change in pull request #327:
URL: https://github.com/apache/lucene/pull/327#discussion_r719166524
##
File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java
##
@@ -94,38 +91,54 @@ private void flush() throws IOException {
dweiss commented on a change in pull request #334:
URL: https://github.com/apache/lucene/pull/334#discussion_r719145316
##
File path:
lucene/highlighter/src/java/org/apache/lucene/search/matchhighlight/PassageSelector.java
##
@@ -127,8 +127,8 @@ protected boolean
Dawid Weiss created LUCENE-10136:
Summary: Lift the restriction on using 'var' variables
Key: LUCENE-10136
URL: https://issues.apache.org/jira/browse/LUCENE-10136
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422577#comment-17422577
]
Adrien Grand commented on LUCENE-10113:
---
I suspect this change to be the source of the recent
uschindler commented on a change in pull request #327:
URL: https://github.com/apache/lucene/pull/327#discussion_r719130968
##
File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java
##
@@ -94,38 +91,54 @@ private void flush() throws IOException {
1 - 100 of 117 matches
Mail list logo
