[
https://issues.apache.org/jira/browse/LUCENE-10172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tommaso Teofili updated LUCENE-10172:
-
Fix Version/s: main (9.0)
> Minor code improvements to classification module
>
[
https://issues.apache.org/jira/browse/LUCENE-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428606#comment-17428606
]
Dawid Weiss commented on LUCENE-10173:
--
Looks great, thank Chris.
> remove "--max-workers 1"
[
https://issues.apache.org/jira/browse/LUCENE-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428549#comment-17428549
]
Haoyu Zhai commented on LUCENE-9839:
This same error appeared in my PR's auto check as well:
zhaih commented on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-942835409
Thanks @dweiss seems this is not the first time we see this error:
https://issues.apache.org/jira/browse/LUCENE-9839
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428547#comment-17428547
]
Chris M. Hostetter commented on LUCENE-9488:
{quote}Seems like I misunderstood the comments
[
https://issues.apache.org/jira/browse/LUCENE-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated LUCENE-10173:
Attachment: LUCENE-10173.patch
Status: Open (was: Open)
[~dawid.weiss]-
Chris M. Hostetter created LUCENE-10173:
---
Summary: remove "--max-workers 1" restriction when using external
GPG w/gradle build
Key: LUCENE-10173
URL: https://issues.apache.org/jira/browse/LUCENE-10173
[
https://issues.apache.org/jira/browse/LUCENE-10103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haoyu Zhai resolved LUCENE-10103.
-
Resolution: Fixed
> QueryCache not estimating query size properly
>
[
https://issues.apache.org/jira/browse/LUCENE-10103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428509#comment-17428509
]
ASF subversion and git services commented on LUCENE-10103:
--
Commit
mikemccand merged pull request #2591:
URL: https://github.com/apache/lucene-solr/pull/2591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428496#comment-17428496
]
Dawid Weiss commented on LUCENE-9488:
-
Seems like I misunderstood the comments you made in that help
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428494#comment-17428494
]
Jan Høydahl commented on LUCENE-9488:
-
I’ll try to make buildAndPushRelease.py and wizard
[
https://issues.apache.org/jira/browse/LUCENE-10103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428455#comment-17428455
]
Haoyu Zhai commented on LUCENE-10103:
-
Thank you [~mikemccand], I think we should backport since
jpountz commented on pull request #377:
URL: https://github.com/apache/lucene/pull/377#issuecomment-942621701
I'll merge this tomorrow if there are no objections so that I can more
easily move forward and look into other possible regressions.
--
This is an automated message from the
jpountz commented on a change in pull request #7:
URL: https://github.com/apache/lucene/pull/7#discussion_r728349433
##
File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java
##
@@ -318,20 +316,28 @@ private boolean collectNextLeaf() throws IOException {
tteofili opened a new pull request #381:
URL: https://github.com/apache/lucene/pull/381
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Please provide a short description of the approach taken
mikemccand merged pull request #346:
URL: https://github.com/apache/lucene/pull/346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dweiss commented on pull request #372:
URL: https://github.com/apache/lucene/pull/372#issuecomment-942106263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
janhoy merged pull request #355:
URL: https://github.com/apache/lucene/pull/355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zhaih commented on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-941199775
Hmmm one of the test failed
```
ERROR: The following test(s) have failed:
> Task :lucene:analysis:smartcn:test
-
janhoy commented on pull request #355:
URL: https://github.com/apache/lucene/pull/355#issuecomment-941797977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
cpoerschke commented on a change in pull request #355:
URL: https://github.com/apache/lucene/pull/355#discussion_r727204711
##
File path: dev-tools/scripts/smokeTestRelease.py
##
@@ -141,21 +146,19 @@ def checkJARMetaData(desc, jarFile, gitRevision, version):
raise
janhoy merged pull request #2590:
URL: https://github.com/apache/lucene-solr/pull/2590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dweiss commented on a change in pull request #372:
URL: https://github.com/apache/lucene/pull/372#discussion_r727758713
##
File path: lucene/distribution/build.gradle
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
magibney commented on pull request #208:
URL: https://github.com/apache/lucene/pull/208#issuecomment-941133721
Closing; see discussion at
[LUCENE-10023](https://issues.apache.org/jira/browse/LUCENE-10023).
Note: I may continue to update the PR branch.
--
This is an automated message
dweiss merged pull request #372:
URL: https://github.com/apache/lucene/pull/372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
iverase commented on a change in pull request #7:
URL: https://github.com/apache/lucene/pull/7#discussion_r727868879
##
File path:
lucene/test-framework/src/java/org/apache/lucene/index/AssertingLeafReader.java
##
@@ -1090,6 +1090,13 @@ private void assertStats(int maxDoc) {
magibney closed pull request #208:
URL: https://github.com/apache/lucene/pull/208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tommaso Teofili updated LUCENE-10172:
-
Description: Minor code improvements, mainly related to better usage of
lambdas and
iverase commented on pull request #7:
URL: https://github.com/apache/lucene/pull/7#issuecomment-942120304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
markrmiller commented on pull request #365:
URL: https://github.com/apache/lucene/pull/365#issuecomment-941999570
Yeah, unrelated to anything but the water cooler, another branch makes the
most sense, but I had unusual alterior motives to start using an
organization for a few things.
jtibshirani commented on pull request #366:
URL: https://github.com/apache/lucene/pull/366#issuecomment-941239181
@msokolov this is a good point, I will play around with this more and loop
back here.
--
This is an automated message from the Apache Git Service.
To respond to the message,
janhoy commented on a change in pull request #355:
URL: https://github.com/apache/lucene/pull/355#discussion_r727577690
##
File path: dev-tools/scripts/smokeTestRelease.py
##
@@ -141,21 +146,19 @@ def checkJARMetaData(desc, jarFile, gitRevision, version):
raise
janhoy commented on pull request #372:
URL: https://github.com/apache/lucene/pull/372#issuecomment-942078856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
janhoy commented on a change in pull request #372:
URL: https://github.com/apache/lucene/pull/372#discussion_r727570779
##
File path: lucene/distribution/build.gradle
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
dweiss commented on pull request #355:
URL: https://github.com/apache/lucene/pull/355#issuecomment-941984730
> I find bugs in the gradle build,
Please ping me if you do!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dweiss edited a comment on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-941302842
The stack trace is interesting though - looks like access to a closed reader
pool:
```
org.apache.lucene.index.TestIndexFileDeleter > testExcInDecRef FAILED
jpountz commented on a change in pull request #7:
URL: https://github.com/apache/lucene/pull/7#discussion_r727845012
##
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##
@@ -331,6 +450,9 @@ public long estimateDocCount(IntersectVisitor visitor) {
jpountz commented on pull request #7:
URL: https://github.com/apache/lucene/pull/7#issuecomment-942138814
+1 to making these implementations final
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dweiss commented on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-941302842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428351#comment-17428351
]
Chris M. Hostetter edited comment on LUCENE-9488 at 10/13/21, 5:15 PM:
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428351#comment-17428351
]
Chris M. Hostetter commented on LUCENE-9488:
{quote}It's because of the comment in
Tommaso Teofili created LUCENE-10172:
Summary: Minor code improvements to classification module
Key: LUCENE-10172
URL: https://issues.apache.org/jira/browse/LUCENE-10172
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-5548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tommaso Teofili resolved LUCENE-5548.
-
Resolution: Fixed
> Improve flexibility and testability of the classification module
>
spyk opened a new pull request #380:
URL: https://github.com/apache/lucene/pull/380
# Description
When providing a lemmas.txt dictionary file, OpenNLPLemmatizerFilterFactory
caches internally only the string format of the dictionary, and not the
DictionaryLemmatizer object. This
Spyros Kapnissis created LUCENE-10171:
-
Summary: Caching issue on dictionary-based
OpenNLPLemmatizerFilterFactory
Key: LUCENE-10171
URL: https://issues.apache.org/jira/browse/LUCENE-10171
[
https://issues.apache.org/jira/browse/LUCENE-10069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17404690#comment-17404690
]
Michael Sokolov edited comment on LUCENE-10069 at 10/13/21, 2:25 PM:
[
https://issues.apache.org/jira/browse/LUCENE-10103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428222#comment-17428222
]
Michael McCandless commented on LUCENE-10103:
-
Thanks [~zhai7631] – I just pushed the PR to
[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428220#comment-17428220
]
Jan Høydahl commented on LUCENE-9997:
-
[~rcmuir] Do you want to keep this Jira open for more
[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428215#comment-17428215
]
ASF subversion and git services commented on LUCENE-9997:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428216#comment-17428216
]
ASF subversion and git services commented on LUCENE-10107:
--
Commit
janhoy merged pull request #355:
URL: https://github.com/apache/lucene/pull/355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy commented on pull request #355:
URL: https://github.com/apache/lucene/pull/355#issuecomment-942298139
I intend to merge what we have so far, and then let others submit smaller
followup PRs.
With the recent build improvements in #372 and the cleanup in wizard from
#344, and
[
https://issues.apache.org/jira/browse/LUCENE-10103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428204#comment-17428204
]
ASF subversion and git services commented on LUCENE-10103:
--
Commit
mikemccand merged pull request #346:
URL: https://github.com/apache/lucene/pull/346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
iverase commented on pull request #7:
URL: https://github.com/apache/lucene/pull/7#issuecomment-94003
I made the implementations final. I think we need some thought on:
* `AssertingIntersectVisitor` as it was built in a world where it would only
be used for Intersects.
*
iverase commented on a change in pull request #7:
URL: https://github.com/apache/lucene/pull/7#discussion_r727977619
##
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##
@@ -331,6 +450,9 @@ public long estimateDocCount(IntersectVisitor visitor) {
jpountz commented on pull request #7:
URL: https://github.com/apache/lucene/pull/7#issuecomment-942138814
+1 to making these implementations final
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jpountz commented on a change in pull request #7:
URL: https://github.com/apache/lucene/pull/7#discussion_r727905294
##
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##
@@ -331,6 +450,9 @@ public long estimateDocCount(IntersectVisitor visitor) {
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428118#comment-17428118
]
Jan Høydahl commented on LUCENE-9488:
-
Thanks a lot Dawid, Mike, Uwe, Hoss for this last non-trivial
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428116#comment-17428116
]
ASF subversion and git services commented on LUCENE-9488:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9488.
-
Fix Version/s: main (9.0)
Resolution: Fixed
> Update release process to work with
dweiss commented on pull request #372:
URL: https://github.com/apache/lucene/pull/372#issuecomment-942125808
Thanks, Jan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dweiss merged pull request #372:
URL: https://github.com/apache/lucene/pull/372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
iverase commented on pull request #7:
URL: https://github.com/apache/lucene/pull/7#issuecomment-942120304
>> If I understand correctly, you're introducing the new API but not
removing the old one, just giving it a default implementation based on the new
API?
Yes, I still think the
janhoy commented on pull request #372:
URL: https://github.com/apache/lucene/pull/372#issuecomment-942118171
> I think you could provide the default in the python script.
The script can check a few common locations. If a user has a non-standard
location, we can ask the RM to
iverase commented on a change in pull request #7:
URL: https://github.com/apache/lucene/pull/7#discussion_r727882079
##
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##
@@ -331,6 +450,9 @@ public long estimateDocCount(IntersectVisitor visitor) {
iverase commented on a change in pull request #7:
URL: https://github.com/apache/lucene/pull/7#discussion_r727874074
##
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##
@@ -227,8 +228,56 @@ protected PointValues() {}
CELL_CROSSES_QUERY
};
+
dweiss commented on pull request #372:
URL: https://github.com/apache/lucene/pull/372#issuecomment-942106263
> Is there a default ENV.VAR I could have used in place of this?
You can set project properties (-P) with environment variables, this is an
unrelated Gradle feature, see
iverase commented on a change in pull request #7:
URL: https://github.com/apache/lucene/pull/7#discussion_r727870901
##
File path:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java
##
@@ -372,6 +372,12 @@ private void checkAndThrow() {
}
}
iverase commented on a change in pull request #7:
URL: https://github.com/apache/lucene/pull/7#discussion_r727868879
##
File path:
lucene/test-framework/src/java/org/apache/lucene/index/AssertingLeafReader.java
##
@@ -1090,6 +1090,13 @@ private void assertStats(int maxDoc) {
janhoy commented on a change in pull request #355:
URL: https://github.com/apache/lucene/pull/355#discussion_r727854794
##
File path: lucene/demo/src/java/org/apache/lucene/demo/IndexFiles.java
##
@@ -175,7 +175,7 @@ public static void main(String[] args) throws Exception {
jpountz commented on a change in pull request #7:
URL: https://github.com/apache/lucene/pull/7#discussion_r727845012
##
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##
@@ -331,6 +450,9 @@ public long estimateDocCount(IntersectVisitor visitor) {
janhoy commented on pull request #372:
URL: https://github.com/apache/lucene/pull/372#issuecomment-942078856
I am now able to run the smoke tester on the freshly built artifacts, and it
validates checksums, unpacks, runs demo indexer etc.
Currently it is complaining about the src
janhoy commented on a change in pull request #372:
URL: https://github.com/apache/lucene/pull/372#discussion_r727840200
##
File path: lucene/distribution/binary-release.gradle
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
janhoy commented on a change in pull request #372:
URL: https://github.com/apache/lucene/pull/372#discussion_r727839901
##
File path: lucene/distribution/build.gradle
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
[
https://issues.apache.org/jira/browse/LUCENE-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428077#comment-17428077
]
Adrien Grand commented on LUCENE-10170:
---
I attached a pull request that gets compression speed to
mrkm4ntr opened a new pull request #378:
URL: https://github.com/apache/lucene/pull/378
In commit method, mgr is already used without null check before this null
check.
# Description
Please provide a short description of the changes you're making with this
pull
jpountz opened a new pull request #377:
URL: https://github.com/apache/lucene/pull/377
A slowdown had been introduced in LUCENE-7521.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Adrien Grand created LUCENE-10170:
-
Summary: Regression in stored fields compression in 9.0
Key: LUCENE-10170
URL: https://issues.apache.org/jira/browse/LUCENE-10170
Project: Lucene - Core
dweiss commented on a change in pull request #372:
URL: https://github.com/apache/lucene/pull/372#discussion_r727789350
##
File path: lucene/distribution/binary-release.gradle
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
markrmiller commented on pull request #365:
URL: https://github.com/apache/lucene/pull/365#issuecomment-941999570
Yeah, unrelated to anything but the water cooler, another branch makes the
most sense, but I had unusual alterior motives to start using an
organization for a few things.
janhoy commented on pull request #355:
URL: https://github.com/apache/lucene/pull/355#issuecomment-941990831
> Please ping me if you do!
Ping https://github.com/apache/lucene/pull/372#discussion_r727608870
--
This is an automated message from the Apache Git Service.
To respond to
dweiss commented on a change in pull request #372:
URL: https://github.com/apache/lucene/pull/372#discussion_r727758713
##
File path: lucene/distribution/build.gradle
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
dweiss commented on pull request #355:
URL: https://github.com/apache/lucene/pull/355#issuecomment-941984730
> I find bugs in the gradle build,
Please ping me if you do!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428043#comment-17428043
]
Dawid Weiss commented on LUCENE-9488:
-
[~janhoy] Can I merge this in? Have you had a chance to take
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428039#comment-17428039
]
Dawid Weiss commented on LUCENE-9488:
-
{quote}although i have no idea why it says you need
87 matches
Mail list logo
