dweiss commented on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1004564639
I've been wondering what to do with the security manager. If we're on Java
17, where it's officially deprecated, perhaps we should just get rid of it? I
know it sounds terrible
mdmarshmallow commented on a change in pull request #509:
URL: https://github.com/apache/lucene/pull/509#discussion_r776104278
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -471,19 +471,24 @@ private void indexDrillDownTerms(
private
zacharymorn commented on a change in pull request #534:
URL: https://github.com/apache/lucene/pull/534#discussion_r777817835
##
File path: lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java
##
@@ -107,7 +110,36 @@ private void mergeVectors(FieldInfo
tobijdc commented on a change in pull request #439:
URL: https://github.com/apache/lucene/pull/439#discussion_r50326
##
File path: lucene/codecs/build.gradle
##
@@ -20,6 +20,9 @@ apply plugin: 'java-library'
description = 'Lucene codecs and postings formats'
uschindler commented on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1004352202
> Now it's forbidden apis complaining about deprecated security manager
methods, it seems.
I think we will need to also add SuppressForbidden. The difference here is
dweiss commented on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1004342318
Now it's forbidden apis complaining about deprecated security manager
methods, it seems.
--
This is an automated message from the Apache Git Service.
To respond to the message,
dweiss commented on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1004338486
Sorry - it's ecj.
```
Task :lucene:backward-codecs:ecjLintMain FAILED
source level should be in '1.1'...'1.8','9'...'16' (or '5.0'..'16.0'): 17
```
--
This is an
dweiss commented on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1004333645
> It looks like the github actions are not used for current PR, so we have
to ignore the failures.
I think they are used, it's a different problem - this time spotless can't
dweiss commented on a change in pull request #579:
URL: https://github.com/apache/lucene/pull/579#discussion_r777683665
##
File path:
lucene/core/src/java/org/apache/lucene/util/fst/PositiveIntOutputs.java
##
@@ -17,22 +17,19 @@
package org.apache.lucene.util.fst;
import
[
https://issues.apache.org/jira/browse/LUCENE-10347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468186#comment-17468186
]
ASF subversion and git services commented on LUCENE-10347:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468185#comment-17468185
]
ASF subversion and git services commented on LUCENE-10347:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-10347.
--
Fix Version/s: 9.1
Resolution: Fixed
Done.
> Add helper task to collect binary
jtibshirani commented on a change in pull request #580:
URL: https://github.com/apache/lucene/pull/580#discussion_r777682465
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java
##
@@ -239,6 +239,9 @@ public TopDocs search(String
dweiss merged pull request #576:
URL: https://github.com/apache/lucene/pull/576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jpountz commented on a change in pull request #580:
URL: https://github.com/apache/lucene/pull/580#discussion_r777679243
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java
##
@@ -239,6 +239,9 @@ public TopDocs search(String
[
https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468175#comment-17468175
]
Adrien Grand commented on LUCENE-8739:
--
I may have found the issue, your codec was using the same
jtibshirani commented on a change in pull request #580:
URL: https://github.com/apache/lucene/pull/580#discussion_r777676777
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java
##
@@ -239,6 +239,9 @@ public TopDocs search(String
jpountz commented on a change in pull request #439:
URL: https://github.com/apache/lucene/pull/439#discussion_r777675004
##
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/customcompression/ZstdDictCompressionMode.java
##
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the
uschindler commented on pull request #581:
URL: https://github.com/apache/lucene/pull/581#issuecomment-1004283996
FYI, I will add a real test later when @dweiss fixed the module tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
uschindler commented on pull request #581:
URL: https://github.com/apache/lucene/pull/581#issuecomment-1004282413
@rmuir I will move the TestAllAnalyzerHaveFactories test to the same
"TestDistribution" in a separate issue. The current test only works with Common
Analyzers. Basically it
uschindler commented on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1004276710
It looks like the github actions are not used for current PR, so we have to
ignore the failures.
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468137#comment-17468137
]
Adrien Grand commented on LUCENE-8739:
--
I ran the same benchmark over the above PR with the
[
https://issues.apache.org/jira/browse/LUCENE-10348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468132#comment-17468132
]
Uwe Schindler commented on LUCENE-10348:
I opened a PR:
uschindler opened a new pull request #581:
URL: https://github.com/apache/lucene/pull/581
See: https://issues.apache.org/jira/browse/LUCENE-10348
For now I made the distribution test assert is all analysis modules open up
all packages to lucene core if they contain at least one of
uschindler commented on a change in pull request #579:
URL: https://github.com/apache/lucene/pull/579#discussion_r777620883
##
File path:
lucene/core/src/java/org/apache/lucene/util/fst/PositiveIntOutputs.java
##
@@ -17,22 +17,19 @@
package org.apache.lucene.util.fst;
jpountz commented on pull request #573:
URL: https://github.com/apache/lucene/pull/573#issuecomment-1004240719
Looking at the comment, I suspect that this is a misinterpretation of the
fact that Random#nextLong only uses 48 bits of randomness.
--
This is an automated message from the
jpountz commented on a change in pull request #579:
URL: https://github.com/apache/lucene/pull/579#discussion_r777604382
##
File path:
lucene/core/src/java/org/apache/lucene/util/fst/PositiveIntOutputs.java
##
@@ -17,22 +17,19 @@
package org.apache.lucene.util.fst;
import
jpountz commented on a change in pull request #464:
URL: https://github.com/apache/lucene/pull/464#discussion_r777592617
##
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/memory/DirectDocValuesConsumer.java
##
@@ -0,0 +1,980 @@
+/*
+ * Licensed to the Apache
uschindler commented on a change in pull request #579:
URL: https://github.com/apache/lucene/pull/579#discussion_r777599019
##
File path:
lucene/core/src/java/org/apache/lucene/util/fst/PositiveIntOutputs.java
##
@@ -17,22 +17,19 @@
package org.apache.lucene.util.fst;
jpountz commented on a change in pull request #579:
URL: https://github.com/apache/lucene/pull/579#discussion_r777585290
##
File path:
lucene/core/src/java/org/apache/lucene/util/fst/PositiveIntOutputs.java
##
@@ -31,7 +31,7 @@
public final class PositiveIntOutputs extends
jpountz commented on a change in pull request #579:
URL: https://github.com/apache/lucene/pull/579#discussion_r777582754
##
File path:
lucene/core/src/java/org/apache/lucene/util/fst/PositiveIntOutputs.java
##
@@ -31,7 +31,7 @@
public final class PositiveIntOutputs extends
jpountz commented on a change in pull request #579:
URL: https://github.com/apache/lucene/pull/579#discussion_r777575778
##
File path: lucene/core/src/java/org/apache/lucene/util/RamUsageEstimator.java
##
@@ -584,9 +584,10 @@ public static long shallowSizeOfInstance(Class
jpountz commented on pull request #578:
URL: https://github.com/apache/lucene/pull/578#issuecomment-1004190432
@gsmiller I suspect you'd like to have a look at this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
uschindler commented on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1004188776
I gave some comments; the deprecated Long ctor should be fixed, so we
should open a separate issue. I'd suggest to switch over to Optional instead of
a plain Long to signal
uschindler commented on a change in pull request #579:
URL: https://github.com/apache/lucene/pull/579#discussion_r777558321
##
File path:
lucene/misc/src/java/org/apache/lucene/misc/util/fst/UpToTwoPositiveIntOutputs.java
##
@@ -77,7 +77,7 @@ public int hashCode() {
}
gf2121 edited a comment on pull request #578:
URL: https://github.com/apache/lucene/pull/578#issuecomment-1004181952
Anyway, I believe removing the abstraction layer is a good idea so i have
fixed it. The codes in SSDV should be another issue :)
--
This is an automated message from the
gf2121 commented on pull request #578:
URL: https://github.com/apache/lucene/pull/578#issuecomment-1004181952
Anyway, I believe remove the abstraction layer should be a good idea so i
have fixed it. The codes in SSDV should be another issue :)
--
This is an automated message from the
dweiss commented on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1004179827
Update the min. JVM for github actions .github/workflows, Adrien. Otherwise
LGTM.
```
# Test JVMs.
java: [ '11' ]
```
--
This is an automated
uschindler commented on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1004178652
I think you also have to change the github actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
gf2121 commented on pull request #578:
URL: https://github.com/apache/lucene/pull/578#issuecomment-1004175668
Thanks @jpountz for so quick reply! I'm using these codes since we are using
the similar codes in [SSDV
mayya-sharipova opened a new pull request #580:
URL: https://github.com/apache/lucene/pull/580
Current when doing knn search on an segment where all documents
with knn field were deleted, we get the following error:
maxSize must be > 0 and < 2147483630; got: 0
Mayya Sharipova created LUCENE-10351:
Summary: Correct knn search failure with all deleted docs
Key: LUCENE-10351
URL: https://issues.apache.org/jira/browse/LUCENE-10351
Project: Lucene - Core
gf2121 closed pull request #578:
URL: https://github.com/apache/lucene/pull/578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gf2121 opened a new pull request #578:
URL: https://github.com/apache/lucene/pull/578
I find that `org.apache.lucene.facet.taxonomy.IntTaxonomyFacets#increment()`
is using about 2% cpu of luceneutil, this could probably be replaced with
`values[doc]++` since `#countAll` will never use
Feng Guo created LUCENE-10350:
-
Summary: Avoid some null checking for
FastTaxonomyFacetCounts#countAll()
Key: LUCENE-10350
URL: https://issues.apache.org/jira/browse/LUCENE-10350
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-10345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468029#comment-17468029
]
Adrien Grand commented on LUCENE-10345:
---
+1
> remove non-NRT replication support
>
[
https://issues.apache.org/jira/browse/LUCENE-10346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468009#comment-17468009
]
ASF subversion and git services commented on LUCENE-10346:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-10349.
Resolution: Fixed
> Cleanup WordListLoader to use try-with-resources and make the
[
https://issues.apache.org/jira/browse/LUCENE-10349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468004#comment-17468004
]
ASF subversion and git services commented on LUCENE-10349:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468002#comment-17468002
]
ASF subversion and git services commented on LUCENE-10349:
--
Commit
uschindler merged pull request #577:
URL: https://github.com/apache/lucene/pull/577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467999#comment-17467999
]
ASF subversion and git services commented on LUCENE-10346:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-10287.
Resolution: Won't Fix
We have now a warning and we won't rely on the module to be
[
https://issues.apache.org/jira/browse/LUCENE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler reopened LUCENE-10287:
Reopen to close as won't fix
> Add jdk.unsupported module to Luke startup script
>
[
https://issues.apache.org/jira/browse/LUCENE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10287:
---
Fix Version/s: (was: 9.1)
(was: 10.0 (main))
> Add
[
https://issues.apache.org/jira/browse/LUCENE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467996#comment-17467996
]
ASF subversion and git services commented on LUCENE-10287:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467992#comment-17467992
]
ASF subversion and git services commented on LUCENE-10287:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467987#comment-17467987
]
ASF subversion and git services commented on LUCENE-10346:
--
Commit
jpountz merged pull request #574:
URL: https://github.com/apache/lucene/pull/574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jpountz commented on a change in pull request #534:
URL: https://github.com/apache/lucene/pull/534#discussion_r777482319
##
File path: lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java
##
@@ -107,7 +110,36 @@ private void mergeVectors(FieldInfo
[
https://issues.apache.org/jira/browse/LUCENE-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved LUCENE-10252.
---
Fix Version/s: 9.1
Resolution: Fixed
> ValueSource.asDoubleValues shouldn't fetch
[
https://issues.apache.org/jira/browse/LUCENE-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467981#comment-17467981
]
ASF subversion and git services commented on LUCENE-10252:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467982#comment-17467982
]
ASF subversion and git services commented on LUCENE-8099:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467978#comment-17467978
]
ASF subversion and git services commented on LUCENE-10252:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467979#comment-17467979
]
ASF subversion and git services commented on LUCENE-8099:
-
Commit
dsmiley merged pull request #519:
URL: https://github.com/apache/lucene/pull/519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy merged pull request #2635:
URL: https://github.com/apache/lucene-solr/pull/2635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10349:
---
Fix Version/s: 9.1
10.0 (main)
> Cleanup WordListLoader to use
[
https://issues.apache.org/jira/browse/LUCENE-10349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467965#comment-17467965
]
Uwe Schindler commented on LUCENE-10349:
PR: https://github.com/apache/lucene/pull/577
>
uschindler opened a new pull request #577:
URL: https://github.com/apache/lucene/pull/577
See: https://issues.apache.org/jira/browse/LUCENE-10349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Uwe Schindler created LUCENE-10349:
--
Summary: Cleanup WordListLoader to use try-with-resources and make
the default stop words unmodifiable
Key: LUCENE-10349
URL:
[
https://issues.apache.org/jira/browse/LUCENE-10348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467940#comment-17467940
]
Uwe Schindler commented on LUCENE-10348:
Another option for analysis factories would be to
[
https://issues.apache.org/jira/browse/LUCENE-10348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467937#comment-17467937
]
Uwe Schindler commented on LUCENE-10348:
Generally this is not meant as a undo of LUCENE-10348
[
https://issues.apache.org/jira/browse/LUCENE-10348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467934#comment-17467934
]
Uwe Schindler commented on LUCENE-10348:
Another option would be to place all stopwords files
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467932#comment-17467932
]
Uwe Schindler commented on LUCENE-10335:
See followup: LUCENE-10348
>
[
https://issues.apache.org/jira/browse/LUCENE-10348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467931#comment-17467931
]
Uwe Schindler commented on LUCENE-10348:
Basically we think that hiding resources files is bad
[
https://issues.apache.org/jira/browse/LUCENE-10348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10348:
---
Description:
This is a followup after LUCENE-10335:
In LUCENE-10335 we fixed all
Uwe Schindler created LUCENE-10348:
--
Summary: Make stopwords resources from analyzers modules visible
to ClasspathResourceLoader and ModuleResourceLoader
Key: LUCENE-10348
URL:
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-10335.
Fix Version/s: 9.1
10.0 (main)
Assignee: Uwe Schindler
uschindler commented on pull request #571:
URL: https://github.com/apache/lucene/pull/571#issuecomment-1004003443
Fixed warning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467898#comment-17467898
]
ASF subversion and git services commented on LUCENE-10335:
--
Commit
uschindler commented on pull request #567:
URL: https://github.com/apache/lucene/pull/567#issuecomment-1004002079
I fixed the warning in main by a fake "package-info.java"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467895#comment-17467895
]
ASF subversion and git services commented on LUCENE-10335:
--
Commit
janhoy opened a new pull request #2635:
URL: https://github.com/apache/lucene-solr/pull/2635
https://issues.apache.org/jira/browse/SOLR-15871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
uschindler edited a comment on pull request #571:
URL: https://github.com/apache/lucene/pull/571#issuecomment-1003993255
There is now a warning by ECJ, but does not fail build. I will fix this in
main, sorry.
--
This is an automated message from the Apache Git Service.
To respond to the
uschindler removed a comment on pull request #571:
URL: https://github.com/apache/lucene/pull/571#issuecomment-1003988012
> Hi @dweiss, I merged main and reverted some changes in this PR that were
solved differently than in other branch.
>
> The only thing that fails now:
>
>
uschindler edited a comment on pull request #571:
URL: https://github.com/apache/lucene/pull/571#issuecomment-1003987282
Hi @dweiss,
I merged main and reverted some changes in this PR that were solved
differently than in other branch #567.
--
This is an automated message from
uschindler commented on pull request #567:
URL: https://github.com/apache/lucene/pull/567#issuecomment-1003994470
```
> Task :lucene:core.tests:ecjLintTest
--
1. WARNING in C:\Users\Uwe
Schindler\Projects\lucene\lucene\lucene\core.tests\src\test\module-info.java
(at line
uschindler commented on pull request #571:
URL: https://github.com/apache/lucene/pull/571#issuecomment-1003993740
Sorry, github was too slow and I accidentally pressed button twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
uschindler closed pull request #571:
URL: https://github.com/apache/lucene/pull/571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
uschindler commented on pull request #571:
URL: https://github.com/apache/lucene/pull/571#issuecomment-1003993255
This is a warning only, doe snot fail build. This is why github actions do
not fail. We should maybe suppress this warning in ECJ. It's unrelated.
--
This is an automated
uschindler commented on pull request #567:
URL: https://github.com/apache/lucene/pull/567#issuecomment-1003992860
Hm, now on main this causes an ECJ warning But it does not fail build.
That's ok for now.
--
This is an automated message from the Apache Git Service.
To respond to the
uschindler edited a comment on pull request #571:
URL: https://github.com/apache/lucene/pull/571#issuecomment-1003987282
Hi @dweiss,
I merged main and reverted some changes in this PR that were solved
differently than in other branch #567.
The only thing that fails now:
```
uschindler commented on pull request #571:
URL: https://github.com/apache/lucene/pull/571#issuecomment-1003988012
> Hi @dweiss, I merged main and reverted some changes in this PR that were
solved differently than in other branch.
>
> The only thing that fails now:
>
> ```
uschindler edited a comment on pull request #571:
URL: https://github.com/apache/lucene/pull/571#issuecomment-1003987282
Hi @dweiss,
I merged main and reverted some changes in this PR that were solved
differently than in other branch.
The only thing that fails now:
```
1.
uschindler commented on pull request #571:
URL: https://github.com/apache/lucene/pull/571#issuecomment-1003987282
Hi @dweiss,
I merged main and reverted some changes in this PR that were solved
differently than in other branch.
The only thing that fails now:
```
1. WARNING
dweiss commented on pull request #567:
URL: https://github.com/apache/lucene/pull/567#issuecomment-1003985138
No worries, thanks Uwe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
uschindler commented on pull request #567:
URL: https://github.com/apache/lucene/pull/567#issuecomment-1003984470
Oh sorry, I fixed it already. You can revert if you like, but looks well now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dweiss commented on pull request #567:
URL: https://github.com/apache/lucene/pull/567#issuecomment-1003974227
No, please don't - I'll do it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
uschindler commented on pull request #567:
URL: https://github.com/apache/lucene/pull/567#issuecomment-1003971837
Hi @dweiss: I will merge in the changes to your branch, as this is a bit
more complicated (I also need to revert some changes on your branch)
--
This is an automated message
1 - 100 of 105 matches
Mail list logo
