[GitHub] [lucene] iverase commented on a change in pull request #658: LUCENE-10378 Implement Weight#count for PointRangeQuery

2022-02-10 Thread GitBox
iverase commented on a change in pull request #658: URL: https://github.com/apache/lucene/pull/658#discussion_r804415672 ## File path: lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java ## @@ -369,6 +378,100 @@ public Scorer scorer(LeafReaderContext context)

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490698#comment-17490698 ] Dawid Weiss commented on LUCENE-10419: -- {code:java} Unhandled exception while validating patterns

[GitHub] [lucene] mocobeta commented on pull request #674: trivial updates on github actions

2022-02-10 Thread GitBox
mocobeta commented on pull request #674: URL: https://github.com/apache/lucene/pull/674#issuecomment-1035913042 I am not sure if randomizing the distribution per test run is possible without forking the setup-java action, but I think a matrix test may be easy (if it makes sense to run

[jira] [Commented] (LUCENE-10176) Remove VectorValues#size()

2022-02-10 Thread spike liu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490671#comment-17490671 ] spike liu commented on LUCENE-10176: https://github.com/apache/lucene/pull/676 > Remove

[GitHub] [lucene] spike-liu opened a new pull request #676: Lucene-10176: Remove VectorValues#size()

2022-02-10 Thread GitBox
spike-liu opened a new pull request #676: URL: https://github.com/apache/lucene/pull/676 https://issues.apache.org/jira/browse/LUCENE-10176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (LUCENE-10176) Remove VectorValues#size()

2022-02-10 Thread spike liu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490670#comment-17490670 ] spike liu commented on LUCENE-10176: I would like to work on this. > Remove VectorValues#size() >

[GitHub] [lucene] jtibshirani commented on pull request #649: LUCENE-10408 Better encoding of doc Ids in vectors

2022-02-10 Thread GitBox
jtibshirani commented on pull request #649: URL: https://github.com/apache/lucene/pull/649#issuecomment-1035648183 Additional motivation for this PR: it could help with performance of exact search (in https://github.com/apache/lucene/pull/656). When all docs have vectors, we can avoid a

[GitHub] [lucene] jtibshirani commented on a change in pull request #649: LUCENE-10408 Better encoding of doc Ids in vectors

2022-02-10 Thread GitBox
jtibshirani commented on a change in pull request #649: URL: https://github.com/apache/lucene/pull/649#discussion_r804189512 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsWriter.java ## @@ -138,9 +140,20 @@ public void

[GitHub] [lucene] gautamworah96 commented on a change in pull request #658: LUCENE-10378 Implement Weight#count for PointRangeQuery

2022-02-10 Thread GitBox
gautamworah96 commented on a change in pull request #658: URL: https://github.com/apache/lucene/pull/658#discussion_r804116906 ## File path: lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java ## @@ -369,6 +378,100 @@ public Scorer scorer(LeafReaderContext

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #656: LUCENE-10382: Support filtering in KnnVectorQuery

2022-02-10 Thread GitBox
mayya-sharipova commented on a change in pull request #656: URL: https://github.com/apache/lucene/pull/656#discussion_r804028845 ## File path: lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java ## @@ -96,43 +107,98 @@ public Query rewrite(IndexReader reader)

[GitHub] [lucene] jtibshirani commented on a change in pull request #656: LUCENE-10382: Support filtering in KnnVectorQuery

2022-02-10 Thread GitBox
jtibshirani commented on a change in pull request #656: URL: https://github.com/apache/lucene/pull/656#discussion_r804009517 ## File path: lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java ## @@ -70,18 +118,104 @@ public Query rewrite(IndexReader reader) throws

[GitHub] [lucene] jtibshirani commented on a change in pull request #656: LUCENE-10382: Support filtering in KnnVectorQuery

2022-02-10 Thread GitBox
jtibshirani commented on a change in pull request #656: URL: https://github.com/apache/lucene/pull/656#discussion_r803965732 ## File path: lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java ## @@ -96,43 +107,98 @@ public Query rewrite(IndexReader reader) throws

[GitHub] [lucene] jtibshirani commented on a change in pull request #656: LUCENE-10382: Support filtering in KnnVectorQuery

2022-02-10 Thread GitBox
jtibshirani commented on a change in pull request #656: URL: https://github.com/apache/lucene/pull/656#discussion_r803950304 ## File path: lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java ## @@ -96,43 +107,98 @@ public Query rewrite(IndexReader reader) throws

[GitHub] [lucene] jtibshirani commented on a change in pull request #656: LUCENE-10382: Support filtering in KnnVectorQuery

2022-02-10 Thread GitBox
jtibshirani commented on a change in pull request #656: URL: https://github.com/apache/lucene/pull/656#discussion_r803937272 ## File path: lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java ## @@ -96,43 +107,98 @@ public Query rewrite(IndexReader reader) throws

[GitHub] [lucene] jpountz commented on a change in pull request #672: LUCENE-10418: Optimize `Query#rewrite` in the non-scoring case.

2022-02-10 Thread GitBox
jpountz commented on a change in pull request #672: URL: https://github.com/apache/lucene/pull/672#discussion_r803887266 ## File path: lucene/core/src/java/org/apache/lucene/search/ConstantScoreQuery.java ## @@ -114,7 +124,19 @@ public long cost() { @Override public

[GitHub] [lucene] jpountz commented on a change in pull request #672: LUCENE-10418: Optimize `Query#rewrite` in the non-scoring case.

2022-02-10 Thread GitBox
jpountz commented on a change in pull request #672: URL: https://github.com/apache/lucene/pull/672#discussion_r803883301 ## File path: lucene/core/src/java/org/apache/lucene/search/ConstantScoreQuery.java ## @@ -63,6 +65,22 @@ public Query rewrite(IndexReader reader) throws

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490372#comment-17490372 ] ASF subversion and git services commented on LUCENE-10419: -- Commit

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490365#comment-17490365 ] Dawid Weiss commented on LUCENE-10419: -- I did take a look at rat's source code. It looks like a

[GitHub] [lucene] mocobeta closed pull request #671: Add custom composite action to set up CI environments

2022-02-10 Thread GitBox
mocobeta closed pull request #671: URL: https://github.com/apache/lucene/pull/671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] mocobeta commented on pull request #671: Add custom composite action to set up CI environments

2022-02-10 Thread GitBox
mocobeta commented on pull request #671: URL: https://github.com/apache/lucene/pull/671#issuecomment-1035126874 I'm closing this. I think we'd need more complex or fully scratched custom actions not to duplicate the JDK set-up across workflows. -- This is an automated message from the

[GitHub] [lucene] dweiss commented on pull request #674: trivial updates on github actions

2022-02-10 Thread GitBox
dweiss commented on pull request #674: URL: https://github.com/apache/lucene/pull/674#issuecomment-1035112715 I think these actions are javascript, basically. I've never written one myself, so can't help. Don't worry about it, it was just a wild idea - we have lots of randomization

[GitHub] [lucene] mocobeta merged pull request #674: trivial updates on github actions

2022-02-10 Thread GitBox
mocobeta merged pull request #674: URL: https://github.com/apache/lucene/pull/674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] mocobeta commented on pull request #674: trivial updates on github actions

2022-02-10 Thread GitBox
mocobeta commented on pull request #674: URL: https://github.com/apache/lucene/pull/674#issuecomment-1035107842 Thank you, I will merge this soon. > It'd be interesting to randomize those distributions using a custom action, perhaps? I have no experience here whatsoever, but I bet

[GitHub] [lucene] jpountz merged pull request #675: LUCENE-10385: Avoid SimpleText codec in TestIndexSortSortedNumericDocValuesRangeQuery

2022-02-10 Thread GitBox
jpountz merged pull request #675: URL: https://github.com/apache/lucene/pull/675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] javanna opened a new pull request #675: LUCENE-10385: Avoid SimpleText codec in TestIndexSortSortedNumericDocValuesRangeQuery

2022-02-10 Thread GitBox
javanna opened a new pull request #675: URL: https://github.com/apache/lucene/pull/675 The recently introduced testCount (added with LUCENE-10385) verifies that the Weight#count optimization kicks in. When SimpleText codec is used, `DocValues#unwrapSingleton` returns null which disables

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #656: LUCENE-10382: Support filtering in KnnVectorQuery

2022-02-10 Thread GitBox
mayya-sharipova commented on a change in pull request #656: URL: https://github.com/apache/lucene/pull/656#discussion_r803804328 ## File path: lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java ## @@ -96,43 +107,98 @@ public Query rewrite(IndexReader reader)

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #656: LUCENE-10382: Support filtering in KnnVectorQuery

2022-02-10 Thread GitBox
mayya-sharipova commented on a change in pull request #656: URL: https://github.com/apache/lucene/pull/656#discussion_r803804328 ## File path: lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java ## @@ -96,43 +107,98 @@ public Query rewrite(IndexReader reader)

[GitHub] [lucene] dweiss commented on pull request #674: trivial updates on github actions

2022-02-10 Thread GitBox
dweiss commented on pull request #674: URL: https://github.com/apache/lucene/pull/674#issuecomment-1035046672 It'd be interesting to randomize those distributions using a custom action, perhaps? I have no experience here whatsoever, but I bet it's possible... -- This is an automated

[GitHub] [lucene] mocobeta commented on pull request #674: trivial updates on github actions

2022-02-10 Thread GitBox
mocobeta commented on pull request #674: URL: https://github.com/apache/lucene/pull/674#issuecomment-1035042297 Do you have a minute to take a look? @dweiss -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] mocobeta opened a new pull request #674: trivial updates on github actions

2022-02-10 Thread GitBox
mocobeta opened a new pull request #674: URL: https://github.com/apache/lucene/pull/674 - upgrade actions/setup-java to v2 in the hunspell regression workflow (aligned with the main workflow) - migrate the distribution to 'temurin' ([supported

[GitHub] [lucene] rmuir commented on a change in pull request #672: LUCENE-10418: Optimize `Query#rewrite` in the non-scoring case.

2022-02-10 Thread GitBox
rmuir commented on a change in pull request #672: URL: https://github.com/apache/lucene/pull/672#discussion_r803745240 ## File path: lucene/core/src/java/org/apache/lucene/search/ConstantScoreQuery.java ## @@ -63,6 +65,22 @@ public Query rewrite(IndexReader reader) throws

[GitHub] [lucene] msokolov commented on a change in pull request #672: LUCENE-10418: Optimize `Query#rewrite` in the non-scoring case.

2022-02-10 Thread GitBox
msokolov commented on a change in pull request #672: URL: https://github.com/apache/lucene/pull/672#discussion_r803701669 ## File path: lucene/core/src/java/org/apache/lucene/search/BooleanQuery.java ## @@ -191,51 +191,55 @@ boolean isPureDisjunction() { return

[GitHub] [lucene] mocobeta commented on pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

2022-02-10 Thread GitBox
mocobeta commented on pull request #673: URL: https://github.com/apache/lucene/pull/673#issuecomment-1034956590 Thanks @msokolov for taking a look. I will keep this open for a day or two, then merge it if there is no disapproval. -- This is an automated message from the Apache Git

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490270#comment-17490270 ] Dawid Weiss commented on LUCENE-10419: -- I do log the path - see the bottom of that quote. I don't

[GitHub] [lucene] mocobeta commented on a change in pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

2022-02-10 Thread GitBox
mocobeta commented on a change in pull request #673: URL: https://github.com/apache/lucene/pull/673#discussion_r803700144 ## File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java ## @@ -521,22 +523,11 @@ public static void fsync(Path fileToSync, boolean isDir)

[GitHub] [lucene] msokolov commented on a change in pull request #656: LUCENE-10382: Support filtering in KnnVectorQuery

2022-02-10 Thread GitBox
msokolov commented on a change in pull request #656: URL: https://github.com/apache/lucene/pull/656#discussion_r803668310 ## File path: lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java ## @@ -76,17 +81,23 @@ public KnnVectorQuery(String field, float[] target,

[GitHub] [lucene] mikemccand commented on a change in pull request #630: LUCENE-10371 Make IndexRearranger able to arrange segment in a determined order

2022-02-10 Thread GitBox
mikemccand commented on a change in pull request #630: URL: https://github.com/apache/lucene/pull/630#discussion_r803674222 ## File path: lucene/misc/src/java/org/apache/lucene/misc/index/IndexRearranger.java ## @@ -84,6 +99,28 @@ public void execute() throws Exception {

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-10 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490218#comment-17490218 ] Uwe Schindler commented on LUCENE-10419: We should log file path in the catch block. Maybe it

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-10 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490214#comment-17490214 ] Uwe Schindler commented on LUCENE-10419: Looks like a bug in Rat. Maybe it found an empty file?

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-10 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490212#comment-17490212 ] Uwe Schindler commented on LUCENE-10419: Hi, Wouldn't it a good idea to pass --stacktrace by

[jira] [Commented] (LUCENE-10177) Rename VectorValues#dimension to VectorValues#getNumDimensions?

2022-02-10 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490196#comment-17490196 ] Michael Sokolov commented on LUCENE-10177: -- Heh, I prefer {{dimension()}} and  would probably

[GitHub] [lucene] msokolov commented on a change in pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

2022-02-10 Thread GitBox
msokolov commented on a change in pull request #673: URL: https://github.com/apache/lucene/pull/673#discussion_r803661345 ## File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java ## @@ -521,22 +523,11 @@ public static void fsync(Path fileToSync, boolean isDir)

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490193#comment-17490193 ] Dawid Weiss commented on LUCENE-10419: -- Captured this: {code:java} > Task

[GitHub] [lucene] mocobeta commented on a change in pull request #643: LUCENE-10400: revise binary dictionaries' constructor in kuromoji

2022-02-10 Thread GitBox
mocobeta commented on a change in pull request #643: URL: https://github.com/apache/lucene/pull/643#discussion_r803637475 ## File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java ## @@ -526,4 +526,17 @@ public static void fsync(Path fileToSync, boolean isDir)

[jira] [Commented] (LUCENE-8739) ZSTD Compressor support in Lucene

2022-02-10 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490174#comment-17490174 ] Adrien Grand commented on LUCENE-8739: -- My opinion is that there are interesting benefits, but they

[jira] [Created] (LUCENE-10420) Move functional interfaces in IOUtils to top-level interfaces

2022-02-10 Thread Tomoko Uchida (Jira)
Tomoko Uchida created LUCENE-10420: -- Summary: Move functional interfaces in IOUtils to top-level interfaces Key: LUCENE-10420 URL: https://issues.apache.org/jira/browse/LUCENE-10420 Project: Lucene

[jira] [Commented] (LUCENE-8739) ZSTD Compressor support in Lucene

2022-02-10 Thread Praveen Nishchal (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490161#comment-17490161 ] Praveen Nishchal commented on LUCENE-8739: -- Hi Adrien, Thank you for your feedback! I am a

[jira] [Commented] (LUCENE-10414) Add fn:fuzzyTerm interval function to flexible query parser

2022-02-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490130#comment-17490130 ] ASF subversion and git services commented on LUCENE-10414: -- Commit

[jira] [Commented] (LUCENE-10414) Add fn:fuzzyTerm interval function to flexible query parser

2022-02-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490129#comment-17490129 ] ASF subversion and git services commented on LUCENE-10414: -- Commit

[GitHub] [lucene] dweiss merged pull request #668: LUCENE-10414: Add fn:fuzzyTerm interval function to flexible query parser

2022-02-10 Thread GitBox
dweiss merged pull request #668: URL: https://github.com/apache/lucene/pull/668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490124#comment-17490124 ] ASF subversion and git services commented on LUCENE-10419: -- Commit

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490121#comment-17490121 ] ASF subversion and git services commented on LUCENE-10419: -- Commit

[jira] [Created] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-10 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10419: Summary: Identify occasional validateSourcePatterns error on CI servers Key: LUCENE-10419 URL: https://issues.apache.org/jira/browse/LUCENE-10419 Project: Lucene -

[jira] [Assigned] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned LUCENE-10419: Assignee: Dawid Weiss > Identify occasional validateSourcePatterns error on CI servers

[GitHub] [lucene] iverase commented on a change in pull request #658: LUCENE-10378 Implement Weight#count for PointRangeQuery

2022-02-10 Thread GitBox
iverase commented on a change in pull request #658: URL: https://github.com/apache/lucene/pull/658#discussion_r803536317 ## File path: lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java ## @@ -369,6 +378,100 @@ public Scorer scorer(LeafReaderContext context)

[GitHub] [lucene] iverase commented on a change in pull request #658: LUCENE-10378 Implement Weight#count for PointRangeQuery

2022-02-10 Thread GitBox
iverase commented on a change in pull request #658: URL: https://github.com/apache/lucene/pull/658#discussion_r803536317 ## File path: lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java ## @@ -369,6 +378,100 @@ public Scorer scorer(LeafReaderContext context)

[GitHub] [lucene] dweiss commented on a change in pull request #668: LUCENE-10414: Add fn:fuzzyTerm interval function to flexible query parser

2022-02-10 Thread GitBox
dweiss commented on a change in pull request #668: URL: https://github.com/apache/lucene/pull/668#discussion_r803527778 ## File path: lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/nodes/intervalfn/FuzzyTerm.java ## @@ -0,0 +1,59 @@ +/* + *

[GitHub] [lucene] gautamworah96 commented on a change in pull request #658: LUCENE-10378 Implement Weight#count for PointRangeQuery

2022-02-10 Thread GitBox
gautamworah96 commented on a change in pull request #658: URL: https://github.com/apache/lucene/pull/658#discussion_r803485794 ## File path: lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java ## @@ -369,6 +376,45 @@ public Scorer scorer(LeafReaderContext

[GitHub] [lucene] gautamworah96 commented on a change in pull request #658: LUCENE-10378 Implement Weight#count for PointRangeQuery

2022-02-10 Thread GitBox
gautamworah96 commented on a change in pull request #658: URL: https://github.com/apache/lucene/pull/658#discussion_r803485066 ## File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java ## @@ -369,6 +369,52 @@ private void intersect(IntersectVisitor visitor,

[GitHub] [lucene] romseygeek commented on a change in pull request #668: LUCENE-10414: Add fn:fuzzyTerm interval function to flexible query parser

2022-02-10 Thread GitBox
romseygeek commented on a change in pull request #668: URL: https://github.com/apache/lucene/pull/668#discussion_r803476165 ## File path: lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/nodes/intervalfn/FuzzyTerm.java ## @@ -0,0 +1,59 @@ +/* + *

[jira] [Commented] (LUCENE-10418) Improve Query rewriting for non-scoring clauses

2022-02-10 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490053#comment-17490053 ] Adrien Grand commented on LUCENE-10418: --- I initially thought of adding a `boolean needsScores`

[jira] [Created] (LUCENE-10418) Improve Query rewriting for non-scoring clauses

2022-02-10 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10418: - Summary: Improve Query rewriting for non-scoring clauses Key: LUCENE-10418 URL: https://issues.apache.org/jira/browse/LUCENE-10418 Project: Lucene - Core

[GitHub] [lucene] mocobeta commented on a change in pull request #671: Add custom composite action to set up CI environments

2022-02-10 Thread GitBox
mocobeta commented on a change in pull request #671: URL: https://github.com/apache/lucene/pull/671#discussion_r803409108 ## File path: .github/workflows/gradle-precommit.yml ## @@ -26,12 +26,9 @@ jobs: steps: - uses: actions/checkout@v2 -- name: Set up JDK -

[jira] [Assigned] (LUCENE-10417) IntNRQ task performance decreased in nightly benchmark

2022-02-10 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Guo reassigned LUCENE-10417: - Assignee: Feng Guo > IntNRQ task performance decreased in nightly benchmark >

[jira] [Updated] (LUCENE-10417) IntNRQ task performance decreased in nightly benchmark

2022-02-10 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Guo updated LUCENE-10417: -- Description: Link: https://home.apache.org/~mikemccand/lucenebench/2022.02.07.18.02.48.html

[jira] [Updated] (LUCENE-10417) IntNRQ task performance decreased in nightly benchmark

2022-02-10 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Guo updated LUCENE-10417: -- Description: Link: https://home.apache.org/~mikemccand/lucenebench/2022.02.07.18.02.48.html

[jira] [Created] (LUCENE-10417) IntNRQ task performance decreased in nightly benchmark

2022-02-10 Thread Feng Guo (Jira)
Feng Guo created LUCENE-10417: - Summary: IntNRQ task performance decreased in nightly benchmark Key: LUCENE-10417 URL: https://issues.apache.org/jira/browse/LUCENE-10417 Project: Lucene - Core

[GitHub] [lucene] jtibshirani commented on a change in pull request #656: LUCENE-10382: Support filtering in KnnVectorQuery

2022-02-10 Thread GitBox
jtibshirani commented on a change in pull request #656: URL: https://github.com/apache/lucene/pull/656#discussion_r803395995 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java ## @@ -147,6 +165,11 @@ NeighborQueue searchLevel(