[jira] [Comment Edited] (LUCENE-10596) Remove unused parameter in #getOrAddPerField

2022-05-30 Thread tangdh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17543754#comment-17543754 ] tangdh edited comment on LUCENE-10596 at 5/31/22 5:36 AM: -- I have raised a

[jira] [Commented] (LUCENE-10594) Duplicated value should be involve in SortedSetDocValues#docValueCount() in MemoryIndex

2022-05-30 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544105#comment-17544105 ] Lu Xugang commented on LUCENE-10594: According to the explaining in LUCENE-10188 , this issue is

[GitHub] [lucene] LuXugang commented on pull request #928: LUCENE-10594: Duplicated value should be involve in SortedSetDocValues#docValueCount() in MemoryIndex

2022-05-30 Thread GitBox
LuXugang commented on PR #928: URL: https://github.com/apache/lucene/pull/928#issuecomment-1141622393 According to the explaining in [LUCENE-10188](https://issues.apache.org/jira/browse/LUCENE-10188) , this issue is not a problem, closed -- This is an automated message from the Apache

[GitHub] [lucene] jtibshirani commented on pull request #926: VectorSimilarityFunction reverse removal

2022-05-30 Thread GitBox
jtibshirani commented on PR #926: URL: https://github.com/apache/lucene/pull/926#issuecomment-1141529401 Thanks @alessandrobenedetti for working on this nice simplification! One thing I wanted to double-check -- for Euclidean distance we're now performing an extra division compared to

[jira] [Commented] (LUCENE-10598) SortedSetDocValues#docValueCount() should be always greater than zero

2022-05-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544079#comment-17544079 ] Robert Muir commented on LUCENE-10598: -- I think we should validate this count in CheckIndex,

[GitHub] [lucene] mayya-sharipova commented on pull request #926: VectorSimilarityFunction reverse removal

2022-05-30 Thread GitBox
mayya-sharipova commented on PR #926: URL: https://github.com/apache/lucene/pull/926#issuecomment-1141499461 > The tie-breaking by Lucene docId (smaller id wins) doesn't actually work right now(for the regular similarities) and not for Euclidean after my changes. > The node ID and

[jira] [Resolved] (LUCENE-10594) Duplicated value should be involve in SortedSetDocValues#docValueCount() in MemoryIndex

2022-05-30 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lu Xugang resolved LUCENE-10594. Resolution: Not A Problem > Duplicated value should be involve in

[GitHub] [lucene] LuXugang closed pull request #928: LUCENE-10594: Duplicated value should be involve in SortedSetDocValues#docValueCount() in MemoryIndex

2022-05-30 Thread GitBox
LuXugang closed pull request #928: LUCENE-10594: Duplicated value should be involve in SortedSetDocValues#docValueCount() in MemoryIndex URL: https://github.com/apache/lucene/pull/928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (LUCENE-10598) SortedSetDocValues#docValueCount() should be always greater than zero

2022-05-30 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544045#comment-17544045 ] Adrien Grand commented on LUCENE-10598: --- Good catch, it's indeed broken. >

[jira] [Commented] (LUCENE-10188) Give SortedSetDocValues a docValueCount()?

2022-05-30 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544043#comment-17544043 ] Adrien Grand commented on LUCENE-10188: --- The value count on SortedSetDocValues should be the

[jira] [Resolved] (LUCENE-10582) CombinedFieldQuery fails with distributed field statistics

2022-05-30 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani resolved LUCENE-10582. --- Fix Version/s: 9.3 Resolution: Fixed > CombinedFieldQuery fails with

[jira] [Commented] (LUCENE-10582) CombinedFieldQuery fails with distributed field statistics

2022-05-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544028#comment-17544028 ] ASF subversion and git services commented on LUCENE-10582: -- Commit

[jira] [Commented] (LUCENE-10582) CombinedFieldQuery fails with distributed field statistics

2022-05-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544026#comment-17544026 ] ASF subversion and git services commented on LUCENE-10582: -- Commit

[GitHub] [lucene] jtibshirani merged pull request #910: LUCENE-10582: Fix merging of CollectionStatistics in CombinedFieldQuery

2022-05-30 Thread GitBox
jtibshirani merged PR #910: URL: https://github.com/apache/lucene/pull/910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (LUCENE-10599) Improve LogMergePolicy's handling of maxMergeSize

2022-05-30 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10599: - Summary: Improve LogMergePolicy's handling of maxMergeSize Key: LUCENE-10599 URL: https://issues.apache.org/jira/browse/LUCENE-10599 Project: Lucene - Core

[jira] [Comment Edited] (LUCENE-10188) Give SortedSetDocValues a docValueCount()?

2022-05-30 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17543989#comment-17543989 ] Lu Xugang edited comment on LUCENE-10188 at 5/30/22 3:53 PM: - Hi,

[jira] [Commented] (LUCENE-10598) SortedSetDocValues#docValueCount() should be always greater than zero

2022-05-30 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17543994#comment-17543994 ] Lu Xugang commented on LUCENE-10598: After LUCENE-10188 's question confirmed by [~jpountz] , I

[jira] [Created] (LUCENE-10598) SortedSetDocValues#docValueCount() should be always greater than zero

2022-05-30 Thread Lu Xugang (Jira)
Lu Xugang created LUCENE-10598: -- Summary: SortedSetDocValues#docValueCount() should be always greater than zero Key: LUCENE-10598 URL: https://issues.apache.org/jira/browse/LUCENE-10598 Project: Lucene

[jira] [Commented] (LUCENE-10188) Give SortedSetDocValues a docValueCount()?

2022-05-30 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17543989#comment-17543989 ] Lu Xugang commented on LUCENE-10188: Hi, [~jpountz] , implementation of

[jira] [Commented] (LUCENE-10557) Migrate to GitHub issue from Jira?

2022-05-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17543987#comment-17543987 ] Dawid Weiss commented on LUCENE-10557: -- I don't think this is a problem. You just create a

[GitHub] [lucene] alessandrobenedetti commented on a diff in pull request #926: VectorSimilarityFunction reverse removal

2022-05-30 Thread GitBox
alessandrobenedetti commented on code in PR #926: URL: https://github.com/apache/lucene/pull/926#discussion_r884909389 ## lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborQueue.java: ## @@ -56,9 +56,9 @@ long apply(long v) { // Whether the search stopped early

[GitHub] [lucene] alessandrobenedetti commented on a diff in pull request #926: VectorSimilarityFunction reverse removal

2022-05-30 Thread GitBox
alessandrobenedetti commented on code in PR #926: URL: https://github.com/apache/lucene/pull/926#discussion_r884908511 ## lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java: ## @@ -193,25 +208,40 @@ public void testAdvanceShallow() throws IOException {

[jira] [Comment Edited] (LUCENE-10557) Migrate to GitHub issue from Jira?

2022-05-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17543968#comment-17543968 ] Tomoko Uchida edited comment on LUCENE-10557 at 5/30/22 2:24 PM: - One

[jira] [Commented] (LUCENE-10557) Migrate to GitHub issue from Jira?

2022-05-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17543968#comment-17543968 ] Tomoko Uchida commented on LUCENE-10557: One feature I couldn't find out in GitHub issue that

[GitHub] [lucene] mocobeta commented on a diff in pull request #931: LUCENE-10597: move globalMaxScore to MaxScoreCache

2022-05-30 Thread GitBox
mocobeta commented on code in PR #931: URL: https://github.com/apache/lucene/pull/931#discussion_r884855095 ## lucene/core/src/java/org/apache/lucene/search/MaxScoreCache.java: ## @@ -80,6 +82,9 @@ int getLevel(int upTo) throws IOException { /** Return the maximum score

[GitHub] [lucene] mocobeta opened a new pull request, #931: LUCENE-10597: move globalMaxScore to MaxScoreCache

2022-05-30 Thread GitBox
mocobeta opened a new pull request, #931: URL: https://github.com/apache/lucene/pull/931 ### Description (or a Jira issue link if you have one) See https://issues.apache.org/jira/browse/LUCENE-10597 -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Created] (LUCENE-10597) Move globalMaxScore to MaxScoreCache from ImpactsDISI?

2022-05-30 Thread Tomoko Uchida (Jira)
Tomoko Uchida created LUCENE-10597: -- Summary: Move globalMaxScore to MaxScoreCache from ImpactsDISI? Key: LUCENE-10597 URL: https://issues.apache.org/jira/browse/LUCENE-10597 Project: Lucene - Core

[GitHub] [lucene] alessandrobenedetti commented on pull request #926: VectorSimilarityFunction reverse removal

2022-05-30 Thread GitBox
alessandrobenedetti commented on PR #926: URL: https://github.com/apache/lucene/pull/926#issuecomment-1141164970 @mayya-sharipova , @msokolov I found out the reason the original tests are now failing. The tie-breaking by Lucene docId (smaller id wins) doesn't actually work right

[GitHub] [lucene] shaie commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-05-30 Thread GitBox
shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1141152098 Hey @mdmarshmallow I think this is a great and very useful feature. I also believe that in general it will be good to accompany these changes with a demo `main()` in the `demo` package, but

[jira] [Comment Edited] (LUCENE-10557) Migrate to GitHub issue from Jira?

2022-05-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17543911#comment-17543911 ] Tomoko Uchida edited comment on LUCENE-10557 at 5/30/22 11:52 AM: -- Hi

[jira] [Commented] (LUCENE-10557) Migrate to GitHub issue from Jira?

2022-05-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17543911#comment-17543911 ] Tomoko Uchida commented on LUCENE-10557: Hi [~janhoy], thanks for your suggestion. "Migrate no

[jira] [Comment Edited] (LUCENE-10151) Add timeout support to IndexSearcher

2022-05-30 Thread Deepika Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17543885#comment-17543885 ] Deepika Sharma edited comment on LUCENE-10151 at 5/30/22 11:08 AM: --- I

[jira] [Commented] (LUCENE-10151) Add timeout support to IndexSearcher

2022-05-30 Thread Deepika Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17543885#comment-17543885 ] Deepika Sharma commented on LUCENE-10151: - I have raised a PR for the `BulkScorer` approach.

[jira] [Commented] (LUCENE-10574) Remove O(n^2) from TieredMergePolicy or change defaults to one that doesn't do this

2022-05-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17543852#comment-17543852 ] ASF subversion and git services commented on LUCENE-10574: -- Commit

[jira] [Commented] (LUCENE-10574) Remove O(n^2) from TieredMergePolicy or change defaults to one that doesn't do this

2022-05-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17543851#comment-17543851 ] ASF subversion and git services commented on LUCENE-10574: -- Commit

[GitHub] [lucene-solr] janhoy merged pull request #2661: SOLR-16213 Upgrade Jackson to version 2.13.3

2022-05-30 Thread GitBox
janhoy merged PR #2661: URL: https://github.com/apache/lucene-solr/pull/2661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LUCENE-10557) Migrate to GitHub issue from Jira?

2022-05-30 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17543849#comment-17543849 ] Jan Høydahl commented on LUCENE-10557: -- Thanks for thorough research! I propose to skip bulk

[GitHub] [lucene] uschindler commented on pull request #912: MR-JAR rewrite of MMapDirectory with JDK-19 preview Panama APIs (>= JDK-19-ea+23)

2022-05-30 Thread GitBox
uschindler commented on PR #912: URL: https://github.com/apache/lucene/pull/912#issuecomment-1140807127 Thanks @mocobeta, I just need to not forget to reenable in September when this gets merged (the we van also use Autoprovision of JDK 19). -- This is an automated message from the

[GitHub] [lucene] uschindler commented on pull request #912: MR-JAR rewrite of MMapDirectory with JDK-19 preview Panama APIs (>= JDK-19-ea+23)

2022-05-30 Thread GitBox
uschindler commented on PR #912: URL: https://github.com/apache/lucene/pull/912#issuecomment-1140776739 Thanks. Here we only need to compile a specific exact version (19). So for the MR-JAR task this should be fine with auto-discovery. -- This is an automated message from the Apache Git

[GitHub] [lucene] vigyasharma commented on pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-05-30 Thread GitBox
vigyasharma commented on PR #633: URL: https://github.com/apache/lucene/pull/633#issuecomment-1140767642 > I could either wrap the runningMerges update with a synchronized (IndexWriter.this) {}, or make runningMerges a synchronizedSet. I like the second approach as it automatically fixes