[GitHub] [lucene] shaie commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1153078375 > pushed a change just now that shows a different way we _could_ approach this. If I understand your change correctly, then it creates a new `long[]` in each call to `matches()` right?

[GitHub] [lucene] shaie commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1153077923 > I feel like having 2 `matches` functions in this case would make the API unnecessarily complex As I wrote before "_After we decide whether to stick w/ the long[] or byte[] API we'll

[jira] [Comment Edited] (LUCENE-10610) RunAutomaton#hashCode() can easily cause hash collision for different Automatons

[ https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553142#comment-17553142 ] Tomoko Uchida edited comment on LUCENE-10610 at 6/11/22 7:54 PM: - I've

[jira] [Comment Edited] (LUCENE-10610) RunAutomaton#hashCode() can easily cause hash collision for different Automatons

[ https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553142#comment-17553142 ] Tomoko Uchida edited comment on LUCENE-10610 at 6/11/22 7:13 PM: - I've

[jira] [Comment Edited] (LUCENE-10610) RunAutomaton#hashCode() can easily cause hash collision for different Automatons

[ https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553142#comment-17553142 ] Tomoko Uchida edited comment on LUCENE-10610 at 6/11/22 6:47 PM: - I've

[jira] [Commented] (LUCENE-10610) RunAutomaton#hashCode() can easily cause hash collision for different Automatons

[ https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553142#comment-17553142 ] Tomoko Uchida commented on LUCENE-10610: I've been thinking about those three options, for what

[jira] [Commented] (LUCENE-10610) RunAutomaton#hashCode() can easily cause hash collision for different Automatons

[ https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553136#comment-17553136 ] Tomoko Uchida commented on LUCENE-10610: bq. I would just make the already existing hashCode

[jira] [Commented] (LUCENE-10610) RunAutomaton#hashCode() can easily cause hash collision for different Automatons

[ https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553133#comment-17553133 ] Dawid Weiss commented on LUCENE-10610: -- > I do not think we need to discuss if equals/hashCode

[jira] [Comment Edited] (LUCENE-10610) RunAutomaton#hashCode() can easily cause hash collision for different Automatons

[ https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553131#comment-17553131 ] Uwe Schindler edited comment on LUCENE-10610 at 6/11/22 5:51 PM: - I

[jira] [Comment Edited] (LUCENE-10610) RunAutomaton#hashCode() can easily cause hash collision for different Automatons

[ https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553131#comment-17553131 ] Uwe Schindler edited comment on LUCENE-10610 at 6/11/22 5:49 PM: - I

[jira] [Commented] (LUCENE-10610) RunAutomaton#hashCode() can easily cause hash collision for different Automatons

[ https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553131#comment-17553131 ] Uwe Schindler commented on LUCENE-10610: I looked at the code again: - Automaton class has no

[jira] [Commented] (LUCENE-10610) RunAutomaton#hashCode() can easily cause hash collision for different Automatons

[ https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553075#comment-17553075 ] Tomoko Uchida commented on LUCENE-10610: Sorry if I casually dag up an old discussion. I had a

[jira] [Commented] (LUCENE-10610) RunAutomaton#hashCode() can easily cause hash collision for different Automatons

[ https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553063#comment-17553063 ] Uwe Schindler commented on LUCENE-10610: I think the problem may be query caching. This would