[GitHub] [lucene] zhaih commented on pull request #12050: Reuse HNSW graph for intialization during merge

2023-01-13 Thread GitBox
zhaih commented on PR #12050: URL: https://github.com/apache/lucene/pull/12050#issuecomment-1382268387 +1, That sounds good! On Fri, Jan 13, 2023, 11:10 John Mazanec ***@***.***> wrote: > ***@***. commented on this pull request. > -- > >

[GitHub] [lucene] jmazanec15 commented on a diff in pull request #12050: Reuse HNSW graph for intialization during merge

2023-01-13 Thread GitBox
jmazanec15 commented on code in PR #12050: URL: https://github.com/apache/lucene/pull/12050#discussion_r1069901702 ## lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraph.java: ## @@ -94,36 +93,83 @@ public int size() { } /** - * Add node on the given

[GitHub] [lucene] magibney opened a new pull request, #12085: update releaseWizard.py to support offline gpg key

2023-01-13 Thread GitBox
magibney opened a new pull request, #12085: URL: https://github.com/apache/lucene/pull/12085 porting analogous change from solr: https://github.com/apache/solr/pull/1288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [lucene] LuXugang opened a new pull request, #12084: Same bound with fallbackQuery

2023-01-13 Thread GitBox
LuXugang opened a new pull request, #12084: URL: https://github.com/apache/lucene/pull/12084 ## Description IndexSortSortedNumericDocValuesRangeQuery should have the same bound with fallbackQuery. According to the comment, my guess it is a typo thing? -- This is an

[GitHub] [lucene] jpountz commented on pull request #12083: MultiCollector shouldn't report that scores are needed when they're not.

2023-01-13 Thread GitBox
jpountz commented on PR #12083: URL: https://github.com/apache/lucene/pull/12083#issuecomment-1381870866 Thanks Luca! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [lucene] jpountz merged pull request #12083: MultiCollector shouldn't report that scores are needed when they're not.

2023-01-13 Thread GitBox
jpountz merged PR #12083: URL: https://github.com/apache/lucene/pull/12083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] jpountz opened a new pull request, #12083: MultiCollector shouldn't report that scores are needed when they're not.

2023-01-13 Thread GitBox
jpountz opened a new pull request, #12083: URL: https://github.com/apache/lucene/pull/12083 When sub collectors don't agree on their `ScoreMode`, `MultiCollector` currently returns `COMPLETE`. This makes sense when assuming that there is likely one collector computing top hits

[GitHub] [lucene] LuXugang merged pull request #12078: Enhance XXXField#newRangeQuery

2023-01-13 Thread GitBox
LuXugang merged PR #12078: URL: https://github.com/apache/lucene/pull/12078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] LuXugang closed issue #12074: Enhance XXXField#newRangeQuery

2023-01-13 Thread GitBox
LuXugang closed issue #12074: Enhance XXXField#newRangeQuery URL: https://github.com/apache/lucene/issues/12074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [lucene] romseygeek commented on pull request #11807: No need to rewrite queries in unified highlighter

2023-01-13 Thread GitBox
romseygeek commented on PR #11807: URL: https://github.com/apache/lucene/pull/11807#issuecomment-1381532407 Oops, yes, I should have backported it at the time. Will do that now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to