[GitHub] [lucene] vigyasharma closed issue #12097: TestIndexSortSortedNumericDocValuesRangeQuery.testCountBoundary failure

vigyasharma closed issue #12097: TestIndexSortSortedNumericDocValuesRangeQuery.testCountBoundary failure URL: https://github.com/apache/lucene/issues/12097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene] vigyasharma merged pull request #12098: Fix failure in TestIndexSortSortedNumericDocValuesRangeQuery

vigyasharma merged PR #12098: URL: https://github.com/apache/lucene/pull/12098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] rmuir commented on pull request #12098: Fix failure in TestIndexSortSortedNumericDocValuesRangeQuery

rmuir commented on PR #12098: URL: https://github.com/apache/lucene/pull/12098#issuecomment-1397749519 if a test wants to enforce it only has one segment, it should `forceMerge()`, make use of `LuceneTestCase.getOnlyLeafReader()`, etc. Otherwise the number of segments can vary based

[GitHub] [lucene] jmazanec15 commented on a diff in pull request #12050: Reuse HNSW graph for intialization during merge

jmazanec15 commented on code in PR #12050: URL: https://github.com/apache/lucene/pull/12050#discussion_r1081896861 ## lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraph.java: ## @@ -94,36 +93,83 @@ public int size() { } /** - * Add node on the given

[GitHub] [lucene] jmazanec15 commented on pull request #12050: Reuse HNSW graph for intialization during merge

jmazanec15 commented on PR #12050: URL: https://github.com/apache/lucene/pull/12050#issuecomment-1397643952 Per [this discussion](https://github.com/apache/lucene/pull/12050#discussion_r1061034056), I refactored OnHeapHnswGraph to use a TreeMap to represent the graph structure for levels

[GitHub] [lucene] vigyasharma opened a new pull request, #12098: Fix failure in TestIndexSortSortedNumericDocValuesRangeQuery

vigyasharma opened a new pull request, #12098: URL: https://github.com/apache/lucene/pull/12098 Fixes bug in `TestIndexSortSortedNumericDocValuesRangeQuery. testCountBoundary`. Addresses #12097 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene] vigyasharma commented on issue #12097: TestIndexSortSortedNumericDocValuesRangeQuery.testCountBoundary failure

vigyasharma commented on issue #12097: URL: https://github.com/apache/lucene/issues/12097#issuecomment-1397542712 Wait.. I think the assert should simply be on total no. of documents, not documents per leaf. Something like: ```java int count = 0; for (LeafReaderContext

[GitHub] [lucene] vigyasharma opened a new issue, #12097: TestIndexSortSortedNumericDocValuesRangeQuery.testCountBoundary failure

vigyasharma opened a new issue, #12097: URL: https://github.com/apache/lucene/issues/12097 ### Description Found this test failing in Lucene-Check-9.x - Build # 4239. **Steps to repro:** ```ruby gradlew test --tests

[GitHub] [lucene] uschindler commented on pull request #12094: releaseWizard: allow explicitly setting MANIFEST.MF userid (e.g., to apache id)

uschindler commented on PR #12094: URL: https://github.com/apache/lucene/pull/12094#issuecomment-1397386789 I am fine with both PRs, both technically correct. I don't care about username. If I would do a relaese I would insert "policeman" into the artifacts. -- This is an automated

[GitHub] [lucene] magibney commented on a diff in pull request #12094: releaseWizard: allow explicitly setting MANIFEST.MF userid (e.g., to apache id)

magibney commented on code in PR #12094: URL: https://github.com/apache/lucene/pull/12094#discussion_r1081614175 ## gradle/java/jar-manifest.gradle: ## @@ -46,7 +46,9 @@ subprojects { if (snapshotBuild) { return "${project.version} ${gitRev}

[GitHub] [lucene] magibney opened a new pull request, #12096: remove username from MANIFEST.MF in build artifacts

magibney opened a new pull request, #12096: URL: https://github.com/apache/lucene/pull/12096 Following on discussion from #12094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [lucene] magibney commented on pull request #12094: releaseWizard: allow explicitly setting MANIFEST.MF userid (e.g., to apache id)

magibney commented on PR #12094: URL: https://github.com/apache/lucene/pull/12094#issuecomment-1397358626 > Should we just remove the username from the manifest? This doesn't make sense to me, we don't put usernames anywhere else (e.g. no @author at apache)... This seems fine to me.

[GitHub] [lucene] magibney commented on pull request #12095: buildAndPushRelease should optionally pause before assembleRelease

magibney commented on PR #12095: URL: https://github.com/apache/lucene/pull/12095#issuecomment-1397344248 The main reason I didn't make this the default is because I'm not sure whether running this through the releaseWizard would support user input. I'm using the releaseWizard to guide me

[GitHub] [lucene] javanna commented on pull request #12085: update releaseWizard.py to support offline gpg key

javanna commented on PR #12085: URL: https://github.com/apache/lucene/pull/12085#issuecomment-1396993570 Thanks @magibney ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [lucene] javanna merged pull request #12085: update releaseWizard.py to support offline gpg key

javanna merged PR #12085: URL: https://github.com/apache/lucene/pull/12085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] rmuir commented on pull request #12094: releaseWizard: allow explicitly setting MANIFEST.MF userid (e.g., to apache id)

rmuir commented on PR #12094: URL: https://github.com/apache/lucene/pull/12094#issuecomment-1396942514 I have also witnessed harassment from solr users towards the person whose name happens to be in there. Please, lets remove the username. If I am ignored and this option is kept, I

[GitHub] [lucene] rmuir commented on pull request #12094: releaseWizard: allow explicitly setting MANIFEST.MF userid (e.g., to apache id)

rmuir commented on PR #12094: URL: https://github.com/apache/lucene/pull/12094#issuecomment-1396882440 Should we just remove the username from the manifest? This doesn't make sense to me, we don't put usernames anywhere else (e.g. no `@author` at apache)... -- This is an automated

[GitHub] [lucene] romseygeek commented on pull request #12095: buildAndPushRelease should optionally pause before assembleRelease

romseygeek commented on PR #12095: URL: https://github.com/apache/lucene/pull/12095#issuecomment-1396781927 +1, this has caught me multiple times! I think I'd personally make it the default but I don't know if others have things set up so that they don't need to type in their GPG pin.