[GitHub] [lucene] gus-asf commented on pull request #12096: remove username from MANIFEST.MF in build artifacts

2023-01-20 Thread via GitHub
gus-asf commented on PR #12096: URL: https://github.com/apache/lucene/pull/12096#issuecomment-1399171309 I don't understand what you mean by differentiate artifacts for the same commit hash. How would a time stamp do this? If they are different artifacts the contents and the name are all

[GitHub] [lucene] magibney commented on pull request #12096: remove username from MANIFEST.MF in build artifacts

2023-01-20 Thread via GitHub
magibney commented on PR #12096: URL: https://github.com/apache/lucene/pull/12096#issuecomment-1399161958 MANIFEST.MF `ImplementationVersion` field does include the revision hash -- `${gitRev}` in the line that's edited in this PR. I think the build date/time is a potentially useful bit of

[GitHub] [lucene] gus-asf commented on pull request #12096: remove username from MANIFEST.MF in build artifacts

2023-01-20 Thread via GitHub
gus-asf commented on PR #12096: URL: https://github.com/apache/lucene/pull/12096#issuecomment-1399159488 While we are at it maybe we should remove the timestamp too. It really ought to be a revision hash. This moves toward making the build repeatable. It's not actually important which day

[GitHub] [lucene-solr] janhoy commented on pull request #2676: SOLR-16626: Upgrade to Netty 4.1.87.Final

2023-01-20 Thread via GitHub
janhoy commented on PR #2676: URL: https://github.com/apache/lucene-solr/pull/2676#issuecomment-1398961127 > missing solr/CHANGES.txt entry? That's right. I added it on the same line as the previous upgrade from SOLR-16424, keeping both JIRA-numbers. Do you think we should just

[GitHub] [lucene-solr] itygh commented on pull request #2676: SOLR-16626: Upgrade to Netty 4.1.87.Final

2023-01-20 Thread GitBox
itygh commented on PR #2676: URL: https://github.com/apache/lucene-solr/pull/2676#issuecomment-1398560219 这是来自QQ邮箱的假期自动回复邮件。您好,我最近正在休假中,无法亲自回复您的邮件。我将在假期结束后,尽快给您回复。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [lucene-solr] janhoy opened a new pull request, #2676: SOLR-16626: Upgrade to Netty 4.1.87.Final

2023-01-20 Thread GitBox
janhoy opened a new pull request, #2676: URL: https://github.com/apache/lucene-solr/pull/2676 Backport from 9.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [lucene] risdenk commented on pull request #12029: introduce support in KnnVectorQuery for getters/setters

2023-01-20 Thread GitBox
risdenk commented on PR #12029: URL: https://github.com/apache/lucene/pull/12029#issuecomment-1398549982 Re: immutable Query in Solr - See https://issues.apache.org/jira/browse/SOLR-16509 and https://github.com/apache/solr/pull/1146 -- This is an automated message from the Apache Git

[GitHub] [lucene] alessandrobenedetti commented on pull request #12029: introduce support in KnnVectorQuery for getters/setters

2023-01-20 Thread GitBox
alessandrobenedetti commented on PR #12029: URL: https://github.com/apache/lucene/pull/12029#issuecomment-1398524390 waiting for the checks and then I'll merge tonight! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [lucene] alessandrobenedetti commented on a diff in pull request #12029: introduce support in KnnVectorQuery for getters/setters

2023-01-20 Thread GitBox
alessandrobenedetti commented on code in PR #12029: URL: https://github.com/apache/lucene/pull/12029#discussion_r1082676520 ## lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java: ## @@ -33,6 +33,7 @@ import org.apache.lucene.store.Directory; import

[GitHub] [lucene] mkhludnev commented on issue #11218: GraphTokenStreamFiniteStrings#articulationPointsRecurse can run into stack overflows [LUCENE-10181]

2023-01-20 Thread GitBox
mkhludnev commented on issue #11218: URL: https://github.com/apache/lucene/issues/11218#issuecomment-1398122320 @hassenome , can you share versions, stacktrace and invocation arguments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [lucene] hassenome commented on issue #11218: GraphTokenStreamFiniteStrings#articulationPointsRecurse can run into stack overflows [LUCENE-10181]

2023-01-20 Thread GitBox
hassenome commented on issue #11218: URL: https://github.com/apache/lucene/issues/11218#issuecomment-1398087851 Hello, We are facing this error, as a root cause for a feature used by ElasticSearch. We are wondering if there is an update to this issue? -- This is an automated message