[jira] [Commented] (LUCENE-8836) Optimize DocValues TermsDict to continue scanning from the last position when possible

2022-04-25 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527666#comment-17527666 ] Bruno Roustant commented on LUCENE-8836: Thanks [~jpountz] for this simplified improvement! I

[jira] [Resolved] (LUCENE-10225) Improve IntroSelector with 3-way partitioning

2021-11-17 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved LUCENE-10225. - Fix Version/s: 9.1 Resolution: Fixed Thanks Dawid and Adrien! > Improve

[jira] [Commented] (LUCENE-10225) Improve IntroSelector with 3-way partitioning

2021-11-17 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445045#comment-17445045 ] Bruno Roustant commented on LUCENE-10225: - I'm a bit confused. I put this change in the 9.1

[jira] [Comment Edited] (LUCENE-10225) Improve IntroSelector with 3-way partitioning

2021-11-13 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443195#comment-17443195 ] Bruno Roustant edited comment on LUCENE-10225 at 11/13/21, 10:25 PM:

[jira] [Commented] (LUCENE-10225) Improve IntroSelector with 3-way partitioning

2021-11-13 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443195#comment-17443195 ] Bruno Roustant commented on LUCENE-10225: - With the addition of the adaptive top-k algorithm

[jira] (LUCENE-10225) Improve IntroSelector with 3-way partitioning

2021-11-09 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10225 ] Bruno Roustant deleted comment on LUCENE-10225: - was (Author: broustant): PR: https://github.com/apache/lucene/pull/430 > Improve IntroSelector with 3-way partitioning >

[jira] [Commented] (LUCENE-10225) Improve IntroSelector with 3-way partitioning

2021-11-08 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440556#comment-17440556 ] Bruno Roustant commented on LUCENE-10225: - PR: https://github.com/apache/lucene/pull/430 >

[jira] [Commented] (LUCENE-10225) Improve IntroSelector with 3-way partitioning

2021-11-08 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440475#comment-17440475 ] Bruno Roustant commented on LUCENE-10225: - {code:java} RANDOM   IntroSelector  ...  397  422  

[jira] [Created] (LUCENE-10225) Improve IntroSelector with 3-way partitioning

2021-11-08 Thread Bruno Roustant (Jira)
Bruno Roustant created LUCENE-10225: --- Summary: Improve IntroSelector with 3-way partitioning Key: LUCENE-10225 URL: https://issues.apache.org/jira/browse/LUCENE-10225 Project: Lucene - Core

[jira] [Commented] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-11-03 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437876#comment-17437876 ] Bruno Roustant commented on LUCENE-10196: - Thanks for sharing the benchmark Adrien. I'm not

[jira] [Commented] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-11-02 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437247#comment-17437247 ] Bruno Roustant commented on LUCENE-10196: - Oh! Thank you [~jpountz]! I was wrong in the CHANGES

[jira] [Resolved] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-11-01 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved LUCENE-10196. - Fix Version/s: 8.11 Resolution: Fixed Thanks reviewers! > Improve IntroSorter

[jira] [Updated] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-10-21 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated LUCENE-10196: Description: I added a SorterBenchmark to evaluate the performance of the various Sorter

[jira] [Issue Comment Deleted] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-10-21 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated LUCENE-10196: Comment: was deleted (was: https://github.com/apache/lucene/pull/404) > Improve

[jira] [Commented] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-10-21 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432685#comment-17432685 ] Bruno Roustant commented on LUCENE-10196: - https://github.com/apache/lucene/pull/404 > Improve

[jira] [Commented] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-10-21 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432670#comment-17432670 ] Bruno Roustant commented on LUCENE-10196: - Benchmark run to compare sorters implementations for

[jira] [Created] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-10-21 Thread Bruno Roustant (Jira)
Bruno Roustant created LUCENE-10196: --- Summary: Improve IntroSorter with 3-ways partitioning Key: LUCENE-10196 URL: https://issues.apache.org/jira/browse/LUCENE-10196 Project: Lucene - Core

[jira] [Resolved] (LUCENE-10097) Replace TreeMap use by HashMap when unnecessary

2021-10-04 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved LUCENE-10097. - Resolution: Won't Do > Replace TreeMap use by HashMap when unnecessary >

[jira] [Commented] (LUCENE-10097) Replace TreeMap use by HashMap when unnecessary

2021-10-04 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423780#comment-17423780 ] Bruno Roustant commented on LUCENE-10097: - Based on remarks in the PRs, I'm closing this Jira

[jira] [Created] (LUCENE-10097) Replace TreeMap use by HashMap when unnecessary

2021-09-10 Thread Bruno Roustant (Jira)
Bruno Roustant created LUCENE-10097: --- Summary: Replace TreeMap use by HashMap when unnecessary Key: LUCENE-10097 URL: https://issues.apache.org/jira/browse/LUCENE-10097 Project: Lucene - Core

[jira] [Commented] (LUCENE-9983) Stop sorting determinize powersets unnecessarily

2021-06-07 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17358418#comment-17358418 ] Bruno Roustant commented on LUCENE-9983: [~zhai7631] do you have some stats about the numbers of

[jira] [Commented] (LUCENE-9983) Stop sorting determinize powersets unnecessarily

2021-06-02 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355600#comment-17355600 ] Bruno Roustant commented on LUCENE-9983: How many states are manipulated? If the states are

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2021-05-31 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17354275#comment-17354275 ] Bruno Roustant commented on LUCENE-9379: _RE AES-XTS vs AES-CTR:_ In the case of Lucene, we

[jira] [Commented] (LUCENE-9663) Adding compression to terms dict from SortedSet/Sorted DocValues

2021-03-17 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303494#comment-17303494 ] Bruno Roustant commented on LUCENE-9663: Ok, I backported to 8.x branch, and I updated

[jira] [Updated] (LUCENE-9663) Adding compression to terms dict from SortedSet/Sorted DocValues

2021-03-17 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated LUCENE-9663: --- Fix Version/s: (was: main (9.0)) 8.9 > Adding compression to terms

[jira] [Commented] (LUCENE-9796) fix SortedDocValues to no longer extend BinaryDocValues

2021-03-15 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301817#comment-17301817 ] Bruno Roustant commented on LUCENE-9796: Ok, I'll try to update Solr to use 

[jira] [Commented] (LUCENE-9796) fix SortedDocValues to no longer extend BinaryDocValues

2021-03-15 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301800#comment-17301800 ] Bruno Roustant commented on LUCENE-9796: Solr main branch build broke after this change. I

[jira] [Commented] (SOLR-15170) Elevation file in data dir not working in Solr Cloud

2021-03-10 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298918#comment-17298918 ] Bruno Roustant commented on SOLR-15170: --- PR for the fix added. I plan to backport the fix in branch

[jira] [Commented] (SOLR-15038) Add elevateDocsWithoutMatchingQ and onlyElevatedRepresentative parameters to elevation functionality

2021-03-04 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295358#comment-17295358 ] Bruno Roustant commented on SOLR-15038: --- I reverted this specific line in both master and

[jira] [Comment Edited] (SOLR-15038) Add elevateDocsWithoutMatchingQ and onlyElevatedRepresentative parameters to elevation functionality

2021-03-04 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295203#comment-17295203 ] Bruno Roustant edited comment on SOLR-15038 at 3/4/21, 10:37 AM: - Ouch,

[jira] [Commented] (SOLR-15038) Add elevateDocsWithoutMatchingQ and onlyElevatedRepresentative parameters to elevation functionality

2021-03-04 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295203#comment-17295203 ] Bruno Roustant commented on SOLR-15038: --- Ouch, yes I'll revert that. I played with this permission

[jira] [Commented] (LUCENE-9796) fix SortedDocValues to no longer extend BinaryDocValues

2021-03-01 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292769#comment-17292769 ] Bruno Roustant commented on LUCENE-9796: +1 > fix SortedDocValues to no longer extend

[jira] [Commented] (LUCENE-9815) PerField formats can select the format based on FieldInfo

2021-03-01 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292768#comment-17292768 ] Bruno Roustant commented on LUCENE-9815: +1 on LUCENE-9796 I'll close this PR and try to find

[jira] [Resolved] (LUCENE-9815) PerField formats can select the format based on FieldInfo

2021-03-01 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved LUCENE-9815. Resolution: Won't Do > PerField formats can select the format based on FieldInfo >

[jira] [Assigned] (SOLR-15170) Elevation file in data dir not working in Solr Cloud

2021-03-01 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant reassigned SOLR-15170: - Assignee: Bruno Roustant > Elevation file in data dir not working in Solr Cloud >

[jira] [Commented] (SOLR-15170) Elevation file in data dir not working in Solr Cloud

2021-03-01 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292730#comment-17292730 ] Bruno Roustant commented on SOLR-15170: --- I'll have a look soon > Elevation file in data dir not

[jira] [Commented] (LUCENE-9815) PerField formats can select the format based on FieldInfo

2021-02-28 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292518#comment-17292518 ] Bruno Roustant commented on LUCENE-9815: [~rcmuir] do you mean always compressing sorted

[jira] [Updated] (LUCENE-9815) PerField formats can select the format based on FieldInfo

2021-02-28 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated LUCENE-9815: --- Description: PerFieldDocValuesFormat and PerFieldPostingsFormat currently only select the

[jira] [Created] (LUCENE-9815) PerField formats can select the format based on FieldInfo

2021-02-28 Thread Bruno Roustant (Jira)
Bruno Roustant created LUCENE-9815: -- Summary: PerField formats can select the format based on FieldInfo Key: LUCENE-9815 URL: https://issues.apache.org/jira/browse/LUCENE-9815 Project: Lucene - Core

[jira] [Resolved] (SOLR-15038) Add elevateDocsWithoutMatchingQ and onlyElevatedRepresentative parameters to elevation functionality

2021-02-17 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved SOLR-15038. --- Fix Version/s: 8.9 Resolution: Fixed Thanks [~kaessmann] > Add

[jira] [Commented] (SOLR-15038) Add elevateDocsWithoutMatchingQ and onlyElevatedRepresentative parameters to elevation functionality

2021-02-16 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285321#comment-17285321 ] Bruno Roustant commented on SOLR-15038: --- The PR sounds good to me. I'll merge soon. > Add

[jira] [Updated] (LUCENE-9663) Adding compression to terms dict from SortedSet/Sorted DocValues

2021-02-15 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated LUCENE-9663: --- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks [~Jaison], this

[jira] [Commented] (SOLR-15038) Add elevateDocsWithoutMatchingQ and onlyElevatedRepresentative parameters to elevation functionality

2021-02-15 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284798#comment-17284798 ] Bruno Roustant commented on SOLR-15038: --- Thanks for the PR. I have some comments/questions there.

[jira] [Commented] (LUCENE-9663) Adding compression to terms dict from SortedSet/Sorted DocValues

2021-02-09 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281779#comment-17281779 ] Bruno Roustant commented on LUCENE-9663: I'm ready to merge. I think it could go to 8.9 branch

[jira] [Commented] (LUCENE-9663) Adding compression to terms dict from SortedSet/Sorted DocValues

2021-02-04 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278966#comment-17278966 ] Bruno Roustant commented on LUCENE-9663: The latest PR looks good. I'm going to merge it in a

[jira] [Resolved] (LUCENE-9646) Set BM25Similarity discountOverlaps via the constructor

2021-01-19 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved LUCENE-9646. Fix Version/s: master (9.0) Resolution: Fixed Thank you [~pmarty] > Set

[jira] [Assigned] (LUCENE-9646) Set BM25Similarity discountOverlaps via the constructor

2021-01-13 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant reassigned LUCENE-9646: -- Assignee: Bruno Roustant > Set BM25Similarity discountOverlaps via the constructor >

[jira] [Commented] (LUCENE-9646) Set BM25Similarity discountOverlaps via the constructor

2021-01-13 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264033#comment-17264033 ] Bruno Roustant commented on LUCENE-9646: I'm going to merge it tomorrow, on master only. > Set

[jira] [Resolved] (SOLR-15061) Fix NPE in SearchHandler when shards.info

2021-01-05 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved SOLR-15061. --- Fix Version/s: 8.8 Resolution: Fixed > Fix NPE in SearchHandler when shards.info >

[jira] [Comment Edited] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-05 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258851#comment-17258851 ] Bruno Roustant edited comment on LUCENE-9570 at 1/5/21, 11:51 AM: --

[jira] [Commented] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-05 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258851#comment-17258851 ] Bruno Roustant commented on LUCENE-9570: [~dweiss] Yes finally it's done. I pushed the commit

[jira] [Commented] (LUCENE-9646) Set BM25Similarity discountOverlaps via the constructor

2021-01-04 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258142#comment-17258142 ] Bruno Roustant commented on LUCENE-9646: I see that ClassicSimilarity constructor has a comment

[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2021-01-04 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated LUCENE-9570: --- Description: Review and correct all the javadocs before they're messed up by automatic

[jira] [Created] (SOLR-15061) Fix NPE in SearchHandler when shards.info

2020-12-24 Thread Bruno Roustant (Jira)
Bruno Roustant created SOLR-15061: - Summary: Fix NPE in SearchHandler when shards.info Key: SOLR-15061 URL: https://issues.apache.org/jira/browse/SOLR-15061 Project: Solr Issue Type: Bug

[jira] [Updated] (SOLR-15060) Introduce DelegatingDirectoryFactory

2020-12-23 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated SOLR-15060: -- Description: FilterDirectory already exists to delegate to a Directory, but there is no

[jira] [Updated] (SOLR-15060) Introduce DelegatingDirectoryFactory

2020-12-23 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated SOLR-15060: -- Description: FilterDirectory already exists to delegate to a Directory, but there is no

[jira] [Created] (SOLR-15060) Introduce DelegatingDirectoryFactory

2020-12-23 Thread Bruno Roustant (Jira)
Bruno Roustant created SOLR-15060: - Summary: Introduce DelegatingDirectoryFactory Key: SOLR-15060 URL: https://issues.apache.org/jira/browse/SOLR-15060 Project: Solr Issue Type: Improvement

[jira] [Resolved] (SOLR-14975) Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames

2020-11-12 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved SOLR-14975. --- Resolution: Fixed Thanks Erick and David for the review! > Optimize

[jira] [Commented] (SOLR-14975) Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames

2020-11-06 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227546#comment-17227546 ] Bruno Roustant commented on SOLR-14975: --- I added a PR. I believe descriptors are superset of

[jira] [Resolved] (LUCENE-9455) ExitableTermsEnum (in ExitableDirectoryReader) should sample next()

2020-10-27 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved LUCENE-9455. Fix Version/s: 8.8 Resolution: Fixed Thanks [~zacharymorn] > ExitableTermsEnum

[jira] [Commented] (LUCENE-9455) ExitableTermsEnum (in ExitableDirectoryReader) should sample next()

2020-10-22 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219291#comment-17219291 ] Bruno Roustant commented on LUCENE-9455: I plan to merge tomorrow. > ExitableTermsEnum (in

[jira] [Commented] (LUCENE-9455) ExitableTermsEnum (in ExitableDirectoryReader) should sample next()

2020-10-22 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218810#comment-17218810 ] Bruno Roustant commented on LUCENE-9455: Your investigation revealed something I overlooked: 

[jira] [Commented] (LUCENE-9455) ExitableTermsEnum (in ExitableDirectoryReader) should sample next()

2020-10-21 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218367#comment-17218367 ] Bruno Roustant commented on LUCENE-9455: I propose to also sample the call to

[jira] [Commented] (LUCENE-9455) ExitableTermsEnum (in ExitableDirectoryReader) should sample next()

2020-10-21 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218292#comment-17218292 ] Bruno Roustant commented on LUCENE-9455: Thanks [~zacharymorn]. I added comments to the review.

[jira] [Commented] (LUCENE-9455) ExitableTermsEnum (in ExitableDirectoryReader) should sample next()

2020-10-15 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214491#comment-17214491 ] Bruno Roustant commented on LUCENE-9455: I planned to work on this (I still plan) but actually

[jira] [Resolved] (SOLR-14905) Update commons-io version to 2.8.0 due to security vulnerability

2020-10-01 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved SOLR-14905. --- Fix Version/s: 8.7 Resolution: Fixed Thanks [~nazerke], this is in. > Update

[jira] [Commented] (SOLR-14905) Update commons-io version to 2.8.0 due to security vulnerability

2020-09-30 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204715#comment-17204715 ] Bruno Roustant commented on SOLR-14905: --- Thanks Nazerke. I'm testing your PR on my side also. >

[jira] [Resolved] (SOLR-14819) SOLR has linear log operations that could trivially be linear

2020-09-03 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved SOLR-14819. --- Fix Version/s: 8.7 Resolution: Fixed Thanks Thomas for this fix. Please share the

[jira] [Resolved] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-09-02 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved SOLR-14782. --- Fix Version/s: 8.7 Resolution: Fixed No code change. Fixed by adding an example of

[jira] [Commented] (SOLR-14819) SOLR has linear log operations that could trivially be linear

2020-09-02 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189211#comment-17189211 ] Bruno Roustant commented on SOLR-14819: --- [~tommd] was there other issues found by Infer on Muse? >

[jira] [Commented] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-09-02 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189123#comment-17189123 ] Bruno Roustant commented on SOLR-14782: --- I added a PR for the doc improvement. I think it will be

[jira] [Comment Edited] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-09-02 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189098#comment-17189098 ] Bruno Roustant edited comment on SOLR-14782 at 9/2/20, 9:17 AM: [~smk] 

[jira] [Commented] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-09-02 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189098#comment-17189098 ] Bruno Roustant commented on SOLR-14782: --- [~smk] you should add a CharFilter to unescape for query

[jira] [Commented] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-09-01 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188353#comment-17188353 ] Bruno Roustant commented on SOLR-14782: --- Ok, so I understand the expectation of unescaping in your

[jira] [Comment Edited] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-09-01 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188251#comment-17188251 ] Bruno Roustant edited comment on SOLR-14782 at 9/1/20, 8:15 AM: [~smk] 

[jira] [Commented] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-09-01 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188251#comment-17188251 ] Bruno Roustant commented on SOLR-14782: --- [~smk] what is the analyzer defined in your schema for the

[jira] [Comment Edited] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-08-31 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187563#comment-17187563 ] Bruno Roustant edited comment on SOLR-14782 at 8/31/20, 8:45 AM: - [~smk] 

[jira] [Commented] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-08-31 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187563#comment-17187563 ] Bruno Roustant commented on SOLR-14782: --- [~smk] could you retry to attach the patch? The current

[jira] [Commented] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-08-31 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187479#comment-17187479 ] Bruno Roustant commented on SOLR-14782: --- Looking into this. > QueryElevationComponent does not

[jira] [Assigned] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-08-31 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant reassigned SOLR-14782: - Assignee: Bruno Roustant > QueryElevationComponent does not handle escaped query terms

[jira] [Commented] (LUCENE-9455) ExitableTermsEnum (in ExitableDirectoryReader) should sample next()

2020-08-12 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176316#comment-17176316 ] Bruno Roustant commented on LUCENE-9455: +1 > ExitableTermsEnum (in ExitableDirectoryReader)

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2020-08-11 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175583#comment-17175583 ] Bruno Roustant commented on LUCENE-9379: [~Raji] maybe a better approach would be to have one

[jira] [Updated] (LUCENE-9379) Directory based approach for index encryption

2020-07-13 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated LUCENE-9379: --- Description: +Important+: This Lucene Directory wrapper approach is to be considered only

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2020-07-13 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156566#comment-17156566 ] Bruno Roustant commented on LUCENE-9379: I'm going to pause my work on this for some time, until

[jira] [Commented] (LUCENE-9356) Add tests for corruptions caused by byte flips

2020-07-06 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151951#comment-17151951 ] Bruno Roustant commented on LUCENE-9356: [8.6 release manager] Is this issue resolved

[jira] [Resolved] (LUCENE-9191) Fix linefiledocs compression or replace in tests

2020-07-06 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved LUCENE-9191. Resolution: Fixed [8.6 release manager] It seems to me this issue is resolved. I change

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2020-07-06 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151920#comment-17151920 ] Bruno Roustant commented on LUCENE-9379: I tested with FST ON-HEAP: we gain +15% to +20% perf on

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2020-07-06 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151918#comment-17151918 ] Bruno Roustant commented on LUCENE-9379: TaskQPS Lucene86 StdDevQPS EncryptionTim StdDev Pct

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2020-07-06 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151915#comment-17151915 ] Bruno Roustant commented on LUCENE-9379: I ran the benchmarks to measure the perf impact of this

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2020-07-06 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151914#comment-17151914 ] Bruno Roustant commented on LUCENE-9379: [~rcmuir] makes an important callout in the PR. A

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2020-07-01 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149694#comment-17149694 ] Bruno Roustant commented on LUCENE-9379: Watchers, I need your help. I need to know how you

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2020-07-01 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149691#comment-17149691 ] Bruno Roustant commented on LUCENE-9379: I updated the PR. Now it is functional and complete,

[jira] [Updated] (SOLR-14537) Improve performance of ExportWriter

2020-06-30 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated SOLR-14537: -- Fix Version/s: (was: 8.6) > Improve performance of ExportWriter >

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2020-06-24 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143886#comment-17143886 ] Bruno Roustant commented on LUCENE-9379: First PR, functional but incomplete. The idea of using

[jira] [Comment Edited] (LUCENE-9379) Directory based approach for index encryption

2020-06-23 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136783#comment-17136783 ] Bruno Roustant edited comment on LUCENE-9379 at 6/23/20, 12:51 PM: --- So

[jira] [Commented] (LUCENE-9286) FST arc.copyOf clones BitTables and this can lead to excessive memory use

2020-06-19 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140505#comment-17140505 ] Bruno Roustant commented on LUCENE-9286: Maybe we miss a benchmark on FSTEnum traversal speed?

[jira] [Comment Edited] (LUCENE-9379) Directory based approach for index encryption

2020-06-16 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136783#comment-17136783 ] Bruno Roustant edited comment on LUCENE-9379 at 6/16/20, 4:25 PM: -- So I

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2020-06-16 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136783#comment-17136783 ] Bruno Roustant commented on LUCENE-9379: So I plan to implement an EncryptingDirectory extending

[jira] [Resolved] (LUCENE-9397) UniformSplit supports encodable fields metadata

2020-06-11 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved LUCENE-9397. Fix Version/s: 8.6 Resolution: Fixed Thanks [~dsmiley] for the review. >

[jira] [Commented] (LUCENE-9397) UniformSplit supports encodable fields metadata

2020-06-11 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133028#comment-17133028 ] Bruno Roustant commented on LUCENE-9397: Currently we use the encoder interface to cypher term

  1   2   3   >