[GitHub] [lucene] jtibshirani commented on a diff in pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-20 Thread GitBox
jtibshirani commented on code in PR #992: URL: https://github.com/apache/lucene/pull/992#discussion_r926196192 ## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java: ## @@ -203,8 +204,11 @@ private NeighborQueue searchLevel( return results; } -

[GitHub] [lucene] jtibshirani commented on a diff in pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-13 Thread GitBox
jtibshirani commented on code in PR #992: URL: https://github.com/apache/lucene/pull/992#discussion_r920371282 ## lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java: ## @@ -24,28 +24,40 @@ import org.apache.lucene.index.DocIDMerger; import

[GitHub] [lucene] jtibshirani commented on a diff in pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-13 Thread GitBox
jtibshirani commented on code in PR #992: URL: https://github.com/apache/lucene/pull/992#discussion_r919842519 ## lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldKnnVectorsFormat.java: ## @@ -102,9 +104,22 @@ private class FieldsWriter extends KnnVectorsWriter {

[GitHub] [lucene] jtibshirani commented on a diff in pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-07 Thread GitBox
jtibshirani commented on code in PR #992: URL: https://github.com/apache/lucene/pull/992#discussion_r916054211 ## lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldKnnVectorsFormat.java: ## @@ -102,9 +104,22 @@ private class FieldsWriter extends KnnVectorsWriter {

[GitHub] [lucene] jtibshirani commented on a diff in pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-06-30 Thread GitBox
jtibshirani commented on code in PR #992: URL: https://github.com/apache/lucene/pull/992#discussion_r910836731 ## lucene/core/src/java/org/apache/lucene/index/VectorValuesWriter.java: ## @@ -26,233 +26,153 @@ import org.apache.lucene.codecs.KnnVectorsWriter; import