[GitHub] [lucene] mocobeta commented on pull request #540: LUCENE-10312: Add PersianStemmer

2022-05-07 Thread GitBox
mocobeta commented on PR #540: URL: https://github.com/apache/lucene/pull/540#issuecomment-1120231855 @NightOwl888 I opened https://issues.apache.org/jira/browse/LUCENE-10561 for them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [lucene] mocobeta commented on pull request #540: LUCENE-10312: Add PersianStemmer

2022-05-07 Thread GitBox
mocobeta commented on PR #540: URL: https://github.com/apache/lucene/pull/540#issuecomment-1120161904 I just made a small change on it https://github.com/apache/lucene/pull/540/commits/050cbf107dbd58a8d82275056a2831e746294afb. Looks great, thank you @raminmjj and @NightOwl888! I'm

[GitHub] [lucene] mocobeta commented on pull request #540: LUCENE-10312: Add PersianStemmer

2022-05-06 Thread GitBox
mocobeta commented on PR #540: URL: https://github.com/apache/lucene/pull/540#issuecomment-1119710029 FYI, the feature freeze for the next release will be 10th May, according to the proposal for 9.2 release at Lucene's dev mail list. We still have a few more days until then, so I

[GitHub] [lucene] mocobeta commented on pull request #540: LUCENE-10312: Add PersianStemmer

2022-05-06 Thread GitBox
mocobeta commented on PR #540: URL: https://github.com/apache/lucene/pull/540#issuecomment-1119459461 I left some minor comments. I suppose we need a [CHANGES](https://github.com/apache/lucene/blob/main/lucene/CHANGES.txt) entry in the 9.2.0 New Features section. Could you add the line?

[GitHub] [lucene] mocobeta commented on pull request #540: LUCENE-10312: Add PersianStemmer

2022-05-05 Thread GitBox
mocobeta commented on PR #540: URL: https://github.com/apache/lucene/pull/540#issuecomment-1119184125 > I added "PersianStem" in org.apache.lucene.analysis.TokenFilterFactory file. Yes it's correct, now this has passed the tests/checks. -- This is an automated message from the

[GitHub] [lucene] mocobeta commented on pull request #540: LUCENE-10312: Add PersianStemmer

2022-05-05 Thread GitBox
mocobeta commented on PR #540: URL: https://github.com/apache/lucene/pull/540#issuecomment-1118861297 I'm sorry for the late response. I just kicked the CI - I'll take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub