mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1125179505
FYI, it's oss with decent licenses so I created a repository for the new
mascots.
https://github.com/mocobeta/unofficial-lucene-mascot
--
This is an automated message from the Apache
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1120209168
The favicon looks good to me as is, thanks and sorry for the noise!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1120193605
I think this version is more suitable for small icons if you like this.
(transparent)
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1120188747
Oh, thanks!
Yes I filled the hand with white (without border) to put batler's gloves on
Duke.
Maybe Lucene's logo should be larger for a favicon. Let me adjust it.
--
This is an
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1120186289
...and here's the Unicode Policeman version (final). Sorry again I need
something while I'm waiting for a time-consuming batch.
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1120164101
@uschindler Sure, please feel free to download and use it anywhere. It's a
collage of images from [Duke Project
(BSD)](https://wiki.openjdk.java.net/display/duke), Lucene Logo (AL2), and
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1120123174
here's Jenkins flavoured Policeman. sorry i might be a bit tired.
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1119609843
> The Backwards Compatibility Policeman
couldn't resist.
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1119154290
> Liftbot was disabled by INFRA.
Many thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118816930
Ah sorry for my vague comment, I know the difference between URI and URL;
and I understand there is no problem in using URL here.
I think we can ship this with 9.2? As an engineer
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118651872
> I would like URI more,
The same is true for me. We'd need URI, not URL...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118638144
> I see no problem in this PR - it does not make it worse, just better.
Thanks @uschindler, I totally agree with that.
I am +1 to this PR and keeping IOSupplier-based ones
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118561015
I have complex feelings about it and I understand both opinions...
Current APIs in 9.x to load custom resources are not perfect (or bad, I dare
to say), meanwhile
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118353023
Thanks for explaining, then I don't have an objection to forward porting;
maybe we'll need it to make it possible to load the resources from another jar.
--
This is an automated message
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118340545
Personally, I don't think we should allow users to load resources from
anyware... It's not the sensible way to load the dictionary resources as far as
I know. If you need external
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118326675
(As for sonatype-lift bot, it repeatedly reports the same warnings per push;
I once tried to silence it and gave up... I'd agree with disabling it for
lucene.)
--
This is an automated
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118316633
> should be maybe add a note to the deprecated javadocs that the deprecated
ctor no longer works with classpath resources and always loads the default one?
> Or should we change it to
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118313342
Thank you @uschindler, I am fine with this!
> This is against 9.x branch, but can be forward ported to main.
I'm inclined to add these URL-based constructors only to 9.x for
18 matches
Mail list logo
