[GitHub] [lucene] romseygeek commented on pull request #11807: No need to rewrite queries in unified highlighter

2023-01-13 Thread GitBox
romseygeek commented on PR #11807: URL: https://github.com/apache/lucene/pull/11807#issuecomment-1381532407 Oops, yes, I should have backported it at the time. Will do that now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene] romseygeek commented on pull request #11807: No need to rewrite queries in unified highlighter

2022-10-01 Thread GitBox
romseygeek commented on PR #11807: URL: https://github.com/apache/lucene/pull/11807#issuecomment-1264427197 I ported the test in https://issues.apache.org/jira/secure/attachment/12919819/TestUnifiedHighlighterSurround.java to latest main, and I can confirm that it fails if you set

[GitHub] [lucene] romseygeek commented on pull request #11807: No need to rewrite queries in unified highlighter

2022-09-24 Thread GitBox
romseygeek commented on PR #11807: URL: https://github.com/apache/lucene/pull/11807#issuecomment-1256931459 I thought the changes you made for unrecognized queries fixed the issues with the surround query parser? If not it would be good to implement query visitors for the queries that it