uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1120195919
OK changed it. The transparent one is not good for the headshot icon in the
black bar (the color of bar is defined by jenkins and not easy to change). The
Image is injected by the
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1120187130
I replaced the logo: https://jenkins.thetaphi.de/
The favicon needs to be transparent, have to figure out how to do this.
Problem are the hands have no border.
--
This is an
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1120159975
Do you allow to place this image on the Policeman Jenkins Server as Logo
instead of the old picture?
--
This is an automated message from the Apache Git Service.
To respond to the
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1119699944
See #871 for the port to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1119664675
Changes added waiting for precommit checks before merge. Will open another
PR for the forward port of the URL APIs.
--
This is an automated message from the Apache Git Service.
To
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1119600582
OK great, I will add some migration text and a good changes entry. So we
have restored 9.0/earlier behaviour. Thanks @msokolov for trying out.
Sorry for the noise, but luckily
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1119321941
I did some more changes to the inconsistent API. We cannot support all "old"
usage. If somebody calls the deprecated TokenInfoDictionary ctor with a null
path, heshe gets a message to
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1119059880
Hi @msokolov: I restored the original behaviour of the deprecated ctor.
Could you try with your original code of 9.0 using the deprecated APIs that the
custom dictionaries are loaded
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1119040833
Liftbot was disabled by INFRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118958254
I know how to disable lift it by telling him to scan no files at all: we can
place a gitignore like file
--
This is an automated message from the Apache Git Service.
To respond to the
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118870659
I pushed a fix forthe deprecated one (+ test). I will fix Nori when back at
home.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118848400
I think I can fix the old ctor so it works again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118843405
I still don't know if we can fix the deprecated ctors to handle the
CLASSPATH resource name correctly. In my original LUCENE-10335 change it was
still working (we had a test for it), but
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118841012
Sure, I would proceed with this plan and merge to 9.x and main. If we have
better ideas (like proposed earlier) for main we can change it there.
--
This is an automated message from
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118665915
> > I would like URI more,
>
> The same is true for me. We'd need URI, not URL...
The difference is that URI is just an identificator, but to get an
InputStream you need to
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118611460
The alternative would be - as said before - remove Path ctors and use
IOSupplier only. But that's worse (maybe it prevents people from doing this,
haha).
--
This is an automated
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118606210
To come back to current issue: I see no problem in this PR it does not make
it worse, just better. Path and URI are just holders of a resource. Path is
used for filesystem, URL is
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118585168
> Also - I don't really buy the idea that we can't support binary file
formats - the entire index is filled with binary files. In this case we provide
tools for generating these files,
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118462741
I will leave that PR open for discussion. I just implemented the minimal
approach + test to make the API compatible to classpath.
We can still allow to use the IOSuppliers, but
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118457174
> The format is not proprietary, it was promoted by Mecab I think, which is
the tool used to train the dictionary, and is open-source.
It is proprietary because the FST in the
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118442012
Let's give @msokolov a chance to comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118422000
In short: Some people like Mike Sokolov at Amazon wants to load custom
ConnectionCosts and TermInfoDicts and Unk dicts from custom resources. This was
working previously with file system
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118408717
OK. I opened this PR against 9.x because it makes it easier to add the
changes in deprecation messages. When forward porting just tell the
merge/cherrypick on main to "use theirs".
--
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118346475
> Personally, I don't think we should allow users to load resources from
anyware... It's not the sensible way to load the dictionary resources as far as
I know. If you need external
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118332065
See
[TikaInputStream](https://tika.apache.org/1.28.2/api/org/apache/tika/io/TikaInputStream.html#get-java.net.URL-org.apache.tika.metadata.Metadata-)
for an example that allow URL next
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118329537
> (As for sonatype-lift bot, it repeatedly reports the same warnings per
push; I once tried to silence it and gave up... I'd agree with disabling it for
lucene.)
Especially as
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118328012
But yes, one workaround for Mike is to rebuild the JAR files. An alternative
that always works (outside module system) is to place the JAR file with the
resources in a separate JAR file
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118320435
> I'm inclined to add these URL-based constructors only to 9.x for the
temporal remedy; I'm afraid that people use this abusively. (like opening TCP
sockets to load resources from
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118309403
@mocobeta should be maybe add a note to the deprecated javadocs that the
deprecated ctor no longer works with classpath resources and always loads the
default one?
Or should we
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118282233
@sonatype-lift silence ignore shutup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118281755
Can someone disable this @sonatype-lift, makes no sense for Lucene as we are
no webservers.
--
This is an automated message from the Apache Git Service.
To respond to the message,
31 matches
Mail list logo
