[GitHub] [lucene] vigyasharma commented on pull request #12013: Clear thread local values on UTF8TaxonomyWriterCache.close()

2023-01-17 Thread GitBox
vigyasharma commented on PR #12013: URL: https://github.com/apache/lucene/pull/12013#issuecomment-1386565076 PR - https://github.com/apache/lucene/pull/12093 to deprecate `UTF8TaxonomyWriterCache` in 9.x -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene] vigyasharma commented on pull request #12013: Clear thread local values on UTF8TaxonomyWriterCache.close()

2023-01-17 Thread GitBox
vigyasharma commented on PR #12013: URL: https://github.com/apache/lucene/pull/12013#issuecomment-1386545577 Created a separate PR - #12092 to remove support for `UTF8TaxonomyWriterCache` from main. Will close this PR. -- This is an automated message from the Apache Git Service. To

[GitHub] [lucene] vigyasharma commented on pull request #12013: Clear thread local values on UTF8TaxonomyWriterCache.close()

2022-12-29 Thread GitBox
vigyasharma commented on PR #12013: URL: https://github.com/apache/lucene/pull/12013#issuecomment-1367688658 > ... but I don't understand what this "cache" is doing and why it actually documents that it never frees memory. My understanding is that `TaxonomyWriterCache` caches