[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-26 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r639460784 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -1058,16 +1261,14 @@ public Status checkIndex(List onlySegments) throws

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-26 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r639460089 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -731,74 +810,173 @@ public Status checkIndex(List onlySegments) throws

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-26 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r639459734 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -731,74 +810,173 @@ public Status checkIndex(List onlySegments) throws

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-26 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r639457972 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -700,29 +771,37 @@ public Status checkIndex(List onlySegments) throws I

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-26 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r639455850 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -926,17 +1100,19 @@ public Status checkIndex(List onlySegments) throws

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-26 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r639455850 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -926,17 +1100,19 @@ public Status checkIndex(List onlySegments) throws

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-25 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r639417993 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -2795,12 +2972,14 @@ public Relation compare(byte[] minPackedValue, byte

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-25 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r639402016 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/TestUtil.java ## @@ -321,6 +321,7 @@ public static void syncConcurrentMerges(MergeSch

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-18 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r634957781 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -2795,12 +2972,14 @@ public Relation compare(byte[] minPackedValue, byte

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-18 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r634957136 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -926,17 +1100,19 @@ public Status checkIndex(List onlySegments) throws

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-18 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r634956303 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -216,6 +225,9 @@ /** Status of vectors */ public VectorV

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-18 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r634956106 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -468,6 +495,10 @@ private static void msg(PrintStream out, String msg) {

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-18 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r634953939 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -701,104 +765,196 @@ public Status checkIndex(List onlySegments) throws

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-18 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r634953443 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -488,8 +519,35 @@ public Status checkIndex() throws IOException { *

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-07 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r628697141 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -488,8 +503,35 @@ public Status checkIndex() throws IOException { *

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-07 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r628696357 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -731,40 +747,188 @@ public Status checkIndex(List onlySegments) throws

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-06 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r627960571 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -605,6 +610,15 @@ public Status checkIndex(List onlySegments) throws IO

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-06 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r627960267 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -810,6 +976,8 @@ public Status checkIndex(List onlySegments) throws IOE

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-06 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r627960267 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -810,6 +976,8 @@ public Status checkIndex(List onlySegments) throws IOE

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-06 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r627959173 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -731,40 +747,188 @@ public Status checkIndex(List onlySegments) throws