[GitHub] [lucene] zacharymorn commented on pull request #1006: LUCENE-10480: Move scoring from advance to TwoPhaseIterator#matches to improve disjunction within conjunction

2022-07-07 Thread GitBox
zacharymorn commented on PR #1006: URL: https://github.com/apache/lucene/pull/1006#issuecomment-1177230791 > Ah, that makes sense to me now! Thanks for explaining. No problem! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene] zacharymorn commented on pull request #1006: LUCENE-10480: Move scoring from advance to TwoPhaseIterator#matches to improve disjunction within conjunction

2022-07-06 Thread GitBox
zacharymorn commented on PR #1006: URL: https://github.com/apache/lucene/pull/1006#issuecomment-1177067295 > I don't understand why top-level disjunctions get faster but the change looks good to me. Oh sorry @jpountz I should have mentioned it explicitly as well. The benchmark

[GitHub] [lucene] zacharymorn commented on pull request #1006: LUCENE-10480: Move scoring from advance to TwoPhaseIterator#matches to improve disjunction within conjunction

2022-07-06 Thread GitBox
zacharymorn commented on PR #1006: URL: https://github.com/apache/lucene/pull/1006#issuecomment-1176956180 Here are the latest benchmark results: ``` TaskQPS baseline StdDevQPS my_modified_version StdDevPct diff p-value