ErickErickson commented on pull request #1613:
URL: https://github.com/apache/lucene-solr/pull/1613#issuecomment-653180860
Patrick:
This is a relatively recent change (failing on unsuppressed warnings).
The preferred solution is to to type the list, e.g.
List<String> lst = new ArrayList<>();
If that’s too difficult, you can add
@SupppressWarnings({“rawtypes”})
in this case you can probably add it right above the declaration. But please
try to solve it
correctly first by adding a type to the List.
Yeah, I know there are a zillion SuppressWarnings in the code; we’ve been
accruing
this kind of cruft for years. I recently went through and added lots of
SuppressWarnings so
we could get to the point of having a chance of not adding any new warnings
because
things fail. BTW, compilation should have failed well in advance of
precommit.
Second BTW, “the gradle way” is “gradlew check -x test”...
Oh, and if you are working on code anyway with SuppressWarnings and can fix
a few
of those too on the way by that would be great!
Best,
Erick
> On Jul 2, 2020, at 2:55 PM, Patrick Zhai <notificati...@github.com> wrote:
>
> List lst = new ArrayList();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
