[GitHub] [lucene-solr] HoustonPutman commented on pull request #1844: SOLR-14847: Create Solr Server TGZ

2020-09-10 Thread GitBox
HoustonPutman commented on pull request #1844: URL: https://github.com/apache/lucene-solr/pull/1844#issuecomment-690320665 Ahh ok, thank for clearing that up. Whenever I cleaned it up beforehand, the task worked fine. I've also tested changing actual files and the task unsurprisingly

[GitHub] [lucene-solr] HoustonPutman commented on pull request #1844: SOLR-14847: Create Solr Server TGZ

2020-09-10 Thread GitBox
HoustonPutman commented on pull request #1844: URL: https://github.com/apache/lucene-solr/pull/1844#issuecomment-690313852 I might be using it wrong, but I don't think the distTar task overwrites previously generated tars. I've tried changing the executable bit paths, and the tar that

[GitHub] [lucene-solr] HoustonPutman commented on pull request #1844: SOLR-14847: Create Solr Server TGZ

2020-09-09 Thread GitBox
HoustonPutman commented on pull request #1844: URL: https://github.com/apache/lucene-solr/pull/1844#issuecomment-689853640 So it turns out that `fileMode` isn't an option for `FileCopyDetails`, so it was applying it to the whole Copy operation instead. Changing it to `setMode` fixed

[GitHub] [lucene-solr] HoustonPutman commented on pull request #1844: SOLR-14847: Create Solr Server TGZ

2020-09-09 Thread GitBox
HoustonPutman commented on pull request #1844: URL: https://github.com/apache/lucene-solr/pull/1844#issuecomment-689833826 > from(..., { > filesMatching("**/*.sh", { > fileMode 0755 > }) > }) Sorry, forgot to mention this before. I tried that initially and it resulted in

[GitHub] [lucene-solr] HoustonPutman commented on pull request #1844: SOLR-14847: Create Solr Server TGZ

2020-09-09 Thread GitBox
HoustonPutman commented on pull request #1844: URL: https://github.com/apache/lucene-solr/pull/1844#issuecomment-689727987 I think I have addressed both of the issues I raised. This is an automated message from the Apache

[GitHub] [lucene-solr] HoustonPutman commented on pull request #1844: SOLR-14847: Create Solr Server TGZ

2020-09-09 Thread GitBox
HoustonPutman commented on pull request #1844: URL: https://github.com/apache/lucene-solr/pull/1844#issuecomment-689719861 Two issues I see currently. - The package is named `solr-packaging-.tgz` not `solr-.tgz`. This should be easily fixed by: `archiveBaseName = "solr"` - The