[GitHub] [lucene-solr] cammiemw commented on pull request #2097: LUCENE-9537

2021-01-29 Thread GitBox
cammiemw commented on pull request #2097: URL: https://github.com/apache/lucene-solr/pull/2097#issuecomment-770074489 Hi @mikemccand! The smoothingScore method requires a docId because the most important implementation of smoothingScore is in TermScorer, which uses the postingsEnum to get

[GitHub] [lucene-solr] cammiemw commented on pull request #2097: LUCENE-9537

2021-01-27 Thread GitBox
cammiemw commented on pull request #2097: URL: https://github.com/apache/lucene-solr/pull/2097#issuecomment-768751214 Hi @mikemccand, apologies for the failed test! Unfortunately, I cannot replicate the error in my environments and gradle test as well as that specific test come back succe

[GitHub] [lucene-solr] cammiemw commented on pull request #2097: LUCENE-9537

2021-01-21 Thread GitBox
cammiemw commented on pull request #2097: URL: https://github.com/apache/lucene-solr/pull/2097#issuecomment-764873350 Thanks @mikemccand! I have added an entry in CHANGES.txt under API changes. I am hoping to be able to add more of the Indri search engine functionality that build up

[GitHub] [lucene-solr] cammiemw commented on pull request #2097: LUCENE-9537

2021-01-21 Thread GitBox
cammiemw commented on pull request #2097: URL: https://github.com/apache/lucene-solr/pull/2097#issuecomment-764873350 Thanks @mikemccand! I have added an entry in CHANGES.txt under API changes. I am hoping to be able to add more of the Indri search engine functionality that build up

[GitHub] [lucene-solr] cammiemw commented on pull request #2097: LUCENE-9537

2021-01-12 Thread GitBox
cammiemw commented on pull request #2097: URL: https://github.com/apache/lucene-solr/pull/2097#issuecomment-759133439 Hi @mikemccand! I think the issues are fixed in my latest commit. Let me know if there is anything else that you think I need. Thanks!

[GitHub] [lucene-solr] cammiemw commented on pull request #2097: LUCENE-9537

2020-12-01 Thread GitBox
cammiemw commented on pull request #2097: URL: https://github.com/apache/lucene-solr/pull/2097#issuecomment-736443177 An alternative to touching so many low-level lucene classes would be to create a separate interface with only the smoothingScore method. Then the only Lucene class that I