dweiss commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-727827305
I've added changes entry and committed it in, thanks @zacharymorn !
This is an automated message from the
dweiss commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-726675884
No worries. I've pushed the code the way I think it should work - please
take a look, let me know if you don't understand something. I tested on Windows
and Linux, runs
dweiss commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-726599397
Thanks Zach. I looked at what you did with tests and I think this can be
done in a cleaner way that always works. I'll show you how, give me some time.
Also, update
dweiss commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-725917917
> On the other hand, I think these tests will break if run from IDEs. Do we
need to support that in this PR?
Oh, thanks! I'll take a look after I come back from work.
dweiss commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-725648046
Added the kill switch, Zach. I think you need to merge with master and then
update the overview file that Tomoko moved to package-info.java (grep for
"build-native-unix" and
dweiss commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-724287441
Byt. if we do have to add that explicit 'build.native' option then I'd
implement it as a task (graph) exclusion rather than project exclusion. Windows
users in particular
dweiss commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-724283052
Zach I've cleaned up the native build a bit - moved it under lucene/misc,
added Windows build (it does build the native library for me). I didn't check
whether it works on a
dweiss commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-723842876
bq. The windows equivalentWindowsDirectory.cpp still sits in misc module and
hasn't been moved over yet.
Ah... I didn't realize this is the case then - sorry. Give me
