[GitHub] [lucene-solr] dweiss commented on pull request #2077: LUCENE-9605: update snowball to d8cf01ddf37a, adds Yiddish

2020-11-12 Thread GitBox
dweiss commented on pull request #2077: URL: https://github.com/apache/lucene-solr/pull/2077#issuecomment-726093808 Duh. I see it now... darn, sorry for the noise. This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr] dweiss commented on pull request #2077: LUCENE-9605: update snowball to d8cf01ddf37a, adds Yiddish

2020-11-12 Thread GitBox
dweiss commented on pull request #2077: URL: https://github.com/apache/lucene-solr/pull/2077#issuecomment-726091990 This one? https://github.com/apache/lucene-solr/pull/2077/files#diff-455f29a3b76e17c21dded0a5f1b853145bfa7e6e5f1f36c52012a5f124e14ac2R589

[GitHub] [lucene-solr] dweiss commented on pull request #2077: LUCENE-9605: update snowball to d8cf01ddf37a, adds Yiddish

2020-11-12 Thread GitBox
dweiss commented on pull request #2077: URL: https://github.com/apache/lucene-solr/pull/2077#issuecomment-725922377 LGTM. Just scratching my head about one thing - the generator has that extra field now yet the patch doesn't contain diffs for other languages - only Serbian and Yiddish?