[GitHub] [lucene-solr] jtibshirani commented on pull request #1817: Improve how Asserting* classes handle singleton doc values.

2020-09-02 Thread GitBox
jtibshirani commented on pull request #1817: URL: https://github.com/apache/lucene-solr/pull/1817#issuecomment-685981921 Thanks for the review. Let me know if I should add a changelog entry or issue number (I wasn't sure what to do for smaller test fixes like this).

[GitHub] [lucene-solr] jtibshirani commented on pull request #1817: Improve how Asserting* classes handle singleton doc values.

2020-09-01 Thread GitBox
jtibshirani commented on pull request #1817: URL: https://github.com/apache/lucene-solr/pull/1817#issuecomment-685192326 I noticed this when debugging a bad bug in `IndexSortSortedNumericDocValuesRangeQuery` that wasn't caught by tests. As a follow-up I plan to make at least one more