[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2022: LUCENE-9004: KNN vector search using NSW graphs

2020-11-12 Thread GitBox
mikemccand commented on a change in pull request #2022: URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r522164296 ## File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java ## @@ -74,6 +74,18 @@ public BytesRef binaryValue() throws

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2022: LUCENE-9004: KNN vector search using NSW graphs

2020-11-09 Thread GitBox
mikemccand commented on a change in pull request #2022: URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r519895947 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorReader.java ## @@ -22,39 +22,60 @@ import

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2022: LUCENE-9004: KNN vector search using NSW graphs

2020-11-09 Thread GitBox
mikemccand commented on a change in pull request #2022: URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r519881970 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2022: LUCENE-9004: KNN vector search using NSW graphs

2020-11-09 Thread GitBox
mikemccand commented on a change in pull request #2022: URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r519873455 ## File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java ## @@ -74,6 +74,18 @@ public BytesRef binaryValue() throws

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2022: LUCENE-9004: KNN vector search using NSW graphs

2020-11-06 Thread GitBox
mikemccand commented on a change in pull request #2022: URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r518797861 ## File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java ## @@ -74,6 +74,18 @@ public BytesRef binaryValue() throws