[GitHub] [lucene-solr] mikemccand commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-10 Thread GitBox
mikemccand commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#issuecomment-612095846 ++! This is an automated message from the Apache Git

[GitHub] [lucene-solr] mikemccand commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-10 Thread GitBox
mikemccand commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#issuecomment-612056038 > I assume this time the limited resource are the hands using the keyboard :) Indeed!

[GitHub] [lucene-solr] mikemccand commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-10 Thread GitBox
mikemccand commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#issuecomment-612055874 OK indexing throughput is noisy, but net/net I think there's no perf impact. This is `wikimediumall` from `luceneutil` on

[GitHub] [lucene-solr] mikemccand commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-09 Thread GitBox
mikemccand commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#issuecomment-611739568 I will try to run benchmarks soon now, sorry for the delay. We are furiously 3D printing / laser cutting face shields for

[GitHub] [lucene-solr] mikemccand commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-08 Thread GitBox
mikemccand commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#issuecomment-610930218 Hmm here's a more exotic test failure, also likely not caused by the changes here. The fun things you learn when beasting

[GitHub] [lucene-solr] mikemccand commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-07 Thread GitBox
mikemccand commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#issuecomment-610379028 I'll look again -- in the meantime I beasted all Lucene (core + modules) tests and hit this failure. It does not