[GitHub] [lucene-solr] rmuir commented on pull request #2077: LUCENE-9605: update snowball to d8cf01ddf37a, adds Yiddish

2020-11-12 Thread GitBox
rmuir commented on pull request #2077: URL: https://github.com/apache/lucene-solr/pull/2077#issuecomment-726094165 It's not your fault, this is why its good to try to work down this patch file, it is confusing. This is an

[GitHub] [lucene-solr] rmuir commented on pull request #2077: LUCENE-9605: update snowball to d8cf01ddf37a, adds Yiddish

2020-11-12 Thread GitBox
rmuir commented on pull request #2077: URL: https://github.com/apache/lucene-solr/pull/2077#issuecomment-726092971 There isn't any changes here. It's confusing because its showing a diff of a patch file, and github is highlighting something in green that isn't a change. The only thing

[GitHub] [lucene-solr] rmuir commented on pull request #2077: LUCENE-9605: update snowball to d8cf01ddf37a, adds Yiddish

2020-11-12 Thread GitBox
rmuir commented on pull request #2077: URL: https://github.com/apache/lucene-solr/pull/2077#issuecomment-726089629 > Just scratching my head about one thing - the generator has that extra field now yet the patch doesn't contain diffs for other languages - only Serbian and Yiddish?