s1monw commented on a change in pull request #2022:
URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r521992111



##########
File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java
##########
@@ -74,6 +74,18 @@ public BytesRef binaryValue() throws IOException {
     throw new UnsupportedOperationException();
   }
 
+  /**
+   * Return the k nearest neighbor documents as determined by comparison of 
their vector values
+   * for this field, to the given vector, by the field's search strategy. If 
the search strategy is
+   * reversed, lower values indicate nearer vectors, otherwise higher scores 
indicate nearer
+   * vectors. Unlike relevance scores, vector scores may be negative.
+   * @param target the vector-valued query
+   * @param k      the number of docs to return
+   * @param fanout control the accuracy/speed tradeoff - larger values give 
better recall at higher cost

Review comment:
       @mikemccand it was pushed but removed again in 
https://issues.apache.org/jira/browse/LUCENE-9257 a little while ago. I get why 
it's removed but it seems useful maybe we add it back?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to