[GitHub] [lucene-solr] s1monw commented on pull request #1789: LUCENE-9484: Allow sorting an index after the fact

2020-09-01 Thread GitBox
s1monw commented on pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789#issuecomment-684658664 @jpountz I applied your comments and moved the inner classes from the reader to the classes where they are mainly used. We should have done that earlier then we would have

[GitHub] [lucene-solr] s1monw commented on pull request #1789: LUCENE-9484: Allow sorting an index after the fact

2020-08-31 Thread GitBox
s1monw commented on pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789#issuecomment-683654109 @jpountz I pushed some improvements and inherited from CodecReader, can you take another look This is an

[GitHub] [lucene-solr] s1monw commented on pull request #1789: LUCENE-9484: Allow sorting an index after the fact

2020-08-27 Thread GitBox
s1monw commented on pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789#issuecomment-681983796 > It's nice that this change is so straightforward. It makes me realize I don't know what happens today if we specify an index Sort and then open an existing index that is