tflobbe opened a new pull request #1448: URL: https://github.com/apache/lucene-solr/pull/1448
While looking at SOLR-13289 I noticed this situation. If I create a collector with `numHits` greater than `totalHitsThreshold`, and the number of hits in the query is somewhere between those two numbers, collector’s `totalHitRelation` will be `TotalHits.Relation.GREATER_THAN_OR_EQUAL_TO`, however I expect the count to be accurate in this situation, right? Should this be `TotalHits.Relation.EQUAL_TO`? Maybe make `totalHitsThreshold = Max(totalHitsThreshold, humHits)` on creation? Added a test that fails. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
