[GitHub] [lucene-solr] uschindler edited a comment on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-08 Thread GitBox
uschindler edited a comment on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688665608 I don't think that's the case. Running the whole thing a second time is quite fast. I remember that all those filters in Maven and Ant are based on the same code

[GitHub] [lucene-solr] uschindler edited a comment on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-07 Thread GitBox
uschindler edited a comment on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688514787 Hi, I was able to prevent gradle from scanning duplicates: ```gradle // Don't go into subprojects (scanned separately). childProjects.keySet().each{

[GitHub] [lucene-solr] uschindler edited a comment on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-07 Thread GitBox
uschindler edited a comment on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688203183 I committed my changes. You see the duplicate scanning now, because it reports hadoop errors in `:solr`, because the exclude does not work correctly. In fact

[GitHub] [lucene-solr] uschindler edited a comment on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-07 Thread GitBox
uschindler edited a comment on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688194137 Hi, I am reviewing: Actually the whole task does not scan any files, as the "extensions" are wrongly expanded. Should be `**/*.${it}`. I will commit a fix