zacharymorn commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-727123057
> No worries. I've pushed the code the way I think it should work - please
take a look, let me know if you don't understand something. I tested on Windows
and Linux, run
zacharymorn commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-726643548
> Thanks Zach. I looked at what you did with tests and I think this can be
done in a cleaner way that always works. I'll show you how, give me some time.
Sounds go
zacharymorn commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-726467539
> > On the other hand, I think these tests will break if run from IDEs. Do
we need to support that in this PR?
>
> Oh, thanks! I'll take a look after I come back f
zacharymorn commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-725853994
> All of it looks good, Zach. Sorry about my lack of consistency here but on
as second thought I think we should add a safety switch of perhaps
force-disabling the nativ
zacharymorn commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-725807511
> Added the kill switch, Zach. I think you need to merge with master and
then update the overview file that Tomoko moved to package-info.java (grep for
"build-native-uni
zacharymorn commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-724434703
> Zach I've cleaned up the native build a bit - moved it under lucene/misc,
added Windows build (it does build the native library for me). I didn't check
whether it work
zacharymorn commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-723700269
> I added some general comments. The code, as it is now, doesn't compile for
me on Windows (fails to find includes as they're under win32). Even if I add
the includes, i
