[GitHub] [lucene-solr] zacharymorn edited a comment on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-20 Thread GitBox
zacharymorn edited a comment on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-731491257 > > > Second, it is extremely experimental and not clear when it provides benefits / what risks there are / etc. We need to learn much more about it, in diverse

[GitHub] [lucene-solr] zacharymorn edited a comment on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
zacharymorn edited a comment on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729389857 > > I think we just need to resolve the "replace now or not" question? > > I'd like to improve the testcase and use a real index on top of a combination