dweiss commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1868599503
> But suggesting everyone to "fix their Windows" or wait for some Java 27 to
fix this or otherwise run the tests with the SecurityManager completely off is
unnecessarily rigid IMO.
uschindler commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1868312157
Thanks Robert.
To clarify: This test is so important for data safety in Lucene that
silently disabling it on highly incompetent sysadmin's decisions is a No-Go.
rmuir commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1868309875
sorry, i'm late to the party. yes, the entire purpose of this is to ensure
tests only use ephemeral ports when binding. otherwise there will be port
conflicts. so we should not be
uschindler commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1868291983
P.S.: in Lucene we won't throw assumption violation exceptions. We have
LTC#assumeTrue for this.
--
This is an automated message from the Apache Git Service.
To respond to the
uschindler commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1868291255
Please also run Apache Solr test. It uses same config. Applying your
proposed fix will disable all integration tests. This is not the correct way to
fix this.
So an
uschindler commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1868290711
Sorry, your computer does not behave standards conform. Please report this
to your organisation.
There is no reason to change anything in Lucene.
--
This is an
sabi0 commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1868288499
Indeed, my machine has this:
```
Protocol tcp Dynamic Port Range
-
Start Port : 1024
Number of Ports : 20977
```
I do not know
uschindler commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1868281148
On Windows the dfeaults can also be changed, but OpenJDK does not read those
setting. Here is my Windows example:
```
> netsh int ipv4 show dynamicport tcp
uschindler commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1868280513
Oh I see you have Windows. On Windows it uses a hardcoded range. It is not
dynamic, so it looks like your windows system has changed it away from the
defaults!
We can't
uschindler commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1868277275
Hi,
it looks like your linux kernel has an extended ephemeral port range. The
RFC defines it to be 49152-65535 (see RFC 6335).
> The [range
sabi0 commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1868103845
My assumption was wrong. When the permission has port 0 the remote port
number is validated against the local system's "ephemeral port range":
```
if (policyLow == 0 &&
dweiss commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1868101808
Do you use multiple network interfaces? Are these normal network adapters or
something else? It's really unfortunate that it doesn't work for you out of the
box. Strange!
--
This
dweiss commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-186810
I'd like to understand why your system is different than mine (or Uwe's)...
It's great that you've found a workaround but it doesn't explain what's
happening and - as Uwe mentioned
sabi0 commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1868070476
My understanding of the situation is the following:
Dynamic / ephemeral is only applicable to a local port. Thus permission
`127.0.0.1:0/listen` allows to bind to a dynamic local
uschindler closed issue #12964: `TestStressLockFactories` fails on Windows in a
freshly cloned repository
URL: https://github.com/apache/lucene/issues/12964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
uschindler commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1868063156
You can always work around it by running the tests without security manager.
Read the gradle documentation about the responsible system properties, e.g.
uschindler commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1868061471
Hi,
Sorry no. The test is fine. This test and many more exist like this since
years. There's no need to change them or the policy file. Passing 0 as port
number on the
dweiss commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1867988464
I checked again, this time making sure it's Java 21 and the main branch:
--
This
dweiss commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1867978644
> How did you run it with Java 11? When I try that I get
>
> > ERROR: java version must be between 17 and 21, your version: 11
Hmm... I might have been on branch_9x -
sabi0 commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1867967493
I ran the test with Oracle's Java 17 and it failed in the same way:
```
1> Listening on /127.0.0.1:12778...
> java.security.AccessControlException: access denied
sabi0 commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1867958624
How did you run it with Java 11?
When I try that I get
> ERROR: java version must be between 17 and 21, your version: 11
--
This is an automated message from the Apache Git
dweiss commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1867895778
I've downloaded coretto (Windows 10):
```
>java -version
openjdk version "11.0.21" 2023-10-17 LTS
OpenJDK Runtime Environment Corretto-11.0.21.9.1 (build 11.0.21+9-LTS)
uschindler commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1867726243
Hi,
please let's not change this without understanding what the problem is. We
have not seen this issue anywhere (not even on Solr where this is used for
almost every test).
dweiss commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1867704697
You're the first person among many (including CIs) to have experienced this
problem, so I'd look at what exactly is causing this first - is it the JDK
distribution, is it something
sabi0 commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1867427249
Though I see the server also uses a dynamic port:
```
s.bind(new InetSocketAddress(hostname, 0));
```
Maybe the "ephemeral range" in the server JVM is different
sabi0 commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1867421666
After changing the project's `tests.policy` to
```
permission java.net.SocketPermission "127.0.0.1:1024-",
"accept,listen,resolve";
```
the tests pass on my side.
>
sabi0 commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1867408496
I have a vanilla Amazon Corretto JDK 17. And it has this:
```
// allows anyone to listen on dynamic ports
permission java.net.SocketPermission "localhost:0", "listen";
dweiss commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1867394243
I've checked the repro line and seed, works for me. On a second glance, it
looks like the security policy of your Java is restricting socket accept. Is it
possible that you have
dweiss commented on issue #12964:
URL: https://github.com/apache/lucene/issues/12964#issuecomment-1867383394
This must be something on your system preventing socket opening. No idea
what though.
--
This is an automated message from the Apache Git Service.
To respond to the message,
sabi0 opened a new issue, #12964:
URL: https://github.com/apache/lucene/issues/12964
### Description
> NOTE: test params are: codec=Asserting(Lucene99): {}, docValues:{},
maxPointsInLeafNode=189, maxMBSortInHeap=5.965018891538125,
sim=Asserting(RandomSimilarity(queryNorm=true): {}),
30 matches
Mail list logo
