s1monw commented on PR #12741:
URL: https://github.com/apache/lucene/pull/12741#issuecomment-1862531327
I wanted to give my $0.02 on this. I am not convinced that a 2% change on a
benchmark warrants a 6.2k SLoC addition to such an important codebase. I think
the differences in terms of
slow-J commented on PR #12741:
URL: https://github.com/apache/lucene/pull/12741#issuecomment-1808258638
> > I ran a new luceneutil benchmark on Saturday with my commit
[8ae598b](https://github.com/apache/lucene/commit/8ae598bae593e1faa4ff82a87f4cd45f120f1059)
(using Lucene99PostingsFormat)
mikemccand commented on PR #12741:
URL: https://github.com/apache/lucene/pull/12741#issuecomment-1808208970
> I ran a new luceneutil benchmark on Saturday with my commit
[8ae598b](https://github.com/apache/lucene/commit/8ae598bae593e1faa4ff82a87f4cd45f120f1059)
(using
slow-J commented on PR #12741:
URL: https://github.com/apache/lucene/pull/12741#issuecomment-1807962044
I ran a new luceneutil benchmark on Saturday with my commit
https://github.com/apache/lucene/commit/8ae598bae593e1faa4ff82a87f4cd45f120f1059
(using Lucene99PostingsFormat) as candidate
jpountz commented on PR #12741:
URL: https://github.com/apache/lucene/pull/12741#issuecomment-1807797987
Thanks both, I pushed an annotation, it should show up tomorrow. I hah high
expectations based on preliminary results from
https://github.com/apache/lucene/issues/12696#issue-1950239343
slow-J commented on PR #12741:
URL: https://github.com/apache/lucene/pull/12741#issuecomment-1806515360
I think that it's a little hard to tell with 1 datapoint due to noise, it
seems to be trending upwards in the `BooleanQuery` graphs, but I agree that
it's not obvious that there is a
gf2121 commented on PR #12741:
URL: https://github.com/apache/lucene/pull/12741#issuecomment-1805253760
FYI this great
[view](https://home.apache.org/~mikemccand/lucenebench/2023.11.09.18.02.58.html)
could be easier to see the impact of changes in single day for all tasks. It
seems some
jpountz commented on PR #12741:
URL: https://github.com/apache/lucene/pull/12741#issuecomment-1805220170
[Nightly benchmarks](https://home.apache.org/~mikemccand/lucenebench/) just
caught up this change, it's no obvious that there is a speedup.
--
This is an automated message from the
slow-J commented on code in PR #12741:
URL: https://github.com/apache/lucene/pull/12741#discussion_r1383744529
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99PostingsFormat.java:
##
@@ -0,0 +1,518 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mikemccand commented on PR #12741:
URL: https://github.com/apache/lucene/pull/12741#issuecomment-1795532339
Thank you @slow-J!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
slow-J commented on PR #12741:
URL: https://github.com/apache/lucene/pull/12741#issuecomment-1795505918
Thanks Mike and all reviewers!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mikemccand merged PR #12741:
URL: https://github.com/apache/lucene/pull/12741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mikemccand commented on code in PR #12741:
URL: https://github.com/apache/lucene/pull/12741#discussion_r1383233272
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99PostingsFormat.java:
##
@@ -0,0 +1,518 @@
+/*
+ * Licensed to the Apache Software Foundation
jpountz commented on PR #12741:
URL: https://github.com/apache/lucene/pull/12741#issuecomment-1792586157
For reference, I'm interested in taking advantage of the fact we're changing
the codec anyway to look into other smaller changes, like switching tail
postings from vints to
slow-J commented on PR #12741:
URL: https://github.com/apache/lucene/pull/12741#issuecomment-1790605861
Thanks @mikemccand and yes, the codec version bump is the majority of this
change :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
mikemccand commented on PR #12741:
URL: https://github.com/apache/lucene/pull/12741#issuecomment-1790294665
Thanks for tackling this / persisting @slow-J, especially the glorious fun
experience of having to "bump" the Codec version ;) A nice rite-of-passage in
this Lucene world!
--
slow-J commented on PR #12741:
URL: https://github.com/apache/lucene/pull/12741#issuecomment-1788786005
> Thanks @slow-J ! I left some minor comments about additional `90` -> `99`
refactoring.
Thanks @gf2121 , committed all the suggestions.
--
This is an automated message from the
gf2121 commented on code in PR #12741:
URL: https://github.com/apache/lucene/pull/12741#discussion_r1378509674
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99PostingsFormat.java:
##
@@ -0,0 +1,518 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
slow-J commented on code in PR #12741:
URL: https://github.com/apache/lucene/pull/12741#discussion_r1378259917
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/ForDeltaUtil.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
slow-J commented on code in PR #12741:
URL: https://github.com/apache/lucene/pull/12741#discussion_r1378259917
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/ForDeltaUtil.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
slow-J commented on PR #12741:
URL: https://github.com/apache/lucene/pull/12741#issuecomment-1787958483
Thanks for the suggestion, I added `Lucene90RWPostingsFormat` in latest
commit and made `Lucene90PostingsFormat` read-only.
--
This is an automated message from the Apache Git Service.
slow-J commented on code in PR #12741:
URL: https://github.com/apache/lucene/pull/12741#discussion_r1378112509
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/PForUtil.java:
##
@@ -0,0 +1,558 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
slow-J commented on code in PR #12741:
URL: https://github.com/apache/lucene/pull/12741#discussion_r1378112295
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/ForDeltaUtil.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
slow-J commented on code in PR #12741:
URL: https://github.com/apache/lucene/pull/12741#discussion_r1378112072
##
lucene/CHANGES.txt:
##
@@ -104,6 +104,8 @@ Optimizations
* GITHUB#12552: Make FSTPostingsFormat load FSTs off-heap. (Tony X)
+* GITHUB#12696: Change Postings
jpountz commented on code in PR #12741:
URL: https://github.com/apache/lucene/pull/12741#discussion_r1377911285
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/ForDeltaUtil.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
slow-J opened a new pull request, #12741:
URL: https://github.com/apache/lucene/pull/12741
We are still keeping PFOR for positions only.
This is a partial revert of https://github.com/apache/lucene/pull/69 which
brings back ForDeltaUtil.
Closes #12696
--
This is an
26 matches
Mail list logo
