dweiss commented on PR #12965:
URL: https://github.com/apache/lucene/pull/12965#issuecomment-1881815163
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dweiss merged PR #12965:
URL: https://github.com/apache/lucene/pull/12965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sabi0 commented on PR #12965:
URL: https://github.com/apache/lucene/pull/12965#issuecomment-1880698647
I've rebased on the latest main, added the early termination check and a
separate commit with minor cleanups.
Please let me know if you'd like me to squash them all before the merge.
dweiss commented on PR #12965:
URL: https://github.com/apache/lucene/pull/12965#issuecomment-1876672741
Yep, I think this early termination condition makes sense. Could you add it,
please? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message,
sabi0 commented on PR #12965:
URL: https://github.com/apache/lucene/pull/12965#issuecomment-1867009056
It seems the method could be skipped completely if the query does not
contain `fieldName` or `defaultField`:
```
protected void extractWeightedSpanTerms(Map
terms, SpanQuery
sabi0 opened a new pull request, #12965:
URL: https://github.com/apache/lucene/pull/12965
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
