[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531926#comment-17531926
]
Mike Sokolov commented on LUCENE-10335:
---
sure - I opened
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531876#comment-17531876
]
Tomoko Uchida commented on LUCENE-10335:
Hi [~sokolov] , can you please open an issue?
>
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531873#comment-17531873
]
Uwe Schindler commented on LUCENE-10335:
What I wanted to say: if it breaks in classpath mode,
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531870#comment-17531870
]
Uwe Schindler commented on LUCENE-10335:
Migrate.txt or .md was more about module system not
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531851#comment-17531851
]
Michael Sokolov commented on LUCENE-10335:
--
Thanks, Uwe, you're right I confused the issues.
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531847#comment-17531847
]
Uwe Schindler commented on LUCENE-10335:
bq. would load the resource from the given path, but
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531841#comment-17531841
]
Uwe Schindler commented on LUCENE-10335:
If you use CustomAnalyzer, you can pass
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531839#comment-17531839
]
Uwe Schindler commented on LUCENE-10335:
We did not change the method here, it was just
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531809#comment-17531809
]
Michael Sokolov commented on LUCENE-10335:
--
This issue broke backwards compatibility. I think
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467932#comment-17467932
]
Uwe Schindler commented on LUCENE-10335:
See followup: LUCENE-10348
>
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467898#comment-17467898
]
ASF subversion and git services commented on LUCENE-10335:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467895#comment-17467895
]
ASF subversion and git services commented on LUCENE-10335:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467875#comment-17467875
]
ASF subversion and git services commented on LUCENE-10335:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467874#comment-17467874
]
ASF subversion and git services commented on LUCENE-10335:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17465199#comment-17465199
]
Tomoko Uchida commented on LUCENE-10335:
Opened an issue -
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17465196#comment-17465196
]
Uwe Schindler commented on LUCENE-10335:
Should be fine:
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17465195#comment-17465195
]
Tomoko Uchida commented on LUCENE-10335:
I just added "requires static jdk.management;" to
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17465194#comment-17465194
]
Uwe Schindler commented on LUCENE-10335:
This again brings the question up: users can't detect
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17465193#comment-17465193
]
Uwe Schindler commented on LUCENE-10335:
You also need access to the hotspot bean. Without it
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17465192#comment-17465192
]
Uwe Schindler commented on LUCENE-10335:
Let's open an issue and decide from there. I looked at
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17465191#comment-17465191
]
Tomoko Uchida commented on LUCENE-10335:
Okay, I will make a patch - I wrote the previous
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17465190#comment-17465190
]
Tomoko Uchida commented on LUCENE-10335:
Let me know if the patch is needed - I just found the
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17465189#comment-17465189
]
Uwe Schindler commented on LUCENE-10335:
This one was always optional. If we can't get the
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17465162#comment-17465162
]
Dawid Weiss commented on LUCENE-10335:
--
optional module requirements can be declared - these are
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17465160#comment-17465160
]
Tomoko Uchida commented on LUCENE-10335:
I think it is needed or mandatory at runtime?
>
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17465159#comment-17465159
]
Uwe Schindler commented on LUCENE-10335:
Yes thanks for finding this. But it won't fail, we
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17465157#comment-17465157
]
Tomoko Uchida commented on LUCENE-10335:
It is off-topic here, I encountered this warning when
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464500#comment-17464500
]
Uwe Schindler commented on LUCENE-10335:
Hi [~dweiss],
I did this (and more) in
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464494#comment-17464494
]
Dawid Weiss commented on LUCENE-10335:
--
+1. Thanks Uwe.
> IOUtils.getDecodingReader(Class,
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464452#comment-17464452
]
Uwe Schindler commented on LUCENE-10335:
Hi Dawid,
thanks for the patch. Actually the Supplier
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464334#comment-17464334
]
Dawid Weiss commented on LUCENE-10335:
--
The attached seems to fix all of them and adds a
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464331#comment-17464331
]
Dawid Weiss commented on LUCENE-10335:
--
You may be right that the lambda version may be sufficient
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464321#comment-17464321
]
Dawid Weiss commented on LUCENE-10335:
--
There is no need for an immediate fix as this only applies
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464182#comment-17464182
]
Uwe Schindler commented on LUCENE-10335:
I can look into this tomorrow.
>From what I see the
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464062#comment-17464062
]
Uwe Schindler commented on LUCENE-10335:
I am fine with that. The problem I saw quite often is
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464055#comment-17464055
]
Dawid Weiss commented on LUCENE-10335:
--
I'm only talking about this variant of the method, Uwe -
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464053#comment-17464053
]
Uwe Schindler commented on LUCENE-10335:
As said in my first comment, there's no reason to not
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464051#comment-17464051
]
Dawid Weiss commented on LUCENE-10335:
--
> Every utility method that takes takes a class and calls
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464050#comment-17464050
]
Uwe Schindler commented on LUCENE-10335:
Yes I figured, it is caller sensitive:
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464049#comment-17464049
]
Dawid Weiss commented on LUCENE-10335:
--
If you don't believe me, write a snippet of code that
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464048#comment-17464048
]
Dawid Weiss commented on LUCENE-10335:
--
And it's exactly how it works. So unless you want to open
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464046#comment-17464046
]
Dawid Weiss commented on LUCENE-10335:
--
Resources in named modules are subject to the rules for
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464045#comment-17464045
]
Uwe Schindler commented on LUCENE-10335:
It is not caller sensitive. I have the feeling your
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464040#comment-17464040
]
Uwe Schindler commented on LUCENE-10335:
I wonder why it is broken. Because you can use
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464036#comment-17464036
]
Dawid Weiss commented on LUCENE-10335:
--
btw - I know it's broken because I have it failing
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464035#comment-17464035
]
Dawid Weiss commented on LUCENE-10335:
--
take a look at JavascriptCompiler - it calls this method
[
https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464033#comment-17464033
]
Uwe Schindler commented on LUCENE-10335:
This should work inside the same module.
>
47 matches
Mail list logo
