[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526849#comment-17526849
]
Tomoko Uchida commented on LUCENE-10528:
bq. I'm against marking a test slow when it isn't
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526846#comment-17526846
]
Robert Muir commented on LUCENE-10528:
--
I opened followup: LUCENE-10532
>
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526845#comment-17526845
]
ASF subversion and git services commented on LUCENE-10528:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526844#comment-17526844
]
Robert Muir commented on LUCENE-10528:
--
I merged this PR so that i can cleanly -1 any @Slow usage
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526843#comment-17526843
]
ASF subversion and git services commented on LUCENE-10528:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526842#comment-17526842
]
Robert Muir commented on LUCENE-10528:
--
I'm against marking a test slow when it isn't slow. also,
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526799#comment-17526799
]
Tomoko Uchida commented on LUCENE-10528:
I opened [LUCENE-10531] to describe what is in my
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526769#comment-17526769
]
Dawid Weiss commented on LUCENE-10528:
--
I agree - let's mark it slow. I run slow tests
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526767#comment-17526767
]
Tomoko Uchida commented on LUCENE-10528:
Maybe my explanation wouldn't be good; I'm not sure
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526763#comment-17526763
]
Tomoko Uchida commented on LUCENE-10528:
bq. xvfb hack only applies for *nix, not mac or
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526761#comment-17526761
]
Robert Muir commented on LUCENE-10528:
--
I don't think we need to change the test to {{@Slow}}.
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526756#comment-17526756
]
Tomoko Uchida commented on LUCENE-10528:
As I said in the PR, I'm fine with running it on Xvfb
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526207#comment-17526207
]
Dawid Weiss commented on LUCENE-10528:
--
Should we do it for an entire gradle process though? Why
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526083#comment-17526083
]
Robert Muir commented on LUCENE-10528:
--
Here's the simplest patch that fixes it:
{noformat}
---
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526081#comment-17526081
]
Robert Muir commented on LUCENE-10528:
--
I would prefer autodetecting, since it would make CI and
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526073#comment-17526073
]
Robert Muir commented on LUCENE-10528:
--
I guess i'm just proposing we either:
1. auto-detect xvfb
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526065#comment-17526065
]
Robert Muir commented on LUCENE-10528:
--
I run slow tests and i'm willing to install xvfb so that
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526064#comment-17526064
]
Dawid Weiss commented on LUCENE-10528:
--
There are so many layers to awt/swing support that it
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526056#comment-17526056
]
Robert Muir commented on LUCENE-10528:
--
Could the test on *nix look for the presence of xvfb-run
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526054#comment-17526054
]
Robert Muir commented on LUCENE-10528:
--
sure, but does it need to display real windows on my
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526050#comment-17526050
]
Dawid Weiss commented on LUCENE-10528:
--
Hmm... But we want to run this test occasionally, don't
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525999#comment-17525999
]
Robert Muir commented on LUCENE-10528:
--
One option, we could unset DISPLAY in the ./gradlew
22 matches
Mail list logo
