[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-11-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984473#comment-16984473 ] ASF subversion and git services commented on LUCENE-8213: - Commit

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-11-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984472#comment-16984472 ] ASF subversion and git services commented on LUCENE-8213: - Commit

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-11-07 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969631#comment-16969631 ] Adrien Grand commented on LUCENE-8213: -- [~ben.manes] I believe this would work. Regarding Caffeine,

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-11-07 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969632#comment-16969632 ] Adrien Grand commented on LUCENE-8213: -- If you want to give it a try, I'd be happy to review it. >

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-11-03 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965724#comment-16965724 ] Ben Manes commented on LUCENE-8213: --- Sorry to distract. I am trying to understand {{LRUQueryCache}} as

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-04 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944259#comment-16944259 ] Adrien Grand commented on LUCENE-8213: -- I don't think these queries have anything special besides

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-02 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943217#comment-16943217 ] Chris M. Hostetter commented on LUCENE-8213: FWIW: I just attached

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-02 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942788#comment-16942788 ] Atri Sharma commented on LUCENE-8213: - [~jpountz] Just noticed your latest comment – I raised a PR

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-02 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942629#comment-16942629 ] Atri Sharma commented on LUCENE-8213: - [~jpountz] I am not sure I follow – inFlightAsyncQueries map

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-02 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942623#comment-16942623 ] Adrien Grand commented on LUCENE-8213: -- Can we do this as a separate change that applies to both

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942616#comment-16942616 ] ASF subversion and git services commented on LUCENE-8213: - Commit

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942587#comment-16942587 ] ASF subversion and git services commented on LUCENE-8213: - Commit

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-02 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942570#comment-16942570 ] Adrien Grand commented on LUCENE-8213: -- I'd rather revert to stop test failures as soon as

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-02 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942551#comment-16942551 ] Atri Sharma commented on LUCENE-8213: - Hi [~jpountz] bq. It would probably make things easier

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-01 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942285#comment-16942285 ] Atri Sharma commented on LUCENE-8213: - Attached is a patch which reproduces the issue [~jpountz] 

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-01 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942139#comment-16942139 ] Adrien Grand commented on LUCENE-8213: -- The {{inFlightAsyncLoadQueries}} logic doesn't look right.

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-01 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942061#comment-16942061 ] Atri Sharma commented on LUCENE-8213: - [~ivera], I am not referring to the LatLonShape failure –  I

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-01 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942052#comment-16942052 ] Ignacio Vera commented on LUCENE-8213: -- Wait [~atris]    I don't think this is a proper solution

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-01 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941913#comment-16941913 ] Atri Sharma commented on LUCENE-8213: - [~ivera] , Regarding the other failure in TestLRUQueryCache,

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-01 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941772#comment-16941772 ] Atri Sharma commented on LUCENE-8213: - Opened [https://github.com/apache/lucene-solr/pull/912]  

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-10-01 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941696#comment-16941696 ] Ignacio Vera commented on LUCENE-8213: -- Hi [~atris], We have another error in CI that I think it

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-09-30 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940798#comment-16940798 ] Atri Sharma commented on LUCENE-8213: - Interesting – I did not realise that testLRUEviction could

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-09-30 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940677#comment-16940677 ] Ignacio Vera commented on LUCENE-8213: -- Here is the failure:

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-09-30 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940673#comment-16940673 ] Atri Sharma commented on LUCENE-8213: - Taking a look – although I am unable to reproduce with a

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-09-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940024#comment-16940024 ] ASF subversion and git services commented on LUCENE-8213: - Commit