[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975742#comment-16975742
]
ASF subversion and git services commented on LUCENE-8920:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975067#comment-16975067
]
ASF subversion and git services commented on LUCENE-8920:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975062#comment-16975062
]
Michael Sokolov commented on LUCENE-8920:
-
I backported to 8x branch and beasted 20 times. I am
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975049#comment-16975049
]
Michael Sokolov commented on LUCENE-8920:
-
> Actually I generated them (so with
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975020#comment-16975020
]
ASF subversion and git services commented on LUCENE-8920:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974937#comment-16974937
]
Bruno Roustant commented on LUCENE-8920:
I added PR#1012 to fix the flapper test. This test
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974674#comment-16974674
]
Michael Sokolov commented on LUCENE-8920:
-
> In that case the version bump is not strictly
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974637#comment-16974637
]
Adrien Grand commented on LUCENE-8920:
--
bq. I don't recall when that is validated (on each test or
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974569#comment-16974569
]
Michael Sokolov commented on LUCENE-8920:
-
I'll run the `luceneutil` test just to be sure
>
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974410#comment-16974410
]
Michael Sokolov commented on LUCENE-8920:
-
I had tested with the previous version of this patch,
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974400#comment-16974400
]
Bruno Roustant commented on LUCENE-8920:
{quote}I want to confirm we have back-compat handled.
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974386#comment-16974386
]
David Smiley commented on LUCENE-8920:
--
I want to confirm we have back-compat handled. Do we? A
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974250#comment-16974250
]
Adrien Grand commented on LUCENE-8920:
--
Thanks for checking [~sokolov]!
> Reduce size of FSTs due
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974039#comment-16974039
]
ASF subversion and git services commented on LUCENE-8920:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974041#comment-16974041
]
ASF subversion and git services commented on LUCENE-8920:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974042#comment-16974042
]
ASF subversion and git services commented on LUCENE-8920:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974043#comment-16974043
]
ASF subversion and git services commented on LUCENE-8920:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974036#comment-16974036
]
ASF subversion and git services commented on LUCENE-8920:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974038#comment-16974038
]
ASF subversion and git services commented on LUCENE-8920:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974037#comment-16974037
]
ASF subversion and git services commented on LUCENE-8920:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973993#comment-16973993
]
Adrien Grand commented on LUCENE-8920:
--
This gives a nice bump on the PKLookup task
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973729#comment-16973729
]
ASF subversion and git services commented on LUCENE-8920:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972414#comment-16972414
]
Michael Sokolov commented on LUCENE-8920:
-
+1 for merging, and handling {cachedRootArcs}
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972390#comment-16972390
]
Adrien Grand commented on LUCENE-8920:
--
Yes, doing this in a separate JIRA sounds like a good idea
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971855#comment-16971855
]
Adrien Grand commented on LUCENE-8920:
--
bq. But the final decision for the default memory/perf
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971231#comment-16971231
]
Michael Sokolov commented on LUCENE-8920:
-
Something that was brought up in the past was that we
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971138#comment-16971138
]
Bruno Roustant commented on LUCENE-8920:
I added the expansion credit to the PR#980. This indeed
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970888#comment-16970888
]
Bruno Roustant commented on LUCENE-8920:
{quote}Out of curiosity, have you confirmed this?
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970778#comment-16970778
]
Adrien Grand commented on LUCENE-8920:
--
bq. If we set default oversizing factor 1, we will
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970755#comment-16970755
]
Bruno Roustant commented on LUCENE-8920:
{quote}maybe we should set a less aggressive default
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970650#comment-16970650
]
Adrien Grand commented on LUCENE-8920:
--
I quickly skimmed through the patch, the approach looks
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970444#comment-16970444
]
Bruno Roustant commented on LUCENE-8920:
It works. I removed the labels for direct-addressing,
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965650#comment-16965650
]
Bruno Roustant commented on LUCENE-8920:
Hum, I was confused by the special case of END_LABEL.
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965008#comment-16965008
]
Adrien Grand commented on LUCENE-8920:
--
Wouldn't the bitTable be the same as the bitTable of the
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964993#comment-16964993
]
Bruno Roustant commented on LUCENE-8920:
{quote}Maybe we should update the naming with your
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964854#comment-16964854
]
Adrien Grand commented on LUCENE-8920:
--
Maybe we should update the naming with your proposed
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964432#comment-16964432
]
Bruno Roustant commented on LUCENE-8920:
I have pushed more commits to PR#980 to clean the code
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960654#comment-16960654
]
Bruno Roustant commented on LUCENE-8920:
I have added PR #980 to reduce the memory used by
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952082#comment-16952082
]
Michael Sokolov commented on LUCENE-8920:
-
> store outputs in a parallel array
This could save
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951755#comment-16951755
]
Adrien Grand commented on LUCENE-8920:
--
I was thinking we could store outputs in a parallel array,
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951742#comment-16951742
]
Bruno Roustant commented on LUCENE-8920:
{quote}maybe we should also consider some encoding
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951335#comment-16951335
]
Bruno Roustant commented on LUCENE-8920:
{quote}store data in order, e.g. by using a hash
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951225#comment-16951225
]
ASF subversion and git services commented on LUCENE-8920:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951224#comment-16951224
]
Adrien Grand commented on LUCENE-8920:
--
I reverted the change until we can better handle the
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951199#comment-16951199
]
ASF subversion and git services commented on LUCENE-8920:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951122#comment-16951122
]
ASF subversion and git services commented on LUCENE-8920:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1695#comment-1695
]
Adrien Grand commented on LUCENE-8920:
--
bq. Open-addressing does not keep the ordering. Dead-end, I
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951033#comment-16951033
]
Bruno Roustant commented on LUCENE-8920:
Update about my try with open-addressing.
In fact
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950862#comment-16950862
]
Adrien Grand commented on LUCENE-8920:
--
[~sokolov] I added a test case that simulates indexing with
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949654#comment-16949654
]
Adrien Grand commented on LUCENE-8920:
--
Right, this is what I had in mind, trying to reproduce the
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949647#comment-16949647
]
Michael Sokolov commented on LUCENE-8920:
-
{{For posterity, this is the worst case test that
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949635#comment-16949635
]
Michael Sokolov commented on LUCENE-8920:
-
I think you had previously created a test case for
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949575#comment-16949575
]
Adrien Grand commented on LUCENE-8920:
--
Ah sorry it was not clear to me this was blocking you. I
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949568#comment-16949568
]
Michael Sokolov commented on LUCENE-8920:
-
Fine by me. I find it too difficult to iterate on a
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949498#comment-16949498
]
Adrien Grand commented on LUCENE-8920:
--
Changing the constant would work for me, I just wonder that
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948770#comment-16948770
]
Michael Sokolov commented on LUCENE-8920:
-
> Can we simply change the constant
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948635#comment-16948635
]
Bruno Roustant commented on LUCENE-8920:
Can we simply change the constant
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948593#comment-16948593
]
Adrien Grand commented on LUCENE-8920:
--
[~sokolov] The 3x-4x increase was me trying to reason about
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948581#comment-16948581
]
Michael Sokolov commented on LUCENE-8920:
-
Previous report was of a 3-4x increase - I think what
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948487#comment-16948487
]
Ignacio Vera commented on LUCENE-8920:
--
With the upcoming release of Lucene 8.3.0, this issue is
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946960#comment-16946960
]
Bruno Roustant commented on LUCENE-8920:
Good advice. I'll still first start to ramp up, and
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946777#comment-16946777
]
David Wayne Smiley commented on LUCENE-8920:
You _might_ want to start with a bit of
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1694#comment-1694
]
Bruno Roustant commented on LUCENE-8920:
I'm starting to work on the implementation today, to
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939988#comment-16939988
]
Michael Sokolov commented on LUCENE-8920:
-
OK, I just wanted to make sure we were talking
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939258#comment-16939258
]
Bruno Roustant commented on LUCENE-8920:
I should invert D1 for clarity, as you did:
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939251#comment-16939251
]
Bruno Roustant commented on LUCENE-8920:
{quote}I believe the current FST does not have D1=0.66
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938935#comment-16938935
]
Michael Sokolov commented on LUCENE-8920:
-
> Here is a proposal for the heuristic to select the
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938389#comment-16938389
]
Bruno Roustant commented on LUCENE-8920:
Here is a proposal for the heuristic to select the
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931528#comment-16931528
]
Bruno Roustant commented on LUCENE-8920:
{quote}list-encoding for small N, and consider open
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931367#comment-16931367
]
Mike Sokolov commented on LUCENE-8920:
--
This is cool. Regarding the strategy for which encoding to
[
https://issues.apache.org/jira/browse/LUCENE-8920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16930608#comment-16930608
]
Bruno Roustant commented on LUCENE-8920:
Open-addressing benchmark to store byte labels in an
71 matches
Mail list logo