[
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054523#comment-17054523
]
Mikhail Khludnev commented on SOLR-12325:
-
Thanks [~munendrasn] and [~anatolii_siuniaev], let's
[
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052324#comment-17052324
]
Munendra S N commented on SOLR-12325:
-
+1 to adding additional test
Few nitpicks
* Remove any usage
[
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049810#comment-17049810
]
Lucene/Solr QA commented on SOLR-12325:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049634#comment-17049634
]
Mikhail Khludnev commented on SOLR-12325:
-
Attaching random test patch by [~anatolii_siuniaev],
[
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039266#comment-17039266
]
Lucene/Solr QA commented on SOLR-12325:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028469#comment-17028469
]
Mikhail Khludnev commented on SOLR-12325:
-
Ok I spotted escaping issue in
[
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028422#comment-17028422
]
ASF subversion and git services commented on SOLR-12325:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028419#comment-17028419
]
ASF subversion and git services commented on SOLR-12325:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028263#comment-17028263
]
Munendra S N commented on SOLR-12325:
-
Thanks Mikhail for tackling this.
+1, LGTM
> introduce
[
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028240#comment-17028240
]
Lucene/Solr QA commented on SOLR-12325:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028221#comment-17028221
]
Mikhail Khludnev commented on SOLR-12325:
-
Slightly tweaked, [~anatolii_siuniaev]'s patch.
Now
[
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024847#comment-17024847
]
Munendra S N commented on SOLR-12325:
-
Apologies Mikhail, I was caught in some other thing.
+1 to
[
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024637#comment-17024637
]
Mikhail Khludnev commented on SOLR-12325:
-
No concerns so far. I'm going to revamp syntax as
[
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023923#comment-17023923
]
Mikhail Khludnev commented on SOLR-12325:
-
[~munendrasn] thanks for your feedback. I think it's
[
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023724#comment-17023724
]
Munendra S N commented on SOLR-12325:
-
* When {{parentBitSet}} is null, we get NPE. {{parentBitSet}}
[
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023707#comment-17023707
]
Lucene/Solr QA commented on SOLR-12325:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023610#comment-17023610
]
Lucene/Solr QA commented on SOLR-12325:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023184#comment-17023184
]
Lucene/Solr QA commented on SOLR-12325:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17020553#comment-17020553
]
Lucene/Solr QA commented on SOLR-12325:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
19 matches
Mail list logo